From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJZdK-0000B4-E2 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 04:21:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJZdG-0006r5-N4 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 04:21:28 -0400 Received: from mga01.intel.com ([192.55.52.88]:22804) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJZdF-0006nA-73 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 04:21:26 -0400 Date: Thu, 25 Apr 2019 16:20:50 +0800 From: Wei Yang Message-ID: <20190425082050.GF24829@richard> Reply-To: Wei Yang References: <1556170489-131927-1-git-send-email-imammedo@redhat.com> <1556170489-131927-13-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1556170489-131927-13-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 12/13] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Laszlo Ersek , "Michael S. Tsirkin" , Gonglei , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Shannon Zhao , Wei Yang , Andrew Jones , Shameer Kolothum , Ben Warren On Thu, Apr 25, 2019 at 07:34:48AM +0200, Igor Mammedov wrote: >Make initial list contain aarch64 and x86_64 targets. so i386 is taken out? > >Signed-off-by: Igor Mammedov >Reviewed-by: Philippe Mathieu-Daudé >--- >v2: > * fix up error message (Philippe Mathieu-Daudé ) >--- > tests/data/acpi/rebuild-expected-aml.sh | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) > >diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi/rebuild-expected-aml.sh >index abdff70..52793f3 100755 >--- a/tests/data/acpi/rebuild-expected-aml.sh >+++ b/tests/data/acpi/rebuild-expected-aml.sh >@@ -7,21 +7,12 @@ > # > # Authors: > # Marcel Apfelbaum >+# Igor Mammedov > # > # This work is licensed under the terms of the GNU GPLv2. > # See the COPYING.LIB file in the top-level directory. > >-qemu= >- >-if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then >- qemu="x86_64-softmmu/qemu-system-x86_64" >-elif [ -e i386-softmmu/qemu-system-i386 ]; then >- qemu="i386-softmmu/qemu-system-i386" >-else >- echo "Run 'make' to build the qemu exectutable!" >- echo "Run this script from the build directory." >- exit 1; >-fi >+qemu_bins="aarch64-softmmu/qemu-system-aarch64 x86_64-softmmu/qemu-system-x86_64" > > if [ ! -e "tests/bios-tables-test" ]; then > echo "Test: bios-tables-test is required! Run make check before this script." >@@ -29,6 +20,14 @@ if [ ! -e "tests/bios-tables-test" ]; then > exit 1; > fi > >-TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/bios-tables-test >+for qemu in $qemu_bins; do >+ if [ ! -e $qemu ]; then >+ echo "Run 'make' to build the following QEMU exectutables: $qemu_bins" s/exectutables/executables >+ echo "Also, run this script from the build directory." >+ exit 1; >+ fi >+ TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/bios-tables-test >+done >+ The original behavior is either one executable exist will pass. But now, either of one doesn't exist will fail. Is this what we expect? > > echo "The files were rebuilt and can be added to git." >-- >2.7.4 -- Wei Yang Help you, Help me From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA252C10F03 for ; Thu, 25 Apr 2019 08:22:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79C00214AE for ; Thu, 25 Apr 2019 08:22:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79C00214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:53713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJZeB-0000fx-Lo for qemu-devel@archiver.kernel.org; Thu, 25 Apr 2019 04:22:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJZdK-0000B4-E2 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 04:21:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJZdG-0006r5-N4 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 04:21:28 -0400 Received: from mga01.intel.com ([192.55.52.88]:22804) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJZdF-0006nA-73 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 04:21:26 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 01:21:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,393,1549958400"; d="scan'208";a="164924961" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga004.fm.intel.com with ESMTP; 25 Apr 2019 01:21:17 -0700 Date: Thu, 25 Apr 2019 16:20:50 +0800 From: Wei Yang To: Igor Mammedov Message-ID: <20190425082050.GF24829@richard> References: <1556170489-131927-1-git-send-email-imammedo@redhat.com> <1556170489-131927-13-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1556170489-131927-13-git-send-email-imammedo@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 Subject: Re: [Qemu-devel] [PATCH v3 12/13] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: Andrew Jones , Ben Warren , "Michael S. Tsirkin" , Laszlo Ersek , qemu-devel@nongnu.org, Shameer Kolothum , Shannon Zhao , Gonglei , Wei Yang , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190425082050.OJvmFL1AdFpIhbvt2jbGFakPET6VmIdGxJXYYF8cpmY@z> On Thu, Apr 25, 2019 at 07:34:48AM +0200, Igor Mammedov wrote: >Make initial list contain aarch64 and x86_64 targets. so i386 is taken out? > >Signed-off-by: Igor Mammedov >Reviewed-by: Philippe Mathieu-Daudé >--- >v2: > * fix up error message (Philippe Mathieu-Daudé ) >--- > tests/data/acpi/rebuild-expected-aml.sh | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) > >diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi/rebuild-expected-aml.sh >index abdff70..52793f3 100755 >--- a/tests/data/acpi/rebuild-expected-aml.sh >+++ b/tests/data/acpi/rebuild-expected-aml.sh >@@ -7,21 +7,12 @@ > # > # Authors: > # Marcel Apfelbaum >+# Igor Mammedov > # > # This work is licensed under the terms of the GNU GPLv2. > # See the COPYING.LIB file in the top-level directory. > >-qemu= >- >-if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then >- qemu="x86_64-softmmu/qemu-system-x86_64" >-elif [ -e i386-softmmu/qemu-system-i386 ]; then >- qemu="i386-softmmu/qemu-system-i386" >-else >- echo "Run 'make' to build the qemu exectutable!" >- echo "Run this script from the build directory." >- exit 1; >-fi >+qemu_bins="aarch64-softmmu/qemu-system-aarch64 x86_64-softmmu/qemu-system-x86_64" > > if [ ! -e "tests/bios-tables-test" ]; then > echo "Test: bios-tables-test is required! Run make check before this script." >@@ -29,6 +20,14 @@ if [ ! -e "tests/bios-tables-test" ]; then > exit 1; > fi > >-TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/bios-tables-test >+for qemu in $qemu_bins; do >+ if [ ! -e $qemu ]; then >+ echo "Run 'make' to build the following QEMU exectutables: $qemu_bins" s/exectutables/executables >+ echo "Also, run this script from the build directory." >+ exit 1; >+ fi >+ TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/bios-tables-test >+done >+ The original behavior is either one executable exist will pass. But now, either of one doesn't exist will fail. Is this what we expect? > > echo "The files were rebuilt and can be added to git." >-- >2.7.4 -- Wei Yang Help you, Help me