From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJccl-0000LQ-Qb for qemu-devel@nongnu.org; Thu, 25 Apr 2019 07:33:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJccj-00050P-RW for qemu-devel@nongnu.org; Thu, 25 Apr 2019 07:33:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42316) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJcch-0004wl-QX for qemu-devel@nongnu.org; Thu, 25 Apr 2019 07:33:05 -0400 Date: Thu, 25 Apr 2019 13:32:50 +0200 From: Igor Mammedov Message-ID: <20190425133250.69ec66dc@redhat.com> In-Reply-To: <20190425082050.GF24829@richard> References: <1556170489-131927-1-git-send-email-imammedo@redhat.com> <1556170489-131927-13-git-send-email-imammedo@redhat.com> <20190425082050.GF24829@richard> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 12/13] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Yang Cc: qemu-devel@nongnu.org, Laszlo Ersek , "Michael S. Tsirkin" , Gonglei , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Shannon Zhao , Andrew Jones , Shameer Kolothum , Ben Warren On Thu, 25 Apr 2019 16:20:50 +0800 Wei Yang wrote: > On Thu, Apr 25, 2019 at 07:34:48AM +0200, Igor Mammedov wrote: > >Make initial list contain aarch64 and x86_64 targets. =20 >=20 > so i386 is taken out? >=20 > > > >Signed-off-by: Igor Mammedov > >Reviewed-by: Philippe Mathieu-Daud=C3=A9 > >--- > >v2: > > * fix up error message (Philippe Mathieu-Daud=C3=A9 ) > >--- > > tests/data/acpi/rebuild-expected-aml.sh | 23 +++++++++++------------ > > 1 file changed, 11 insertions(+), 12 deletions(-) > > > >diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi/r= ebuild-expected-aml.sh > >index abdff70..52793f3 100755 > >--- a/tests/data/acpi/rebuild-expected-aml.sh > >+++ b/tests/data/acpi/rebuild-expected-aml.sh > >@@ -7,21 +7,12 @@ > > # > > # Authors: > > # Marcel Apfelbaum > >+# Igor Mammedov > > # > > # This work is licensed under the terms of the GNU GPLv2. > > # See the COPYING.LIB file in the top-level directory. > >=20 > >-qemu=3D > >- > >-if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then > >- qemu=3D"x86_64-softmmu/qemu-system-x86_64" > >-elif [ -e i386-softmmu/qemu-system-i386 ]; then > >- qemu=3D"i386-softmmu/qemu-system-i386" > >-else > >- echo "Run 'make' to build the qemu exectutable!" > >- echo "Run this script from the build directory." > >- exit 1; > >-fi > >+qemu_bins=3D"aarch64-softmmu/qemu-system-aarch64 x86_64-softmmu/qemu-sy= stem-x86_64" > >=20 > > if [ ! -e "tests/bios-tables-test" ]; then > > echo "Test: bios-tables-test is required! Run make check before thi= s script." > >@@ -29,6 +20,14 @@ if [ ! -e "tests/bios-tables-test" ]; then > > exit 1; > > fi > >=20 > >-TEST_ACPI_REBUILD_AML=3Dy QTEST_QEMU_BINARY=3D$qemu tests/bios-tables-t= est > >+for qemu in $qemu_bins; do > >+ if [ ! -e $qemu ]; then > >+ echo "Run 'make' to build the following QEMU exectutables: $qem= u_bins" =20 >=20 > s/exectutables/executables fixed =20 > >+ echo "Also, run this script from the build directory." > >+ exit 1; > >+ fi > >+ TEST_ACPI_REBUILD_AML=3Dy QTEST_QEMU_BINARY=3D$qemu tests/bios-tabl= es-test > >+done > >+ =20 >=20 > The original behavior is either one executable exist will pass. >=20 > But now, either of one doesn't exist will fail. Is this what we expect? It's mainly maintainers tool to update reference blobs. And I intentionally made it fail to force maintainer/developer building all targets that depend on ACPI to make sure that mistakes won't silently creep in due to non build target. > > echo "The files were rebuilt and can be added to git." > >--=20 > >2.7.4 =20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C940FC10F03 for ; Thu, 25 Apr 2019 11:34:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A69D20811 for ; Thu, 25 Apr 2019 11:34:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A69D20811 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:55595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJcdm-0000i7-SJ for qemu-devel@archiver.kernel.org; Thu, 25 Apr 2019 07:34:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJccl-0000LQ-Qb for qemu-devel@nongnu.org; Thu, 25 Apr 2019 07:33:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJccj-00050P-RW for qemu-devel@nongnu.org; Thu, 25 Apr 2019 07:33:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42316) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJcch-0004wl-QX for qemu-devel@nongnu.org; Thu, 25 Apr 2019 07:33:05 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2561481E16; Thu, 25 Apr 2019 11:33:02 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 04A68600C1; Thu, 25 Apr 2019 11:32:54 +0000 (UTC) Date: Thu, 25 Apr 2019 13:32:50 +0200 From: Igor Mammedov To: Wei Yang Message-ID: <20190425133250.69ec66dc@redhat.com> In-Reply-To: <20190425082050.GF24829@richard> References: <1556170489-131927-1-git-send-email-imammedo@redhat.com> <1556170489-131927-13-git-send-email-imammedo@redhat.com> <20190425082050.GF24829@richard> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 25 Apr 2019 11:33:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3 12/13] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jones , Ben Warren , "Michael S. Tsirkin" , Laszlo Ersek , qemu-devel@nongnu.org, Shameer Kolothum , Shannon Zhao , Gonglei , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190425113250.QuFGmyO6a4JCxYUZqZ3MA7FebSP4-NQ4JvCyLQ0eMtU@z> On Thu, 25 Apr 2019 16:20:50 +0800 Wei Yang wrote: > On Thu, Apr 25, 2019 at 07:34:48AM +0200, Igor Mammedov wrote: > >Make initial list contain aarch64 and x86_64 targets. =20 >=20 > so i386 is taken out? >=20 > > > >Signed-off-by: Igor Mammedov > >Reviewed-by: Philippe Mathieu-Daud=C3=A9 > >--- > >v2: > > * fix up error message (Philippe Mathieu-Daud=C3=A9 ) > >--- > > tests/data/acpi/rebuild-expected-aml.sh | 23 +++++++++++------------ > > 1 file changed, 11 insertions(+), 12 deletions(-) > > > >diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi/r= ebuild-expected-aml.sh > >index abdff70..52793f3 100755 > >--- a/tests/data/acpi/rebuild-expected-aml.sh > >+++ b/tests/data/acpi/rebuild-expected-aml.sh > >@@ -7,21 +7,12 @@ > > # > > # Authors: > > # Marcel Apfelbaum > >+# Igor Mammedov > > # > > # This work is licensed under the terms of the GNU GPLv2. > > # See the COPYING.LIB file in the top-level directory. > >=20 > >-qemu=3D > >- > >-if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then > >- qemu=3D"x86_64-softmmu/qemu-system-x86_64" > >-elif [ -e i386-softmmu/qemu-system-i386 ]; then > >- qemu=3D"i386-softmmu/qemu-system-i386" > >-else > >- echo "Run 'make' to build the qemu exectutable!" > >- echo "Run this script from the build directory." > >- exit 1; > >-fi > >+qemu_bins=3D"aarch64-softmmu/qemu-system-aarch64 x86_64-softmmu/qemu-sy= stem-x86_64" > >=20 > > if [ ! -e "tests/bios-tables-test" ]; then > > echo "Test: bios-tables-test is required! Run make check before thi= s script." > >@@ -29,6 +20,14 @@ if [ ! -e "tests/bios-tables-test" ]; then > > exit 1; > > fi > >=20 > >-TEST_ACPI_REBUILD_AML=3Dy QTEST_QEMU_BINARY=3D$qemu tests/bios-tables-t= est > >+for qemu in $qemu_bins; do > >+ if [ ! -e $qemu ]; then > >+ echo "Run 'make' to build the following QEMU exectutables: $qem= u_bins" =20 >=20 > s/exectutables/executables fixed =20 > >+ echo "Also, run this script from the build directory." > >+ exit 1; > >+ fi > >+ TEST_ACPI_REBUILD_AML=3Dy QTEST_QEMU_BINARY=3D$qemu tests/bios-tabl= es-test > >+done > >+ =20 >=20 > The original behavior is either one executable exist will pass. >=20 > But now, either of one doesn't exist will fail. Is this what we expect? It's mainly maintainers tool to update reference blobs. And I intentionally made it fail to force maintainer/developer building all targets that depend on ACPI to make sure that mistakes won't silently creep in due to non build target. > > echo "The files were rebuilt and can be added to git." > >--=20 > >2.7.4 =20 >=20