From: Zhang Chen <chen.zhang@intel.com > To: Laurent Vivier <laurent@vivier.eu>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela <quintela@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Markus Armbruster <armbru@redhat.com>, qemu-dev <qemu-devel@nongnu.org> Cc: Zhang Chen <zhangckid@gmail.com>, Zhang Chen <chen.zhang@intel.com> Subject: [Qemu-devel] [PATCH 1/3] migration/colo.c: Remove redundant input parameter Date: Fri, 26 Apr 2019 17:07:28 +0800 [thread overview] Message-ID: <20190426090730.2691-2-chen.zhang@intel.com> (raw) In-Reply-To: <20190426090730.2691-1-chen.zhang@intel.com> From: Zhang Chen <chen.zhang@intel.com> The colo_do_failover no need the input parameter. Signed-off-by: Zhang Chen <chen.zhang@intel.com> --- include/migration/colo.h | 2 +- migration/colo-failover.c | 2 +- migration/colo.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/migration/colo.h b/include/migration/colo.h index 99ce17aca7..ddebe0ad27 100644 --- a/include/migration/colo.h +++ b/include/migration/colo.h @@ -37,7 +37,7 @@ bool migration_incoming_in_colo_state(void); COLOMode get_colo_mode(void); /* failover */ -void colo_do_failover(MigrationState *s); +void colo_do_failover(void); void colo_checkpoint_notify(void *opaque); #endif diff --git a/migration/colo-failover.c b/migration/colo-failover.c index 4854a96c92..e9ca0b4774 100644 --- a/migration/colo-failover.c +++ b/migration/colo-failover.c @@ -39,7 +39,7 @@ static void colo_failover_bh(void *opaque) return; } - colo_do_failover(NULL); + colo_do_failover(); } void failover_request_active(Error **errp) diff --git a/migration/colo.c b/migration/colo.c index 238a6d62c7..8c1644091f 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -193,7 +193,7 @@ COLOMode get_colo_mode(void) } } -void colo_do_failover(MigrationState *s) +void colo_do_failover(void) { /* Make sure VM stopped while failover happened. */ if (!colo_runstate_is_stopped()) { -- 2.17.GIT
WARNING: multiple messages have this Message-ID (diff)
From: Zhang Chen <chen.zhang@intel.com > To: Laurent Vivier <laurent@vivier.eu>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela <quintela@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Markus Armbruster <armbru@redhat.com>, qemu-dev <qemu-devel@nongnu.org> Cc: Zhang Chen <chen.zhang@intel.com>, Zhang Chen <zhangckid@gmail.com> Subject: [Qemu-devel] [PATCH 1/3] migration/colo.c: Remove redundant input parameter Date: Fri, 26 Apr 2019 17:07:28 +0800 [thread overview] Message-ID: <20190426090730.2691-2-chen.zhang@intel.com> (raw) Message-ID: <20190426090728.s5HtoxhpuwGuQNViiy9yJoUgn2jSNJOeUNDrW9Ey6Cw@z> (raw) In-Reply-To: <20190426090730.2691-1-chen.zhang@intel.com> From: Zhang Chen <chen.zhang@intel.com> The colo_do_failover no need the input parameter. Signed-off-by: Zhang Chen <chen.zhang@intel.com> --- include/migration/colo.h | 2 +- migration/colo-failover.c | 2 +- migration/colo.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/migration/colo.h b/include/migration/colo.h index 99ce17aca7..ddebe0ad27 100644 --- a/include/migration/colo.h +++ b/include/migration/colo.h @@ -37,7 +37,7 @@ bool migration_incoming_in_colo_state(void); COLOMode get_colo_mode(void); /* failover */ -void colo_do_failover(MigrationState *s); +void colo_do_failover(void); void colo_checkpoint_notify(void *opaque); #endif diff --git a/migration/colo-failover.c b/migration/colo-failover.c index 4854a96c92..e9ca0b4774 100644 --- a/migration/colo-failover.c +++ b/migration/colo-failover.c @@ -39,7 +39,7 @@ static void colo_failover_bh(void *opaque) return; } - colo_do_failover(NULL); + colo_do_failover(); } void failover_request_active(Error **errp) diff --git a/migration/colo.c b/migration/colo.c index 238a6d62c7..8c1644091f 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -193,7 +193,7 @@ COLOMode get_colo_mode(void) } } -void colo_do_failover(MigrationState *s) +void colo_do_failover(void) { /* Make sure VM stopped while failover happened. */ if (!colo_runstate_is_stopped()) { -- 2.17.GIT
next prev parent reply other threads:[~2019-04-26 9:11 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-26 9:07 [Qemu-devel] [PATCH 0/3] Optimize COLO related codes and description Zhang Chen 2019-04-26 9:07 ` Zhang Chen 2019-04-26 9:07 ` Zhang Chen [this message] 2019-04-26 9:07 ` [Qemu-devel] [PATCH 1/3] migration/colo.c: Remove redundant input parameter Zhang Chen 2019-04-29 12:21 ` Dr. David Alan Gilbert 2019-04-29 12:21 ` Dr. David Alan Gilbert 2019-04-26 9:07 ` [Qemu-devel] [PATCH 2/3] migration/colo.h: Remove obsolete codes Zhang Chen 2019-04-26 9:07 ` Zhang Chen 2019-04-29 12:21 ` Dr. David Alan Gilbert 2019-04-29 12:21 ` Dr. David Alan Gilbert 2019-04-26 9:07 ` [Qemu-devel] [PATCH 3/3] qemu-option.hx: Update missed parameter for colo-compare Zhang Chen 2019-04-26 9:07 ` Zhang Chen 2019-04-29 12:25 ` Dr. David Alan Gilbert 2019-04-29 12:25 ` Dr. David Alan Gilbert 2019-05-10 2:11 ` [Qemu-devel] [PATCH 0/3] Optimize COLO related codes and description Zhang, Chen 2019-05-14 11:07 ` Dr. David Alan Gilbert 2019-05-14 14:06 ` Dr. David Alan Gilbert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190426090730.2691-2-chen.zhang@intel.com \ --to=chen.zhang@intel.com \ --cc=armbru@redhat.com \ --cc=dgilbert@redhat.com \ --cc=laurent@vivier.eu \ --cc=qemu-devel@nongnu.org \ --cc=quintela@redhat.com \ --cc=zhang.zhanghailiang@huawei.com \ --cc=zhangckid@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).