From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:52337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJwtK-0005Cg-SU for qemu-devel@nongnu.org; Fri, 26 Apr 2019 05:11:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJwtK-0003Oi-3i for qemu-devel@nongnu.org; Fri, 26 Apr 2019 05:11:34 -0400 Received: from mga04.intel.com ([192.55.52.120]:13453) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJwtJ-0003O8-Ql for qemu-devel@nongnu.org; Fri, 26 Apr 2019 05:11:34 -0400 From: Zhang Chen Date: Fri, 26 Apr 2019 17:07:28 +0800 Message-Id: <20190426090730.2691-2-chen.zhang@intel.com> In-Reply-To: <20190426090730.2691-1-chen.zhang@intel.com> References: <20190426090730.2691-1-chen.zhang@intel.com> Subject: [Qemu-devel] [PATCH 1/3] migration/colo.c: Remove redundant input parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , "Dr. David Alan Gilbert" , Juan Quintela , zhanghailiang , Markus Armbruster , qemu-dev Cc: Zhang Chen , Zhang Chen From: Zhang Chen The colo_do_failover no need the input parameter. Signed-off-by: Zhang Chen --- include/migration/colo.h | 2 +- migration/colo-failover.c | 2 +- migration/colo.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/migration/colo.h b/include/migration/colo.h index 99ce17aca7..ddebe0ad27 100644 --- a/include/migration/colo.h +++ b/include/migration/colo.h @@ -37,7 +37,7 @@ bool migration_incoming_in_colo_state(void); COLOMode get_colo_mode(void); /* failover */ -void colo_do_failover(MigrationState *s); +void colo_do_failover(void); void colo_checkpoint_notify(void *opaque); #endif diff --git a/migration/colo-failover.c b/migration/colo-failover.c index 4854a96c92..e9ca0b4774 100644 --- a/migration/colo-failover.c +++ b/migration/colo-failover.c @@ -39,7 +39,7 @@ static void colo_failover_bh(void *opaque) return; } - colo_do_failover(NULL); + colo_do_failover(); } void failover_request_active(Error **errp) diff --git a/migration/colo.c b/migration/colo.c index 238a6d62c7..8c1644091f 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -193,7 +193,7 @@ COLOMode get_colo_mode(void) } } -void colo_do_failover(MigrationState *s) +void colo_do_failover(void) { /* Make sure VM stopped while failover happened. */ if (!colo_runstate_is_stopped()) { -- 2.17.GIT From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD8BC43219 for ; Fri, 26 Apr 2019 09:12:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9264920675 for ; Fri, 26 Apr 2019 09:12:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9264920675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:43628 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJwue-0005yl-Qr for qemu-devel@archiver.kernel.org; Fri, 26 Apr 2019 05:12:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJwtK-0005Cg-SU for qemu-devel@nongnu.org; Fri, 26 Apr 2019 05:11:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJwtK-0003Oi-3i for qemu-devel@nongnu.org; Fri, 26 Apr 2019 05:11:34 -0400 Received: from mga04.intel.com ([192.55.52.120]:13453) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJwtJ-0003O8-Ql for qemu-devel@nongnu.org; Fri, 26 Apr 2019 05:11:34 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 02:11:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,397,1549958400"; d="scan'208";a="340969564" Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by fmsmga005.fm.intel.com with ESMTP; 26 Apr 2019 02:11:30 -0700 From: Zhang Chen To: Laurent Vivier , "Dr. David Alan Gilbert" , Juan Quintela , zhanghailiang , Markus Armbruster , qemu-dev Date: Fri, 26 Apr 2019 17:07:28 +0800 Message-Id: <20190426090730.2691-2-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.GIT In-Reply-To: <20190426090730.2691-1-chen.zhang@intel.com> References: <20190426090730.2691-1-chen.zhang@intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.120 Subject: [Qemu-devel] [PATCH 1/3] migration/colo.c: Remove redundant input parameter X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Zhang Chen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190426090728.s5HtoxhpuwGuQNViiy9yJoUgn2jSNJOeUNDrW9Ey6Cw@z> From: Zhang Chen The colo_do_failover no need the input parameter. Signed-off-by: Zhang Chen --- include/migration/colo.h | 2 +- migration/colo-failover.c | 2 +- migration/colo.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/migration/colo.h b/include/migration/colo.h index 99ce17aca7..ddebe0ad27 100644 --- a/include/migration/colo.h +++ b/include/migration/colo.h @@ -37,7 +37,7 @@ bool migration_incoming_in_colo_state(void); COLOMode get_colo_mode(void); /* failover */ -void colo_do_failover(MigrationState *s); +void colo_do_failover(void); void colo_checkpoint_notify(void *opaque); #endif diff --git a/migration/colo-failover.c b/migration/colo-failover.c index 4854a96c92..e9ca0b4774 100644 --- a/migration/colo-failover.c +++ b/migration/colo-failover.c @@ -39,7 +39,7 @@ static void colo_failover_bh(void *opaque) return; } - colo_do_failover(NULL); + colo_do_failover(); } void failover_request_active(Error **errp) diff --git a/migration/colo.c b/migration/colo.c index 238a6d62c7..8c1644091f 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -193,7 +193,7 @@ COLOMode get_colo_mode(void) } } -void colo_do_failover(MigrationState *s) +void colo_do_failover(void) { /* Make sure VM stopped while failover happened. */ if (!colo_runstate_is_stopped()) { -- 2.17.GIT