qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Aleksandar Rikalo" <arikalo@wavecomp.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Corey Minyard" <minyard@acm.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH v2 2/6] hw/acpi: Move the ACPI stub to the stubs/ directory
Date: Sun, 28 Apr 2019 08:47:27 +0200	[thread overview]
Message-ID: <20190428064731.29913-3-philmd@redhat.com> (raw)
In-Reply-To: <20190428064731.29913-1-philmd@redhat.com>

Move the ACPI stub file to the stubs/ directory to greatly simplify
the hw/acpi Makefile.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS                         | 1 +
 hw/acpi/Makefile.objs               | 5 -----
 stubs/Makefile.objs                 | 1 +
 hw/acpi/acpi-stub.c => stubs/acpi.c | 0
 4 files changed, 2 insertions(+), 5 deletions(-)
 rename hw/acpi/acpi-stub.c => stubs/acpi.c (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index e1681eca5cb..d05a3d36511 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1357,6 +1357,7 @@ F: hw/acpi/*
 F: hw/smbios/*
 F: hw/i386/acpi-build.[hc]
 F: hw/arm/virt-acpi-build.c
+F: stubs/acpi.c
 F: tests/bios-tables-test.c
 F: tests/acpi-utils.[hc]
 F: tests/data/acpi/
diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs
index 4e302feb885..73eca4f7dff 100644
--- a/hw/acpi/Makefile.objs
+++ b/hw/acpi/Makefile.objs
@@ -6,15 +6,10 @@ common-obj-$(CONFIG_ACPI_MEMORY_HOTPLUG) += memory_hotplug.o
 common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu.o
 common-obj-$(CONFIG_ACPI_NVDIMM) += nvdimm.o
 common-obj-$(CONFIG_ACPI_VMGENID) += vmgenid.o
-common-obj-$(call lnot,$(CONFIG_ACPI_X86)) += acpi-stub.o
 
 common-obj-y += acpi_interface.o
 common-obj-y += bios-linker-loader.o
 common-obj-y += aml-build.o
 common-obj-$(CONFIG_TPM) += tpm.o
-
 common-obj-$(CONFIG_IPMI) += ipmi.o
-else
-common-obj-y += acpi-stub.o
 endif
-common-obj-$(CONFIG_ALL) += acpi-stub.o
diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
index 36bb9ff0b1d..47ee66a71f2 100644
--- a/stubs/Makefile.objs
+++ b/stubs/Makefile.objs
@@ -1,3 +1,4 @@
+stub-obj-y += acpi.o
 stub-obj-y += bdrv-next-monitor-owned.o
 stub-obj-y += blk-commit-all.o
 stub-obj-y += blockdev-close-all-bdrv-states.o
diff --git a/hw/acpi/acpi-stub.c b/stubs/acpi.c
similarity index 100%
rename from hw/acpi/acpi-stub.c
rename to stubs/acpi.c
-- 
2.20.1

WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Corey Minyard" <minyard@acm.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Aleksandar Rikalo" <arikalo@wavecomp.com>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH v2 2/6] hw/acpi: Move the ACPI stub to the stubs/ directory
Date: Sun, 28 Apr 2019 08:47:27 +0200	[thread overview]
Message-ID: <20190428064731.29913-3-philmd@redhat.com> (raw)
Message-ID: <20190428064727.9DDxiQvb_9c_WBmrBmNTBIw4BNUzzXbT2UL8hKtQR5k@z> (raw)
In-Reply-To: <20190428064731.29913-1-philmd@redhat.com>

Move the ACPI stub file to the stubs/ directory to greatly simplify
the hw/acpi Makefile.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS                         | 1 +
 hw/acpi/Makefile.objs               | 5 -----
 stubs/Makefile.objs                 | 1 +
 hw/acpi/acpi-stub.c => stubs/acpi.c | 0
 4 files changed, 2 insertions(+), 5 deletions(-)
 rename hw/acpi/acpi-stub.c => stubs/acpi.c (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index e1681eca5cb..d05a3d36511 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1357,6 +1357,7 @@ F: hw/acpi/*
 F: hw/smbios/*
 F: hw/i386/acpi-build.[hc]
 F: hw/arm/virt-acpi-build.c
+F: stubs/acpi.c
 F: tests/bios-tables-test.c
 F: tests/acpi-utils.[hc]
 F: tests/data/acpi/
diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs
index 4e302feb885..73eca4f7dff 100644
--- a/hw/acpi/Makefile.objs
+++ b/hw/acpi/Makefile.objs
@@ -6,15 +6,10 @@ common-obj-$(CONFIG_ACPI_MEMORY_HOTPLUG) += memory_hotplug.o
 common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu.o
 common-obj-$(CONFIG_ACPI_NVDIMM) += nvdimm.o
 common-obj-$(CONFIG_ACPI_VMGENID) += vmgenid.o
-common-obj-$(call lnot,$(CONFIG_ACPI_X86)) += acpi-stub.o
 
 common-obj-y += acpi_interface.o
 common-obj-y += bios-linker-loader.o
 common-obj-y += aml-build.o
 common-obj-$(CONFIG_TPM) += tpm.o
-
 common-obj-$(CONFIG_IPMI) += ipmi.o
-else
-common-obj-y += acpi-stub.o
 endif
-common-obj-$(CONFIG_ALL) += acpi-stub.o
diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
index 36bb9ff0b1d..47ee66a71f2 100644
--- a/stubs/Makefile.objs
+++ b/stubs/Makefile.objs
@@ -1,3 +1,4 @@
+stub-obj-y += acpi.o
 stub-obj-y += bdrv-next-monitor-owned.o
 stub-obj-y += blk-commit-all.o
 stub-obj-y += blockdev-close-all-bdrv-states.o
diff --git a/hw/acpi/acpi-stub.c b/stubs/acpi.c
similarity index 100%
rename from hw/acpi/acpi-stub.c
rename to stubs/acpi.c
-- 
2.20.1



  parent reply	other threads:[~2019-04-28  6:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-28  6:47 [Qemu-devel] [PATCH v2 0/6] hw/acpi: Improve build modularity (targeting MIPS/PPC) Philippe Mathieu-Daudé
2019-04-28  6:47 ` Philippe Mathieu-Daudé
2019-04-28  6:47 ` [Qemu-devel] [PATCH v2 1/6] hw/acpi: Move the IPMI stub to the stubs/ directory Philippe Mathieu-Daudé
2019-04-28  6:47   ` Philippe Mathieu-Daudé
2019-05-02 13:24   ` Corey Minyard
2019-05-02 13:24     ` Corey Minyard
2019-05-02 16:28     ` Philippe Mathieu-Daudé
2019-05-02 16:28       ` Philippe Mathieu-Daudé
2019-04-28  6:47 ` Philippe Mathieu-Daudé [this message]
2019-04-28  6:47   ` [Qemu-devel] [PATCH v2 2/6] hw/acpi: Move the ACPI " Philippe Mathieu-Daudé
2019-04-28  6:47 ` [Qemu-devel] [PATCH v2 3/6] hw/acpi: Simplify the Makefile logic Philippe Mathieu-Daudé
2019-04-28  6:47   ` Philippe Mathieu-Daudé
2019-04-28  6:47 ` [Qemu-devel] [PATCH v2 4/6] hw/acpi: Always build the 'core' ACPI functions Philippe Mathieu-Daudé
2019-04-28  6:47   ` Philippe Mathieu-Daudé
2019-04-28  6:47 ` [Qemu-devel] [PATCH v2 5/6] stubs: Add missing ACPI symbols Philippe Mathieu-Daudé
2019-04-28  6:47   ` Philippe Mathieu-Daudé
2019-04-28  6:47 ` [Qemu-devel] [PATCH v2 6/6] vl: Do not set acpi_enabled when ACPI is disabled at build time Philippe Mathieu-Daudé
2019-04-28  6:47   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190428064731.29913-3-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=amarkovic@wavecomp.com \
    --cc=arikalo@wavecomp.com \
    --cc=aurelien@aurel32.net \
    --cc=imammedo@redhat.com \
    --cc=minyard@acm.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).