From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org Cc: "Aleksandar Markovic" <amarkovic@wavecomp.com>, "Aleksandar Rikalo" <arikalo@wavecomp.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Aurelien Jarno" <aurelien@aurel32.net>, "Paolo Bonzini" <pbonzini@redhat.com>, "Igor Mammedov" <imammedo@redhat.com>, "Corey Minyard" <minyard@acm.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com> Subject: [Qemu-devel] [PATCH v2 3/6] hw/acpi: Simplify the Makefile logic Date: Sun, 28 Apr 2019 08:47:28 +0200 [thread overview] Message-ID: <20190428064731.29913-4-philmd@redhat.com> (raw) In-Reply-To: <20190428064731.29913-1-philmd@redhat.com> Simplify the Makefile logic to ease further modifications/reviews. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/acpi/Makefile.objs | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs index 73eca4f7dff..b5515c626a6 100644 --- a/hw/acpi/Makefile.objs +++ b/hw/acpi/Makefile.objs @@ -1,4 +1,3 @@ -ifeq ($(CONFIG_ACPI),y) common-obj-$(CONFIG_ACPI_X86) += core.o piix4.o pcihp.o common-obj-$(CONFIG_ACPI_X86_ICH) += ich9.o tco.o common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu_hotplug.o @@ -6,10 +5,8 @@ common-obj-$(CONFIG_ACPI_MEMORY_HOTPLUG) += memory_hotplug.o common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu.o common-obj-$(CONFIG_ACPI_NVDIMM) += nvdimm.o common-obj-$(CONFIG_ACPI_VMGENID) += vmgenid.o - -common-obj-y += acpi_interface.o -common-obj-y += bios-linker-loader.o -common-obj-y += aml-build.o -common-obj-$(CONFIG_TPM) += tpm.o -common-obj-$(CONFIG_IPMI) += ipmi.o -endif +common-obj-$(CONFIG_ACPI) += acpi_interface.o +common-obj-$(CONFIG_ACPI) += bios-linker-loader.o +common-obj-$(CONFIG_ACPI) += aml-build.o +common-obj-$(call land,$(CONFIG_ACPI),$(CONFIG_TPM)) += tpm.o +common-obj-$(call land,$(CONFIG_ACPI),$(CONFIG_IPMI)) += ipmi.o -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org Cc: "Corey Minyard" <minyard@acm.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Aleksandar Rikalo" <arikalo@wavecomp.com>, "Aleksandar Markovic" <amarkovic@wavecomp.com>, "Igor Mammedov" <imammedo@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Aurelien Jarno" <aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH v2 3/6] hw/acpi: Simplify the Makefile logic Date: Sun, 28 Apr 2019 08:47:28 +0200 [thread overview] Message-ID: <20190428064731.29913-4-philmd@redhat.com> (raw) Message-ID: <20190428064728.mUovHuoY1U8liethY-NdhsDaU9qzcNjRVJdLh8yTKJY@z> (raw) In-Reply-To: <20190428064731.29913-1-philmd@redhat.com> Simplify the Makefile logic to ease further modifications/reviews. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/acpi/Makefile.objs | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs index 73eca4f7dff..b5515c626a6 100644 --- a/hw/acpi/Makefile.objs +++ b/hw/acpi/Makefile.objs @@ -1,4 +1,3 @@ -ifeq ($(CONFIG_ACPI),y) common-obj-$(CONFIG_ACPI_X86) += core.o piix4.o pcihp.o common-obj-$(CONFIG_ACPI_X86_ICH) += ich9.o tco.o common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu_hotplug.o @@ -6,10 +5,8 @@ common-obj-$(CONFIG_ACPI_MEMORY_HOTPLUG) += memory_hotplug.o common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu.o common-obj-$(CONFIG_ACPI_NVDIMM) += nvdimm.o common-obj-$(CONFIG_ACPI_VMGENID) += vmgenid.o - -common-obj-y += acpi_interface.o -common-obj-y += bios-linker-loader.o -common-obj-y += aml-build.o -common-obj-$(CONFIG_TPM) += tpm.o -common-obj-$(CONFIG_IPMI) += ipmi.o -endif +common-obj-$(CONFIG_ACPI) += acpi_interface.o +common-obj-$(CONFIG_ACPI) += bios-linker-loader.o +common-obj-$(CONFIG_ACPI) += aml-build.o +common-obj-$(call land,$(CONFIG_ACPI),$(CONFIG_TPM)) += tpm.o +common-obj-$(call land,$(CONFIG_ACPI),$(CONFIG_IPMI)) += ipmi.o -- 2.20.1
next prev parent reply other threads:[~2019-04-28 6:48 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-28 6:47 [Qemu-devel] [PATCH v2 0/6] hw/acpi: Improve build modularity (targeting MIPS/PPC) Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 1/6] hw/acpi: Move the IPMI stub to the stubs/ directory Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-05-02 13:24 ` Corey Minyard 2019-05-02 13:24 ` Corey Minyard 2019-05-02 16:28 ` Philippe Mathieu-Daudé 2019-05-02 16:28 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 2/6] hw/acpi: Move the ACPI " Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé [this message] 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 3/6] hw/acpi: Simplify the Makefile logic Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 4/6] hw/acpi: Always build the 'core' ACPI functions Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 5/6] stubs: Add missing ACPI symbols Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 6/6] vl: Do not set acpi_enabled when ACPI is disabled at build time Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190428064731.29913-4-philmd@redhat.com \ --to=philmd@redhat.com \ --cc=amarkovic@wavecomp.com \ --cc=arikalo@wavecomp.com \ --cc=aurelien@aurel32.net \ --cc=imammedo@redhat.com \ --cc=minyard@acm.org \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).