From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:33466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL6Vz-0005Rs-HW for qemu-devel@nongnu.org; Mon, 29 Apr 2019 09:40:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL6Vy-00019E-MO for qemu-devel@nongnu.org; Mon, 29 Apr 2019 09:40:15 -0400 Date: Mon, 29 Apr 2019 15:40:03 +0200 From: Cornelia Huck Message-ID: <20190429154003.7f8fc423.cohuck@redhat.com> In-Reply-To: <1556543381-12671-1-git-send-email-jjherne@linux.ibm.com> References: <1556543381-12671-1-git-send-email-jjherne@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] s390-bios: Skip bootmap signature entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Jason J. Herne" Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, thuth@redhat.com, alifm@linux.ibm.com, borntraeger@de.ibm.com On Mon, 29 Apr 2019 09:09:41 -0400 "Jason J. Herne" wrote: > Newer versions of zipl have the ability to write signature entries to the boot > script for secure boot. We don't yet support secure boot, but we need to skip > over signature entries while reading the boot script in order to maintain our > ability to boot guest operating systems that have a secure bootloader. > > Signed-off-by: Jason J. Herne > Reviewed-by: Farhan Ali > --- > pc-bios/s390-ccw/bootmap.c | 19 +++++++++++++++++-- > pc-bios/s390-ccw/bootmap.h | 10 ++++++---- > 2 files changed, 23 insertions(+), 6 deletions(-) Skipping something that we don't have support for yet, but that doesn't hinder normal operation sounds reasonable; but can you point me to the relevant commit implementing this in zipl or some documentation? I haven't been able to find something like that in the s390-tools git tree. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1570EC43219 for ; Mon, 29 Apr 2019 13:41:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBB2520652 for ; Mon, 29 Apr 2019 13:41:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBB2520652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:57767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL6Wr-0005nw-TJ for qemu-devel@archiver.kernel.org; Mon, 29 Apr 2019 09:41:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL6Vz-0005Rs-HW for qemu-devel@nongnu.org; Mon, 29 Apr 2019 09:40:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL6Vy-00019E-MO for qemu-devel@nongnu.org; Mon, 29 Apr 2019 09:40:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51518) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hL6Vy-00018f-Fp; Mon, 29 Apr 2019 09:40:14 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E13563082E58; Mon, 29 Apr 2019 13:40:08 +0000 (UTC) Received: from gondolin (dhcp-192-187.str.redhat.com [10.33.192.187]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0A5A6CE5E; Mon, 29 Apr 2019 13:40:05 +0000 (UTC) Date: Mon, 29 Apr 2019 15:40:03 +0200 From: Cornelia Huck To: "Jason J. Herne" Message-ID: <20190429154003.7f8fc423.cohuck@redhat.com> In-Reply-To: <1556543381-12671-1-git-send-email-jjherne@linux.ibm.com> References: <1556543381-12671-1-git-send-email-jjherne@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 29 Apr 2019 13:40:09 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] s390-bios: Skip bootmap signature entries X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, alifm@linux.ibm.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190429134003.bx_A53cZG1dTpebMQP_yWWpTYxNU8C0MXcIuniLY4bc@z> On Mon, 29 Apr 2019 09:09:41 -0400 "Jason J. Herne" wrote: > Newer versions of zipl have the ability to write signature entries to the boot > script for secure boot. We don't yet support secure boot, but we need to skip > over signature entries while reading the boot script in order to maintain our > ability to boot guest operating systems that have a secure bootloader. > > Signed-off-by: Jason J. Herne > Reviewed-by: Farhan Ali > --- > pc-bios/s390-ccw/bootmap.c | 19 +++++++++++++++++-- > pc-bios/s390-ccw/bootmap.h | 10 ++++++---- > 2 files changed, 23 insertions(+), 6 deletions(-) Skipping something that we don't have support for yet, but that doesn't hinder normal operation sounds reasonable; but can you point me to the relevant commit implementing this in zipl or some documentation? I haven't been able to find something like that in the s390-tools git tree.