From: Jon Doron <arilou@gmail.com>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, Jon Doron <arilou@gmail.com>
Subject: [Qemu-devel] [PATCH v9 26/27] gdbstub: Add support to read a MSR for KVM target
Date: Thu, 2 May 2019 11:15:53 +0300 [thread overview]
Message-ID: <20190502081554.5521-27-arilou@gmail.com> (raw)
In-Reply-To: <20190502081554.5521-1-arilou@gmail.com>
gdb> maint packet qqemu.kvm.Rdmsr:MsrIndex
Signed-off-by: Jon Doron <arilou@gmail.com>
---
gdbstub.c | 38 +++++++++++++++++++++++++++++++++++++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/gdbstub.c b/gdbstub.c
index 34da10260d..f48c3a2b5f 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2141,7 +2141,14 @@ static void handle_query_attached(GdbCmdContext *gdb_ctx, void *user_ctx)
static void handle_query_qemu_supported(GdbCmdContext *gdb_ctx, void *user_ctx)
{
- put_packet(gdb_ctx->s, "sstepbits;sstep;PhyMemMode");
+ snprintf(gdb_ctx->str_buf, sizeof(gdb_ctx->str_buf),
+ "sstepbits;sstep;PhyMemMode");
+
+ if (kvm_enabled()) {
+ pstrcat(gdb_ctx->str_buf, sizeof(gdb_ctx->str_buf), ";kvm.Rdmsr");
+ }
+
+ put_packet(gdb_ctx->s, gdb_ctx->str_buf);
}
static void handle_query_qemu_phy_mem_mode(GdbCmdContext *gdb_ctx,
@@ -2166,6 +2173,29 @@ static void handle_set_qemu_phy_mem_mode(GdbCmdContext *gdb_ctx, void *user_ctx)
put_packet(gdb_ctx->s, "OK");
}
+static void handle_query_kvm_read_msr(GdbCmdContext *gdb_ctx, void *user_ctx)
+{
+ uint64_t msr_val;
+
+ if (!kvm_enabled()) {
+ return;
+ }
+
+ if (!gdb_ctx->num_params) {
+ put_packet(gdb_ctx->s, "E22");
+ return;
+ }
+
+ if (kvm_arch_read_msr(gdbserver_state->c_cpu, gdb_ctx->params[0].val_ul,
+ &msr_val)) {
+ put_packet(gdb_ctx->s, "E00");
+ return;
+ }
+
+ snprintf(gdb_ctx->str_buf, sizeof(gdb_ctx->str_buf), "0x%" PRIx64, msr_val);
+ put_packet(gdb_ctx->s, gdb_ctx->str_buf);
+}
+
static GdbCmdParseEntry gdb_gen_query_set_common_table[] = {
/* Order is important if has same prefix */
{
@@ -2250,6 +2280,12 @@ static GdbCmdParseEntry gdb_gen_query_table[] = {
.handler = handle_query_qemu_phy_mem_mode,
.cmd = "qemu.PhyMemMode",
},
+ {
+ .handler = handle_query_kvm_read_msr,
+ .cmd = "qemu.kvm.Rdmsr:",
+ .cmd_startswith = 1,
+ .schema = "l0"
+ },
};
static GdbCmdParseEntry gdb_gen_set_table[] = {
--
2.20.1
next prev parent reply other threads:[~2019-05-02 8:16 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 8:15 [Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 01/27] gdbstub: Add infrastructure to parse cmd packets Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-14 18:24 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 02/27] gdbstub: Implement deatch (D pkt) with new infra Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-14 18:54 ` Alex Bennée
2019-05-21 4:47 ` Jon Doron
2019-05-21 6:43 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 03/27] gdbstub: Implement thread_alive (T " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 8:27 ` Alex Bennée
2019-05-15 8:33 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 04/27] gdbstub: Implement continue (c " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 8:34 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 05/27] gdbstub: Implement continue with signal (C " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 9:43 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 06/27] gdbstub: Implement set_thread (H " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 10:06 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 07/27] gdbstub: Implement insert breakpoint (Z " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 10:26 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 08/27] gdbstub: Implement remove breakpoint (z " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 10:27 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 09/27] gdbstub: Implement set register (P " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 12:14 ` Alex Bennée
2019-05-19 10:32 ` Jon Doron
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 10/27] gdbstub: Implement get register (p " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 11/27] gdbstub: Implement write memory (M " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 15:22 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 12/27] gdbstub: Implement read memory (m " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 15:30 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 13/27] gdbstub: Implement write all registers (G " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 16:01 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 14/27] gdbstub: Implement read all registers (g " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 16:10 ` Alex Bennée
2019-05-19 10:42 ` Jon Doron
2019-05-19 14:55 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 15/27] gdbstub: Implement file io (F " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 16:54 ` Alex Bennée
2019-05-19 11:35 ` Jon Doron
2019-05-19 14:54 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 16/27] gdbstub: Implement step (s " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 16:55 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 17/27] gdbstub: Implement v commands " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 17:06 ` Alex Bennée
2019-05-20 4:38 ` Jon Doron
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 18/27] gdbstub: Implement generic query (q pkt) " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 17:12 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 19/27] gdbstub: Implement generic set (Q " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 20/27] gdbstub: Implement target halted (? " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 17:20 ` Alex Bennée
2019-05-20 5:32 ` Jon Doron
2019-05-20 12:54 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 21/27] gdbstub: Clear unused variables in gdb_handle_packet Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 17:24 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 22/27] gdbstub: Implement generic query qemu.Supported Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 17:41 ` Alex Bennée
2019-05-20 4:50 ` Jon Doron
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 23/27] gdbstub: Implement qemu physical memory mode Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 15:13 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 24/27] gdbstub: Add another handler for setting qemu.sstep Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 17:44 ` Alex Bennée
2019-05-20 5:17 ` Jon Doron
2019-05-20 12:40 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 25/27] kvm: Add API to read/write a CPU MSR value Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-02 8:15 ` Jon Doron [this message]
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 26/27] gdbstub: Add support to read a MSR for KVM target Jon Doron
2019-05-15 17:48 ` Alex Bennée
2019-05-20 5:24 ` Jon Doron
2019-05-20 12:42 ` Alex Bennée
2019-05-02 8:15 ` [Qemu-devel] [PATCH v9 27/27] gdbstub: Add support to write " Jon Doron
2019-05-02 8:15 ` Jon Doron
2019-05-15 13:19 ` [Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler Alex Bennée
2019-05-15 18:00 ` Alex Bennée
2019-05-16 12:44 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502081554.5521-27-arilou@gmail.com \
--to=arilou@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).