From: Thomas Huth <thuth@redhat.com> To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org Cc: Eduardo Habkost <ehabkost@redhat.com>, Helge Deller <deller@gmx.de>, Eduardo Otubo <otubo@redhat.com> Subject: [Qemu-devel] [PULL 4/8] accel: Remove unused AccelClass::available field Date: Thu, 2 May 2019 18:13:06 +0200 [thread overview] Message-ID: <20190502161310.15624-5-thuth@redhat.com> (raw) In-Reply-To: <20190502161310.15624-1-thuth@redhat.com> From: Eduardo Habkost <ehabkost@redhat.com> The field is not used anymore, we can remove it. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20190422210448.2488-4-ehabkost@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> [on mingw64] Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com> --- accel/accel.c | 5 ----- include/sysemu/accel.h | 1 - 2 files changed, 6 deletions(-) diff --git a/accel/accel.c b/accel/accel.c index 454fef9d92..5fa31717b4 100644 --- a/accel/accel.c +++ b/accel/accel.c @@ -107,11 +107,6 @@ void configure_accelerator(MachineState *ms, const char *progname) if (!acc) { continue; } - if (acc->available && !acc->available()) { - printf("%s not supported for this target\n", - acc->name); - continue; - } ret = accel_init_machine(acc, ms); if (ret < 0) { init_failed = true; diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h index 5565e00a96..70e9e2f2a1 100644 --- a/include/sysemu/accel.h +++ b/include/sysemu/accel.h @@ -38,7 +38,6 @@ typedef struct AccelClass { const char *opt_name; const char *name; - int (*available)(void); int (*init_machine)(MachineState *ms); void (*setup_post)(MachineState *ms, AccelState *accel); bool *allowed; -- 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com> To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org Cc: Eduardo Otubo <otubo@redhat.com>, Helge Deller <deller@gmx.de>, Eduardo Habkost <ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 4/8] accel: Remove unused AccelClass::available field Date: Thu, 2 May 2019 18:13:06 +0200 [thread overview] Message-ID: <20190502161310.15624-5-thuth@redhat.com> (raw) Message-ID: <20190502161306.UPqjnCts-xKgjGlBEdtlueuqA9TGYC6CwuST59g3AVE@z> (raw) In-Reply-To: <20190502161310.15624-1-thuth@redhat.com> From: Eduardo Habkost <ehabkost@redhat.com> The field is not used anymore, we can remove it. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20190422210448.2488-4-ehabkost@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> [on mingw64] Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com> --- accel/accel.c | 5 ----- include/sysemu/accel.h | 1 - 2 files changed, 6 deletions(-) diff --git a/accel/accel.c b/accel/accel.c index 454fef9d92..5fa31717b4 100644 --- a/accel/accel.c +++ b/accel/accel.c @@ -107,11 +107,6 @@ void configure_accelerator(MachineState *ms, const char *progname) if (!acc) { continue; } - if (acc->available && !acc->available()) { - printf("%s not supported for this target\n", - acc->name); - continue; - } ret = accel_init_machine(acc, ms); if (ret < 0) { init_failed = true; diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h index 5565e00a96..70e9e2f2a1 100644 --- a/include/sysemu/accel.h +++ b/include/sysemu/accel.h @@ -38,7 +38,6 @@ typedef struct AccelClass { const char *opt_name; const char *name; - int (*available)(void); int (*init_machine)(MachineState *ms); void (*setup_post)(MachineState *ms, AccelState *accel); bool *allowed; -- 2.21.0
next prev parent reply other threads:[~2019-05-02 16:13 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-02 16:13 [Qemu-devel] [PULL 0/8] qtest and misc patches Thomas Huth 2019-05-02 16:13 ` Thomas Huth 2019-05-02 16:13 ` [Qemu-devel] [PULL 1/8] gitlab-ci.yml: Test the TCG interpreter in a CI pipeline Thomas Huth 2019-05-02 16:13 ` Thomas Huth 2019-05-02 16:13 ` [Qemu-devel] [PULL 2/8] qtest: Move accel code to accel/qtest.c Thomas Huth 2019-05-02 16:13 ` Thomas Huth 2019-05-02 16:13 ` [Qemu-devel] [PULL 3/8] qtest: Don't compile qtest accel on non-POSIX systems Thomas Huth 2019-05-02 16:13 ` Thomas Huth 2019-05-02 16:13 ` Thomas Huth [this message] 2019-05-02 16:13 ` [Qemu-devel] [PULL 4/8] accel: Remove unused AccelClass::available field Thomas Huth 2019-05-02 16:13 ` [Qemu-devel] [PULL 5/8] configure: Add -Wno-typedef-redefinition to CFLAGS (for Clang) Thomas Huth 2019-05-02 16:13 ` Thomas Huth 2019-05-02 16:13 ` [Qemu-devel] [PULL 6/8] configure: Remove old *-config-devices.mak.d files when running configure Thomas Huth 2019-05-02 16:13 ` Thomas Huth 2019-05-02 16:13 ` [Qemu-devel] [PULL 7/8] configure: Relax check for libseccomp Thomas Huth 2019-05-02 16:13 ` Thomas Huth 2019-05-02 16:13 ` [Qemu-devel] [PULL 8/8] hw/pci-host: Use object_initialize_child for correct reference counting Thomas Huth 2019-05-02 16:13 ` Thomas Huth 2019-05-03 9:37 ` [Qemu-devel] [PULL 0/8] qtest and misc patches Peter Maydell 2019-05-03 9:37 ` Peter Maydell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190502161310.15624-5-thuth@redhat.com \ --to=thuth@redhat.com \ --cc=deller@gmx.de \ --cc=ehabkost@redhat.com \ --cc=otubo@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).