From: Cao Jiaxi <driver1998@foxmail.com>
To: mdroth@linux.vnet.ibm.com
Cc: qemu-devel@nongnu.org, Cao Jiaxi <driver1998@foxmail.com>
Subject: [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion
Date: Fri, 3 May 2019 08:25:56 +0800 [thread overview]
Message-ID: <20190503002556.9941-1-driver1998@foxmail.com> (raw)
In-Reply-To: <20190503002258.9799-1-driver1998@foxmail.com>
The win2qemu[] is supposed to be the conversion table to convert between
STORAGE_BUS_TYPE in Windows SDK and GuestDiskBusType in qga.
But it was incorrectly written that it forces to set a GuestDiskBusType
value to STORAGE_BUS_TYPE, which generates an enum conversion warning in clang.
Signed-off-by: Cao Jiaxi <driver1998@foxmail.com>
---
qga/commands-win32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index d40d61f605..6b67f16faf 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -457,7 +457,7 @@ void qmp_guest_file_flush(int64_t handle, Error **errp)
#ifdef CONFIG_QGA_NTDDSCSI
-static STORAGE_BUS_TYPE win2qemu[] = {
+static GuestDiskBusType win2qemu[] = {
[BusTypeUnknown] = GUEST_DISK_BUS_TYPE_UNKNOWN,
[BusTypeScsi] = GUEST_DISK_BUS_TYPE_SCSI,
[BusTypeAtapi] = GUEST_DISK_BUS_TYPE_IDE,
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Cao Jiaxi <driver1998@foxmail.com>
To: mdroth@linux.vnet.ibm.com
Cc: Cao Jiaxi <driver1998@foxmail.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion
Date: Fri, 3 May 2019 08:25:56 +0800 [thread overview]
Message-ID: <20190503002556.9941-1-driver1998@foxmail.com> (raw)
Message-ID: <20190503002556.Nyjw5Kiuef7pBwkTYVuoyDio1RwkyK7KWY5YV6p4LQw@z> (raw)
In-Reply-To: <20190503002258.9799-1-driver1998@foxmail.com>
The win2qemu[] is supposed to be the conversion table to convert between
STORAGE_BUS_TYPE in Windows SDK and GuestDiskBusType in qga.
But it was incorrectly written that it forces to set a GuestDiskBusType
value to STORAGE_BUS_TYPE, which generates an enum conversion warning in clang.
Signed-off-by: Cao Jiaxi <driver1998@foxmail.com>
---
qga/commands-win32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index d40d61f605..6b67f16faf 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -457,7 +457,7 @@ void qmp_guest_file_flush(int64_t handle, Error **errp)
#ifdef CONFIG_QGA_NTDDSCSI
-static STORAGE_BUS_TYPE win2qemu[] = {
+static GuestDiskBusType win2qemu[] = {
[BusTypeUnknown] = GUEST_DISK_BUS_TYPE_UNKNOWN,
[BusTypeScsi] = GUEST_DISK_BUS_TYPE_SCSI,
[BusTypeAtapi] = GUEST_DISK_BUS_TYPE_IDE,
--
2.17.1
next prev parent reply other threads:[~2019-05-03 0:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190503002258.9799-1-driver1998@foxmail.com>
2019-05-03 0:23 ` [Qemu-devel] [PATCH v3 1/4] QEMU_PACKED: Remove gcc_struct attribute in Windows non x86 targets Cao Jiaxi
2019-05-03 0:23 ` Cao Jiaxi
2019-05-03 0:25 ` Cao Jiaxi [this message]
2019-05-03 0:25 ` [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion Cao Jiaxi
2019-05-03 9:03 ` Philippe Mathieu-Daudé
2019-05-03 9:03 ` Philippe Mathieu-Daudé
2019-05-03 0:29 ` [Qemu-devel] [PATCH v3 3/4] util/cacheinfo: Use uint64_t on LLP64 model to satisfy Windows ARM64 Cao Jiaxi
2019-05-03 0:29 ` Cao Jiaxi
2019-05-03 9:06 ` Philippe Mathieu-Daudé
2019-05-03 9:06 ` Philippe Mathieu-Daudé
2019-05-03 0:31 ` [Qemu-devel] [PATCH v3 4/4] osdep: Fix mingw compilation regarding stdio formats Cao Jiaxi
2019-05-03 0:31 ` Cao Jiaxi
2019-05-03 10:13 ` Philippe Mathieu-Daudé
2019-05-03 10:13 ` Philippe Mathieu-Daudé
2019-05-03 0:22 [Qemu-devel] [PATCH v3 0/4] Initial Windows on ARM (AArch64 64-Bit) host support Cao Jiaxi
2019-05-03 0:36 ` [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion Cao Jiaxi
2019-05-03 0:36 ` Cao Jiaxi
2019-05-03 3:32 ` Richard Henderson
2019-05-03 3:32 ` Richard Henderson
2019-05-03 5:09 ` Thomas Huth
2019-05-03 5:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503002556.9941-1-driver1998@foxmail.com \
--to=driver1998@foxmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).