From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMCd-0008SZ-T4 for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMMCc-00030R-Vr for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:27 -0400 Received: from smtpproxy19.qq.com ([184.105.206.84]:50156) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMMCc-0002zn-Ol for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:26 -0400 From: Cao Jiaxi Date: Fri, 3 May 2019 08:37:19 +0800 Message-Id: <20190503003719.10233-1-driver1998@foxmail.com> In-Reply-To: <20190503002206.9751-1-driver1998@foxmail.com> References: <20190503002206.9751-1-driver1998@foxmail.com> Subject: [Qemu-devel] [PATCH v3 4/4] osdep: Fix mingw compilation regarding stdio formats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Cao Jiaxi I encountered the following compilation error on mingw: /mnt/d/qemu/include/qemu/osdep.h:97:9: error: '__USE_MINGW_ANSI_STDIO' macro redefined [-Werror,-Wmacro-redefined] #define __USE_MINGW_ANSI_STDIO 1 ^ /mnt/d/llvm-mingw/aarch64-w64-mingw32/include/_mingw.h:433:9: note: previous definition is here #define __USE_MINGW_ANSI_STDIO 0 /* was not defined so it should be 0 */ It turns out that __USE_MINGW_ANSI_STDIO must be set before any system headers are included, not just before stdio.h. Signed-off-by: Cao Jiaxi --- include/qemu/osdep.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 303d315c5d..af2b91f0b8 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -85,17 +85,17 @@ extern int daemon(int, int); #endif #endif +/* enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later) */ +#ifdef __MINGW32__ +#define __USE_MINGW_ANSI_STDIO 1 +#endif + #include #include #include #include #include #include - -/* enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later) */ -#ifdef __MINGW32__ -#define __USE_MINGW_ANSI_STDIO 1 -#endif #include #include -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C207BC43219 for ; Fri, 3 May 2019 00:39:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88C0E2070B for ; Fri, 3 May 2019 00:39:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=foxmail.com header.i=@foxmail.com header.b="nwvxZV1s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88C0E2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foxmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:60385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMME8-0000wd-Pc for qemu-devel@archiver.kernel.org; Thu, 02 May 2019 20:39:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMCd-0008SZ-T4 for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMMCc-00030R-Vr for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:27 -0400 Received: from smtpproxy19.qq.com ([184.105.206.84]:50156) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMMCc-0002zn-Ol for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1556843841; bh=fqx7px8aicw59s5wsPfWml96z0lJHa6tUbYs8uCbaaw=; h=From:To:Subject:Date:Message-Id; b=nwvxZV1sTGrrCUe0ikJ8Y9GfKTjFJhGZmzYLvTkNCgWihCid+LPT5kaDvtXR+FntW 4XAOM9n9g1i/dXI7aXgchzUJswvPzobmqh1jcKMJDiPGP/J4+bYLlB2vohnI8SAUYJ z+OIS6s8ZziOTBDHIWaF2A6N5KJ8KAwH7xyIdLK4= X-QQ-mid: esmtp2t1556843840tnjge6umc Received: from localhost (unknown [183.63.119.3]) by esmtp4.qq.com (ESMTP) with id ; Fri, 03 May 2019 08:37:19 +0800 (CST) X-QQ-SSF: B100000000000030F7F00F00000000O X-QQ-FEAT: 0wsbT93u7eCMTn3b6RLI6G4Cws3/XlKIMI7VNta4wKG3NDZzzT0jiRgIu8x/k DAKSH8/mNV3lZptaGiI0/ua44BHTN+L5tjBKFJyjyqhw+BtHEmAHDDd7LldWSZyhCzBVc9H esAX0AnV/gKL/yfm+dXVGGJ2MgSLX1UnsjFNt/SkqOc/NEh9XQ4epcanuQf/GjQTFjdnjl0 Ey4akzTs7WHqpepl9rJc483oKw5I/xE8vFFSukbP2BsUCbMWzF/Wbe11UhMokfS2RBdODxH IwFbfAtsaKyD+9zFJyvRLRpvGTXYJI+ZYkDx0gNzbTj7Qs X-QQ-GoodBg: 0 From: Cao Jiaxi To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 08:37:19 +0800 Message-Id: <20190503003719.10233-1-driver1998@foxmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190503002206.9751-1-driver1998@foxmail.com> References: <20190503002206.9751-1-driver1998@foxmail.com> X-QQ-SENDSIZE: 520 Feedback-ID: esmtp:foxmail.com:bgforeign:bgforeign4 X-QQ-Bgrelay: 1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 184.105.206.84 Subject: [Qemu-devel] [PATCH v3 4/4] osdep: Fix mingw compilation regarding stdio formats X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cao Jiaxi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190503003719.SDde5CuUZZOqBiO04f6UMTFMPJQfnYxWyRBjNeejb7I@z> I encountered the following compilation error on mingw: /mnt/d/qemu/include/qemu/osdep.h:97:9: error: '__USE_MINGW_ANSI_STDIO' macro redefined [-Werror,-Wmacro-redefined] #define __USE_MINGW_ANSI_STDIO 1 ^ /mnt/d/llvm-mingw/aarch64-w64-mingw32/include/_mingw.h:433:9: note: previous definition is here #define __USE_MINGW_ANSI_STDIO 0 /* was not defined so it should be 0 */ It turns out that __USE_MINGW_ANSI_STDIO must be set before any system headers are included, not just before stdio.h. Signed-off-by: Cao Jiaxi --- include/qemu/osdep.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 303d315c5d..af2b91f0b8 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -85,17 +85,17 @@ extern int daemon(int, int); #endif #endif +/* enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later) */ +#ifdef __MINGW32__ +#define __USE_MINGW_ANSI_STDIO 1 +#endif + #include #include #include #include #include #include - -/* enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later) */ -#ifdef __MINGW32__ -#define __USE_MINGW_ANSI_STDIO 1 -#endif #include #include -- 2.17.1