qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, Cleber Rosa <crosa@redhat.com>
Subject: [Qemu-devel] [PULL 02/19] tests/acceptance: improve docstring on pick_default_qemu_bin()
Date: Thu,  2 May 2019 21:41:13 -0300	[thread overview]
Message-ID: <20190503004130.8285-3-ehabkost@redhat.com> (raw)
In-Reply-To: <20190503004130.8285-1-ehabkost@redhat.com>

From: Cleber Rosa <crosa@redhat.com>

Making it clear what is returned by this utility function.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Caio Carrara <ccarrara@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20190312171824.5134-3-crosa@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 tests/acceptance/avocado_qemu/__init__.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index a66ec72daa..b7c5d598d8 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -27,6 +27,10 @@ def pick_default_qemu_bin():
     """
     Picks the path of a QEMU binary, starting either in the current working
     directory or in the source tree root directory.
+
+    :returns: the path to the default QEMU binary or None if one could not
+              be found
+    :rtype: str or None
     """
     arch = os.uname()[4]
     qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
-- 
2.18.0.rc1.1.g3f1ff2140

  parent reply	other threads:[~2019-05-03  0:41 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03  0:41 [Qemu-devel] [PULL 00/19] Python queue, 2019-05-02 Eduardo Habkost
2019-05-03  0:41 ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 01/19] tests/acceptance: show avocado test execution by default Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` Eduardo Habkost [this message]
2019-05-03  0:41   ` [Qemu-devel] [PULL 02/19] tests/acceptance: improve docstring on pick_default_qemu_bin() Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 03/19] tests/acceptance: fix doc reference to avocado_qemu directory Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 04/19] tests/acceptance: introduce arch parameter and attribute Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 05/19] tests/acceptance: use "arch:" tag to filter target specific tests Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 06/19] tests/acceptance: look for target architecture in test tags first Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 07/19] tests/boot_linux_console: rename the x86_64 after the arch and machine Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 08/19] tests/boot_linux_console: update the x86_64 kernel Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 09/19] tests/boot_linux_console: add common kernel command line options Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 10/19] tests/boot_linux_console: increase timeout Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-08 10:28   ` Gerd Hoffmann
2019-05-08 14:39     ` Cleber Rosa
2019-05-09  4:40       ` Gerd Hoffmann
2019-05-09 18:12         ` Cleber Rosa
2019-05-10  6:06           ` Gerd Hoffmann
2019-05-03  0:41 ` [Qemu-devel] [PULL 11/19] tests/boot_linux_console: refactor the console watcher into utility method Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 12/19] scripts/qemu.py: support adding a console with the default serial device Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 13/19] tests/boot_linux_console: add a test for mips + malta Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 14/19] tests/boot_linux_console: add a test for mips64el " Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 15/19] tests/boot_linux_console: add a test for aarch64 + virt Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 16/19] tests/boot_linux_console: add a test for arm " Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 17/19] tests/boot_linux_console: add a test for s390x + s390-ccw-virtio Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 18/19] tests/boot_linux_console: add a test for alpha + clipper Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03  0:41 ` [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available Eduardo Habkost
2019-05-03  0:41   ` Eduardo Habkost
2019-05-03 16:41   ` Thomas Huth
2019-05-03 16:41     ` Thomas Huth
2019-05-03 16:54     ` Daniel P. Berrangé
2019-05-03 16:54       ` Daniel P. Berrangé
2019-05-03 16:56       ` Daniel P. Berrangé
2019-05-03 16:56         ` Daniel P. Berrangé
2019-05-03 17:04     ` Philippe Mathieu-Daudé
2019-05-03 17:04       ` Philippe Mathieu-Daudé
2019-05-04  6:41       ` Thomas Huth
2019-05-04  6:41         ` Thomas Huth
2019-05-03 21:00     ` Eduardo Habkost
2019-05-03 21:00       ` Eduardo Habkost
2019-05-03 21:34       ` Eduardo Habkost
2019-05-03 21:34         ` Eduardo Habkost
2019-05-04  7:17         ` Thomas Huth
2019-05-04  7:17           ` Thomas Huth
2019-05-03 15:02 ` [Qemu-devel] [PULL 00/19] Python queue, 2019-05-02 Peter Maydell
2019-05-03 15:02   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503004130.8285-3-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=crosa@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).