From: Laurent Vivier <laurent@vivier.eu> To: qemu-devel@nongnu.org Cc: "Laurent Vivier" <laurent@vivier.eu>, "Paolo Bonzini" <pbonzini@redhat.com>, "Fabien Chouteau" <chouteau@adacore.com>, qemu-trivial@nongnu.org, "Richard Henderson" <rth@twiddle.net>, "Jason Wang" <jasowang@redhat.com>, "Andreas Färber" <afaerber@suse.de>, "Michael Tokarev" <mjt@tls.msk.ru>, "Daniel P. Berrangé" <berrange@redhat.com>, "Gerd Hoffmann" <kraxel@redhat.com>, "Artyom Tarasenko" <atar4qemu@gmail.com>, "Michael Roth" <mdroth@linux.vnet.ibm.com>, "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com> Subject: [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning Date: Fri, 3 May 2019 13:18:26 +0200 [thread overview] Message-ID: <20190503111832.30316-7-laurent@vivier.eu> (raw) In-Reply-To: <20190503111832.30316-1-laurent@vivier.eu> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the pam_conversation pointer to pam_start must be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz. Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Acked-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20190404091725.20595-1-dgilbert@redhat.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 60719ddcc5b0..a2607afb3408 100755 --- a/configure +++ b/configure @@ -2940,9 +2940,9 @@ if test "$auth_pam" != "no"; then int main(void) { const char *service_name = "qemu"; const char *user = "frank"; - const struct pam_conv *pam_conv = NULL; + const struct pam_conv pam_conv = { 0 }; pam_handle_t *pamh = NULL; - pam_start(service_name, user, pam_conv, &pamh); + pam_start(service_name, user, &pam_conv, &pamh); return 0; } EOF -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <laurent@vivier.eu> To: qemu-devel@nongnu.org Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu-trivial@nongnu.org, "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>, "Jason Wang" <jasowang@redhat.com>, "Michael Tokarev" <mjt@tls.msk.ru>, "Laurent Vivier" <laurent@vivier.eu>, "Fabien Chouteau" <chouteau@adacore.com>, "Michael Roth" <mdroth@linux.vnet.ibm.com>, "Gerd Hoffmann" <kraxel@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Andreas Färber" <afaerber@suse.de>, "Artyom Tarasenko" <atar4qemu@gmail.com>, "Richard Henderson" <rth@twiddle.net> Subject: [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning Date: Fri, 3 May 2019 13:18:26 +0200 [thread overview] Message-ID: <20190503111832.30316-7-laurent@vivier.eu> (raw) Message-ID: <20190503111826.srVCIYrQ8CHIGZL_aKUNaiO4GSeyiROMgBTc0an5Tzk@z> (raw) In-Reply-To: <20190503111832.30316-1-laurent@vivier.eu> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the pam_conversation pointer to pam_start must be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz. Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Acked-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20190404091725.20595-1-dgilbert@redhat.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 60719ddcc5b0..a2607afb3408 100755 --- a/configure +++ b/configure @@ -2940,9 +2940,9 @@ if test "$auth_pam" != "no"; then int main(void) { const char *service_name = "qemu"; const char *user = "frank"; - const struct pam_conv *pam_conv = NULL; + const struct pam_conv pam_conv = { 0 }; pam_handle_t *pamh = NULL; - pam_start(service_name, user, pam_conv, &pamh); + pam_start(service_name, user, &pam_conv, &pamh); return 0; } EOF -- 2.20.1
next prev parent reply other threads:[~2019-05-03 11:19 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-03 11:18 [Qemu-devel] [PULL v2 00/12] Trivial branch patches Laurent Vivier 2019-05-03 11:18 ` Laurent Vivier 2019-05-03 11:18 ` [Qemu-devel] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf Laurent Vivier 2019-05-03 11:18 ` Laurent Vivier 2019-05-03 11:18 ` [Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code Laurent Vivier 2019-05-03 11:18 ` Laurent Vivier 2019-05-03 11:18 ` [Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others Laurent Vivier 2019-05-03 11:18 ` Laurent Vivier 2019-05-03 11:18 ` [Qemu-devel] [PULL v2 04/12] doc: fix the configuration path Laurent Vivier 2019-05-03 11:18 ` Laurent Vivier 2019-05-03 11:18 ` [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv Laurent Vivier 2019-05-03 11:18 ` Laurent Vivier 2019-05-03 11:18 ` Laurent Vivier [this message] 2019-05-03 11:18 ` [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning Laurent Vivier 2019-05-03 11:18 ` [Qemu-devel] [PULL v2 07/12] Update configure Laurent Vivier 2019-05-03 11:18 ` Laurent Vivier 2019-05-03 11:21 ` [Qemu-devel] [PULL v2 00/12] Trivial branch patches Laurent Vivier 2019-05-03 11:21 ` Laurent Vivier -- strict thread matches above, loose matches on Subject: below -- 2019-05-03 11:19 Laurent Vivier 2019-05-03 11:19 ` [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning Laurent Vivier 2019-05-03 11:19 ` Laurent Vivier 2019-05-03 11:26 [Qemu-devel] [PULL v2 00/12] Trivial branch patches Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190503111832.30316-7-laurent@vivier.eu \ --to=laurent@vivier.eu \ --cc=afaerber@suse.de \ --cc=atar4qemu@gmail.com \ --cc=berrange@redhat.com \ --cc=chouteau@adacore.com \ --cc=dgilbert@redhat.com \ --cc=jasowang@redhat.com \ --cc=kraxel@redhat.com \ --cc=mark.cave-ayland@ilande.co.uk \ --cc=mdroth@linux.vnet.ibm.com \ --cc=mjt@tls.msk.ru \ --cc=pbonzini@redhat.com \ --cc=philmd@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-trivial@nongnu.org \ --cc=rth@twiddle.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).