From: Laurent Vivier <laurent@vivier.eu> To: qemu-devel@nongnu.org Cc: "Laurent Vivier" <laurent@vivier.eu>, "Paolo Bonzini" <pbonzini@redhat.com>, "Fabien Chouteau" <chouteau@adacore.com>, qemu-trivial@nongnu.org, "Richard Henderson" <rth@twiddle.net>, "Jason Wang" <jasowang@redhat.com>, "Andreas Färber" <afaerber@suse.de>, "Michael Tokarev" <mjt@tls.msk.ru>, "Daniel P. Berrangé" <berrange@redhat.com>, "Gerd Hoffmann" <kraxel@redhat.com>, "Artyom Tarasenko" <atar4qemu@gmail.com>, "Michael Roth" <mdroth@linux.vnet.ibm.com>, "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>, "Wei Yang" <richardw.yang@linux.intel.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Stefano Garzarella" <sgarzare@redhat.com> Subject: [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv Date: Fri, 3 May 2019 13:26:47 +0200 [thread overview] Message-ID: <20190503112654.4393-6-laurent@vivier.eu> (raw) In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> From: Wei Yang <richardw.yang@linux.intel.com> Function object_new_with_propv already get the Type of the object, so we could leverage object_new_with_type here. Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20190311083234.20841-1-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index e3206d6799ee..d3412e7fdca6 100644 --- a/qom/object.c +++ b/qom/object.c @@ -679,7 +679,7 @@ Object *object_new_with_propv(const char *typename, error_setg(errp, "object type '%s' is abstract", typename); return NULL; } - obj = object_new(typename); + obj = object_new_with_type(klass->type); if (object_set_propv(obj, &local_err, vargs) < 0) { goto error; -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <laurent@vivier.eu> To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>, "Jason Wang" <jasowang@redhat.com>, "Michael Tokarev" <mjt@tls.msk.ru>, "Laurent Vivier" <laurent@vivier.eu>, "Fabien Chouteau" <chouteau@adacore.com>, "Michael Roth" <mdroth@linux.vnet.ibm.com>, "Wei Yang" <richardw.yang@linux.intel.com>, "Gerd Hoffmann" <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Stefano Garzarella" <sgarzare@redhat.com>, "Andreas Färber" <afaerber@suse.de>, "Artyom Tarasenko" <atar4qemu@gmail.com>, "Richard Henderson" <rth@twiddle.net> Subject: [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv Date: Fri, 3 May 2019 13:26:47 +0200 [thread overview] Message-ID: <20190503112654.4393-6-laurent@vivier.eu> (raw) Message-ID: <20190503112647.OsDVMu6TDYPWpGcC3Z8yQzX4hMSzdVmWQ463QMA4wHI@z> (raw) In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> From: Wei Yang <richardw.yang@linux.intel.com> Function object_new_with_propv already get the Type of the object, so we could leverage object_new_with_type here. Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20190311083234.20841-1-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index e3206d6799ee..d3412e7fdca6 100644 --- a/qom/object.c +++ b/qom/object.c @@ -679,7 +679,7 @@ Object *object_new_with_propv(const char *typename, error_setg(errp, "object type '%s' is abstract", typename); return NULL; } - obj = object_new(typename); + obj = object_new_with_type(klass->type); if (object_set_propv(obj, &local_err, vargs) < 0) { goto error; -- 2.20.1
next prev parent reply other threads:[~2019-05-03 11:27 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-03 11:26 [Qemu-devel] [PULL v2 00/12] Trivial branch patches Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 04/12] doc: fix the configuration path Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier [this message] 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 07/12] Update configure Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 08/12] Header cleanups Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 09/12] net: Print output of "-net nic, model=help" to stdout instead of stderr Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 10/12] Makefile: Let the 'clean' rule remove qemu-ga.exe on Windows hosts Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 11/12] hw/sparc/leon3: Allow load of uImage firmwares Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-03 11:26 ` [Qemu-devel] [PULL v2 12/12] sockets: avoid string truncation warnings when copying UNIX path Laurent Vivier 2019-05-03 11:26 ` Laurent Vivier 2019-05-07 19:08 ` [Qemu-devel] [PULL v2 00/12] Trivial branch patches Laurent Vivier 2019-05-07 20:48 ` Peter Maydell 2019-05-09 8:51 ` Peter Maydell 2019-05-09 8:58 ` Laurent Vivier 2019-05-09 14:27 ` Peter Maydell -- strict thread matches above, loose matches on Subject: below -- 2019-05-03 11:19 Laurent Vivier 2019-05-03 11:19 ` [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv Laurent Vivier 2019-05-03 11:19 ` Laurent Vivier 2019-05-03 11:18 [Qemu-devel] [PULL v2 00/12] Trivial branch patches Laurent Vivier 2019-05-03 11:18 ` [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv Laurent Vivier 2019-05-03 11:18 ` Laurent Vivier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190503112654.4393-6-laurent@vivier.eu \ --to=laurent@vivier.eu \ --cc=afaerber@suse.de \ --cc=atar4qemu@gmail.com \ --cc=berrange@redhat.com \ --cc=chouteau@adacore.com \ --cc=jasowang@redhat.com \ --cc=kraxel@redhat.com \ --cc=marcandre.lureau@redhat.com \ --cc=mark.cave-ayland@ilande.co.uk \ --cc=mdroth@linux.vnet.ibm.com \ --cc=mjt@tls.msk.ru \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-trivial@nongnu.org \ --cc=richardw.yang@linux.intel.com \ --cc=rth@twiddle.net \ --cc=sgarzare@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).