From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:57861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMbSO-0002jc-6W for qemu-devel@nongnu.org; Fri, 03 May 2019 12:54:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMbSN-0004if-0k for qemu-devel@nongnu.org; Fri, 03 May 2019 12:54:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59446) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMbSM-0004ho-RZ for qemu-devel@nongnu.org; Fri, 03 May 2019 12:54:42 -0400 Date: Fri, 3 May 2019 17:54:35 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20190503165435.GL17905@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20190503004130.8285-1-ehabkost@redhat.com> <20190503004130.8285-20-ehabkost@redhat.com> <40c4d236-ed76-e433-51d5-c9feabb4374a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <40c4d236-ed76-e433-51d5-c9feabb4374a@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Eduardo Habkost , Peter Maydell , qemu-devel@nongnu.org, Cleber Rosa , Markus Armbruster On Fri, May 03, 2019 at 06:41:43PM +0200, Thomas Huth wrote: > On 03/05/2019 02.41, Eduardo Habkost wrote: > > From: Daniel P. Berrang=C3=A9 > >=20 > > Unless overridden via an env var or configure arg, QEMU will only loo= k > > for the 'python' binary in $PATH. This is unhelpful on distros which > > are only shipping Python 3.x (eg Fedora) in their default install as, > > if they comply with PEP 394, the bare 'python' binary won't exist. > >=20 > > This changes configure so that by default it will search for all thre= e > > common python binaries, preferring to find Python 3.x versions. > >=20 > > Signed-off-by: Daniel P. Berrang=C3=A9 > > Message-Id: <20190327170701.23798-1-berrange@redhat.com> > > Signed-off-by: Eduardo Habkost > > --- > > configure | 18 +++++++++++++++--- > > 1 file changed, 15 insertions(+), 3 deletions(-) >=20 > I haven't bisected it, but I think this patch here broke the gitlab-ci = tests: >=20 > https://gitlab.com/huth/qemu/-/jobs/206806257 >=20 > Seems like the test is now failing when you don't have an UTF-8 locale: >=20 > LANG=3DC make check-qapi-schema > [...] > TEST tests/qapi-schema/union-base-empty.out > --- /builds/huth/qemu/tests/qapi-schema/unicode-str.err 2019-05-03 15:= 21:39.000000000 +0000 > +++ - 2019-05-03 15:42:01.561762978 +0000 > @@ -1 +1 @@ > -tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name '=C3= =A9' > +tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name '\x= e9' > /builds/huth/qemu/tests/Makefile.include:1105: recipe for target 'chec= k-tests/qapi-schema/unicode-str.json' failed > make: *** [check-tests/qapi-schema/unicode-str.json] Error 1 >=20 > Any ideas how to fix this? python3 is basically doomed if you use the C locale for LC_CTYPE, as it is not 8-bit clean. If a python3 program is liable to see UTF-8 input data, the following env should generally be set when running python: LC_ALL=3D LANG=3DC LC_CTYPE=3Den_US.UTF-8 =20 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A8E6C43219 for ; Fri, 3 May 2019 16:55:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0ADE3206C3 for ; Fri, 3 May 2019 16:55:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ADE3206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:44638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMbTA-0003O9-B1 for qemu-devel@archiver.kernel.org; Fri, 03 May 2019 12:55:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMbSO-0002jc-6W for qemu-devel@nongnu.org; Fri, 03 May 2019 12:54:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMbSN-0004if-0k for qemu-devel@nongnu.org; Fri, 03 May 2019 12:54:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59446) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMbSM-0004ho-RZ for qemu-devel@nongnu.org; Fri, 03 May 2019 12:54:42 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92C80C02492F; Fri, 3 May 2019 16:54:41 +0000 (UTC) Received: from redhat.com (ovpn-112-52.ams2.redhat.com [10.36.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4663453E0B; Fri, 3 May 2019 16:54:39 +0000 (UTC) Date: Fri, 3 May 2019 17:54:35 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Message-ID: <20190503165435.GL17905@redhat.com> References: <20190503004130.8285-1-ehabkost@redhat.com> <20190503004130.8285-20-ehabkost@redhat.com> <40c4d236-ed76-e433-51d5-c9feabb4374a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <40c4d236-ed76-e433-51d5-c9feabb4374a@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 03 May 2019 16:54:41 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Cleber Rosa , Eduardo Habkost , Markus Armbruster , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190503165435.-gCMGhtLAcUnTI8KvsFcNm0InRL8AEWbzewN6zVSyDE@z> On Fri, May 03, 2019 at 06:41:43PM +0200, Thomas Huth wrote: > On 03/05/2019 02.41, Eduardo Habkost wrote: > > From: Daniel P. Berrang=C3=A9 > >=20 > > Unless overridden via an env var or configure arg, QEMU will only loo= k > > for the 'python' binary in $PATH. This is unhelpful on distros which > > are only shipping Python 3.x (eg Fedora) in their default install as, > > if they comply with PEP 394, the bare 'python' binary won't exist. > >=20 > > This changes configure so that by default it will search for all thre= e > > common python binaries, preferring to find Python 3.x versions. > >=20 > > Signed-off-by: Daniel P. Berrang=C3=A9 > > Message-Id: <20190327170701.23798-1-berrange@redhat.com> > > Signed-off-by: Eduardo Habkost > > --- > > configure | 18 +++++++++++++++--- > > 1 file changed, 15 insertions(+), 3 deletions(-) >=20 > I haven't bisected it, but I think this patch here broke the gitlab-ci = tests: >=20 > https://gitlab.com/huth/qemu/-/jobs/206806257 >=20 > Seems like the test is now failing when you don't have an UTF-8 locale: >=20 > LANG=3DC make check-qapi-schema > [...] > TEST tests/qapi-schema/union-base-empty.out > --- /builds/huth/qemu/tests/qapi-schema/unicode-str.err 2019-05-03 15:= 21:39.000000000 +0000 > +++ - 2019-05-03 15:42:01.561762978 +0000 > @@ -1 +1 @@ > -tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name '=C3= =A9' > +tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name '\x= e9' > /builds/huth/qemu/tests/Makefile.include:1105: recipe for target 'chec= k-tests/qapi-schema/unicode-str.json' failed > make: *** [check-tests/qapi-schema/unicode-str.json] Error 1 >=20 > Any ideas how to fix this? python3 is basically doomed if you use the C locale for LC_CTYPE, as it is not 8-bit clean. If a python3 program is liable to see UTF-8 input data, the following env should generally be set when running python: LC_ALL=3D LANG=3DC LC_CTYPE=3Den_US.UTF-8 =20 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|