qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Stephen Checkoway" <stephen.checkoway@oberlin.edu>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Laszlo Ersek" <lersek@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Max Reitz" <mreitz@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	qemu-block@nongnu.org, "Wei Yang" <richardw.yang@linux.intel.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH 0/5] hw/block/pflash: Add DeviceReset() handlers
Date: Sun,  5 May 2019 22:05:57 +0200	[thread overview]
Message-ID: <20190505200602.12412-1-philmd@redhat.com> (raw)

The pflash device lacks a reset() function.
When a machine is resetted, the flash might be in an
inconsistent state, leading to unexpected behavior:
https://bugzilla.redhat.com/show_bug.cgi?id=1678713

Resolve this issue by adding a DeviceReset() handler.

Both CFI01/CFI02 devices are fixed by this series.

Regards,

Phil.

Philippe Mathieu-Daudé (5):
  hw/block/pflash_cfi01: Removed an unused timer
  hw/block/pflash_cfi01: Extract the pflash_reset() code
  hw/block/pflash_cfi01: Add the DeviceReset() handler
  hw/block/pflash_cfi02: Extract the pflash_reset() code
  hw/block/pflash_cfi02: Add the DeviceReset() handler

 hw/block/pflash_cfi01.c | 31 ++++++++++++-------------------
 hw/block/pflash_cfi02.c | 31 +++++++++++++++++++++----------
 2 files changed, 33 insertions(+), 29 deletions(-)

-- 
2.20.1

WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Stephen Checkoway" <stephen.checkoway@oberlin.edu>,
	qemu-block@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
	"Laszlo Ersek" <lersek@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Wei Yang" <richardw.yang@linux.intel.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 0/5] hw/block/pflash: Add DeviceReset() handlers
Date: Sun,  5 May 2019 22:05:57 +0200	[thread overview]
Message-ID: <20190505200602.12412-1-philmd@redhat.com> (raw)
Message-ID: <20190505200557.naic8gpR8FN40w8e21l9dwcgPaJSihuL9dxsDDxRF-s@z> (raw)

The pflash device lacks a reset() function.
When a machine is resetted, the flash might be in an
inconsistent state, leading to unexpected behavior:
https://bugzilla.redhat.com/show_bug.cgi?id=1678713

Resolve this issue by adding a DeviceReset() handler.

Both CFI01/CFI02 devices are fixed by this series.

Regards,

Phil.

Philippe Mathieu-Daudé (5):
  hw/block/pflash_cfi01: Removed an unused timer
  hw/block/pflash_cfi01: Extract the pflash_reset() code
  hw/block/pflash_cfi01: Add the DeviceReset() handler
  hw/block/pflash_cfi02: Extract the pflash_reset() code
  hw/block/pflash_cfi02: Add the DeviceReset() handler

 hw/block/pflash_cfi01.c | 31 ++++++++++++-------------------
 hw/block/pflash_cfi02.c | 31 +++++++++++++++++++++----------
 2 files changed, 33 insertions(+), 29 deletions(-)

-- 
2.20.1



             reply	other threads:[~2019-05-05 20:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05 20:05 Philippe Mathieu-Daudé [this message]
2019-05-05 20:05 ` [Qemu-devel] [PATCH 0/5] hw/block/pflash: Add DeviceReset() handlers Philippe Mathieu-Daudé
2019-05-05 20:05 ` [Qemu-devel] [PATCH 1/5] hw/block/pflash_cfi01: Removed an unused timer Philippe Mathieu-Daudé
2019-05-05 20:05   ` Philippe Mathieu-Daudé
2019-05-06  0:50   ` Wei Yang
2019-05-06 14:39   ` Laszlo Ersek
2019-05-06 15:00     ` Philippe Mathieu-Daudé
2019-05-05 20:05 ` [Qemu-devel] [PATCH 2/5] hw/block/pflash_cfi01: Extract the pflash_reset() code Philippe Mathieu-Daudé
2019-05-05 20:05   ` Philippe Mathieu-Daudé
2019-05-06  0:54   ` Wei Yang
2019-05-06 14:49   ` Laszlo Ersek
2019-05-06 14:51   ` Laszlo Ersek
2019-05-05 20:06 ` [Qemu-devel] [PATCH 3/5] hw/block/pflash_cfi01: Add the DeviceReset() handler Philippe Mathieu-Daudé
2019-05-05 20:06   ` Philippe Mathieu-Daudé
2019-05-06  1:00   ` Wei Yang
2019-05-06 14:54   ` Laszlo Ersek
2019-05-05 20:06 ` [Qemu-devel] [PATCH 4/5] hw/block/pflash_cfi02: Extract the pflash_reset() code Philippe Mathieu-Daudé
2019-05-05 20:06   ` Philippe Mathieu-Daudé
2019-05-06  1:05   ` Wei Yang
2019-05-06 14:57   ` Laszlo Ersek
2019-05-06 15:03     ` Philippe Mathieu-Daudé
2019-05-05 20:06 ` [Qemu-devel] [PATCH 5/5] hw/block/pflash_cfi02: Add the DeviceReset() handler Philippe Mathieu-Daudé
2019-05-05 20:06   ` Philippe Mathieu-Daudé
2019-05-06  1:05   ` Wei Yang
2019-05-06 15:17   ` Laszlo Ersek
2019-05-06 18:32     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190505200602.12412-1-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=richardw.yang@linux.intel.com \
    --cc=stephen.checkoway@oberlin.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).