* [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include
@ 2019-05-05 22:56 Philippe Mathieu-Daudé
2019-05-05 22:56 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-05 22:56 UTC (permalink / raw)
To: qemu-trivial, qemu-devel
Cc: Gerd Hoffmann, Thomas Huth, Philippe Mathieu-Daudé
Commit ce3cf70edaaf split the ISA device out of the PCI one,
but forgot to remove the "hw/loader.h" header inclusion (the ISA
device calls rom_add_vga()). Remove the now unused include.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/display/cirrus_vga.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
index a0e71469f4d..f67df3c1f6f 100644
--- a/hw/display/cirrus_vga.c
+++ b/hw/display/cirrus_vga.c
@@ -33,7 +33,6 @@
#include "hw/hw.h"
#include "hw/pci/pci.h"
#include "ui/pixel_ops.h"
-#include "hw/loader.h"
#include "cirrus_vga_internal.h"
/*
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include
2019-05-05 22:56 [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include Philippe Mathieu-Daudé
@ 2019-05-05 22:56 ` Philippe Mathieu-Daudé
2019-05-06 3:58 ` Thomas Huth
2019-05-07 7:13 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-05 22:56 UTC (permalink / raw)
To: qemu-trivial, qemu-devel
Cc: Thomas Huth, Philippe Mathieu-Daudé, Gerd Hoffmann
Commit ce3cf70edaaf split the ISA device out of the PCI one,
but forgot to remove the "hw/loader.h" header inclusion (the ISA
device calls rom_add_vga()). Remove the now unused include.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/display/cirrus_vga.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
index a0e71469f4d..f67df3c1f6f 100644
--- a/hw/display/cirrus_vga.c
+++ b/hw/display/cirrus_vga.c
@@ -33,7 +33,6 @@
#include "hw/hw.h"
#include "hw/pci/pci.h"
#include "ui/pixel_ops.h"
-#include "hw/loader.h"
#include "cirrus_vga_internal.h"
/*
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include
2019-05-05 22:56 [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include Philippe Mathieu-Daudé
2019-05-05 22:56 ` Philippe Mathieu-Daudé
@ 2019-05-06 3:58 ` Thomas Huth
2019-05-07 7:13 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2019-05-06 3:58 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-trivial, qemu-devel; +Cc: Gerd Hoffmann
On 06/05/2019 00.56, Philippe Mathieu-Daudé wrote:
> Commit ce3cf70edaaf split the ISA device out of the PCI one,
> but forgot to remove the "hw/loader.h" header inclusion (the ISA
> device calls rom_add_vga()). Remove the now unused include.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/display/cirrus_vga.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
> index a0e71469f4d..f67df3c1f6f 100644
> --- a/hw/display/cirrus_vga.c
> +++ b/hw/display/cirrus_vga.c
> @@ -33,7 +33,6 @@
> #include "hw/hw.h"
> #include "hw/pci/pci.h"
> #include "ui/pixel_ops.h"
> -#include "hw/loader.h"
> #include "cirrus_vga_internal.h"
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include
2019-05-05 22:56 [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include Philippe Mathieu-Daudé
2019-05-05 22:56 ` Philippe Mathieu-Daudé
2019-05-06 3:58 ` Thomas Huth
@ 2019-05-07 7:13 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2019-05-07 7:13 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: qemu-trivial, Thomas Huth, qemu-devel
On Mon, May 06, 2019 at 12:56:40AM +0200, Philippe Mathieu-Daudé wrote:
> Commit ce3cf70edaaf split the ISA device out of the PCI one,
> but forgot to remove the "hw/loader.h" header inclusion (the ISA
> device calls rom_add_vga()). Remove the now unused include.
Added to vga queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-07 7:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-05 22:56 [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include Philippe Mathieu-Daudé
2019-05-05 22:56 ` Philippe Mathieu-Daudé
2019-05-06 3:58 ` Thomas Huth
2019-05-07 7:13 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).