From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com> Subject: [Qemu-devel] [PATCH] hw/sd/sdcard: Use the available enums Date: Mon, 6 May 2019 01:01:40 +0200 [thread overview] Message-ID: <20190505230140.5661-1-philmd@redhat.com> (raw) We already define SDCardModes/SDCardStates as enums. Declare the mode/state as enums too, this make gdb debugging sessions friendlier: instead of numbers, the mode/state name is displayed. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/sd/sd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index aaab15f3868..a66b3d5b45e 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -96,8 +96,8 @@ struct SDState { BlockBackend *blk; bool spi; - uint32_t mode; /* current card mode, one of SDCardModes */ - int32_t state; /* current card state, one of SDCardStates */ + enum SDCardModes mode; + enum SDCardStates state; uint32_t vhs; bool wp_switch; unsigned long *wp_groups; @@ -1640,7 +1640,7 @@ static int cmd_valid_while_locked(SDState *sd, SDRequest *req) int sd_do_command(SDState *sd, SDRequest *req, uint8_t *response) { - int last_state; + enum SDCardStates last_state; sd_rsp_type_t rtype; int rsplen; -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org> Subject: [Qemu-devel] [PATCH] hw/sd/sdcard: Use the available enums Date: Mon, 6 May 2019 01:01:40 +0200 [thread overview] Message-ID: <20190505230140.5661-1-philmd@redhat.com> (raw) Message-ID: <20190505230140.nQMxGCLbTHgg0skFWAxiaA5OajZRqUWzvmkPbido-xs@z> (raw) We already define SDCardModes/SDCardStates as enums. Declare the mode/state as enums too, this make gdb debugging sessions friendlier: instead of numbers, the mode/state name is displayed. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/sd/sd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index aaab15f3868..a66b3d5b45e 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -96,8 +96,8 @@ struct SDState { BlockBackend *blk; bool spi; - uint32_t mode; /* current card mode, one of SDCardModes */ - int32_t state; /* current card state, one of SDCardStates */ + enum SDCardModes mode; + enum SDCardStates state; uint32_t vhs; bool wp_switch; unsigned long *wp_groups; @@ -1640,7 +1640,7 @@ static int cmd_valid_while_locked(SDState *sd, SDRequest *req) int sd_do_command(SDState *sd, SDRequest *req, uint8_t *response) { - int last_state; + enum SDCardStates last_state; sd_rsp_type_t rtype; int rsplen; -- 2.20.1
next reply other threads:[~2019-05-05 23:01 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-05 23:01 Philippe Mathieu-Daudé [this message] 2019-05-05 23:01 ` [Qemu-devel] [PATCH] hw/sd/sdcard: Use the available enums Philippe Mathieu-Daudé 2019-05-06 8:55 ` Markus Armbruster 2019-05-06 11:49 ` Philippe Mathieu-Daudé 2019-05-07 10:25 ` Dr. David Alan Gilbert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190505230140.5661-1-philmd@redhat.com \ --to=philmd@redhat.com \ --cc=f4bug@amsat.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-trivial@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).