From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F62C004C9 for ; Mon, 6 May 2019 01:01:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 766DA20675 for ; Mon, 6 May 2019 01:01:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 766DA20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:48357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNS0l-0001t4-JJ for qemu-devel@archiver.kernel.org; Sun, 05 May 2019 21:01:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNRzr-0001TU-TK for qemu-devel@nongnu.org; Sun, 05 May 2019 21:00:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNRzq-0007wO-3X for qemu-devel@nongnu.org; Sun, 05 May 2019 21:00:47 -0400 Received: from mga01.intel.com ([192.55.52.88]:13499) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNRzp-0007vD-Ox; Sun, 05 May 2019 21:00:46 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 May 2019 18:00:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,435,1549958400"; d="scan'208";a="140302912" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga008.jf.intel.com with ESMTP; 05 May 2019 18:00:37 -0700 Date: Mon, 6 May 2019 09:00:10 +0800 From: Wei Yang To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Message-ID: <20190506010010.GC22671@richard> References: <20190505200602.12412-1-philmd@redhat.com> <20190505200602.12412-4-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190505200602.12412-4-philmd@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 Subject: Re: [Qemu-devel] [PATCH 3/5] hw/block/pflash_cfi01: Add the DeviceReset() handler X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: Kevin Wolf , Peter Maydell , Stephen Checkoway , qemu-block@nongnu.org, "Michael S . Tsirkin" , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-devel@nongnu.org, qemu-stable@nongnu.org, Wei Yang , Paolo Bonzini , Max Reitz , Laszlo Ersek , Markus Armbruster , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, May 05, 2019 at 10:06:00PM +0200, Philippe Mathieu-Daudé wrote: >The pflash device is a child of TYPE_DEVICE, so it can implement >the DeviceReset handler. Actually it has to implement it, else >on machine reset it might stay in an incoherent state, as it has >been reported in the buglink listed below. > >Add the DeviceReset handler and remove its call from the realize() >function. > >Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1678713 >Reported-by: Laszlo Ersek >Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Wei Yang -- Wei Yang Help you, Help me