From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AE5C04A6B for ; Tue, 7 May 2019 00:53:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6200206BF for ; Tue, 7 May 2019 00:53:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="d1Euj+cC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6200206BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ozlabs.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:36079 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNoLs-000234-1a for qemu-devel@archiver.kernel.org; Mon, 06 May 2019 20:53:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNoHW-0006qe-Ia for qemu-devel@nongnu.org; Mon, 06 May 2019 20:48:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNoHV-0002vx-DI for qemu-devel@nongnu.org; Mon, 06 May 2019 20:48:30 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:45611 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNoHU-0002u7-KA; Mon, 06 May 2019 20:48:29 -0400 Received: by ozlabs.org (Postfix, from userid 1010) id 44ygvZ1Qjlz9sBp; Tue, 7 May 2019 10:48:26 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1557190106; bh=mAHu03+fbMghlhKewri6Obh8b7KdkT+iUfKyj4bAHhE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d1Euj+cCY3ZPU9ZXxl3ICjuakFZkY/+596cG+R3UGLTMrJsacqyrN9S49BAKJ/Z85 AsWyE2tyXJfhRjgAuWGOVoee4B5J0kHQiqyqGscA/VGSNpwwnzA+8b7O62+ymG7x+H Ratt+SrEBZrtIDaWlnBiopGkMLAjv0Qnf/GIGYtPzYu68hBhObNJmGaiO6Xj6r17Fj O8O6lMs39/062SKDx8t/m/if1+JqRTMlX+zOcKx9gPXuwrDnovly/iVN5JuhtzlguW qg+VpJBk+eyuLqO6xExG3Y6xyugeViqFPwZvjUzvkIxqxEMp2+lguV4eViCHJLuLfv 8Xw6tb03jhbmw== From: Anton Blanchard To: qemu-ppc@nongnu.org, qemu-devel@nongnu.org Date: Tue, 7 May 2019 10:48:06 +1000 Message-Id: <20190507004811.29968-4-anton@ozlabs.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190507004811.29968-1-anton@ozlabs.org> References: <20190507004811.29968-1-anton@ozlabs.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ego@linux.vnet.ibm.com, sandipandas1990@gmail.com, richard.henderson@linaro.org, mark.cave-ayland@ilande.co.uk, f4bug@amsat.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" During the conversion these instructions were incorrectly treated as stores. We need to use set_cpu_vsr* and not get_cpu_vsr*. Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}()= helpers for VSR register access") Signed-off-by: Anton Blanchard --- target/ppc/translate/vsx-impl.inc.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/v= sx-impl.inc.c index 05b75105be..c13f84e745 100644 --- a/target/ppc/translate/vsx-impl.inc.c +++ b/target/ppc/translate/vsx-impl.inc.c @@ -102,8 +102,7 @@ static void gen_lxvw4x(DisasContext *ctx) } xth =3D tcg_temp_new_i64(); xtl =3D tcg_temp_new_i64(); - get_cpu_vsrh(xth, xT(ctx->opcode)); - get_cpu_vsrl(xtl, xT(ctx->opcode)); + gen_set_access_type(ctx, ACCESS_INT); EA =3D tcg_temp_new(); =20 @@ -126,6 +125,8 @@ static void gen_lxvw4x(DisasContext *ctx) tcg_gen_addi_tl(EA, EA, 8); tcg_gen_qemu_ld_i64(xtl, EA, ctx->mem_idx, MO_BEQ); } + set_cpu_vsrh(xT(ctx->opcode), xth); + set_cpu_vsrl(xT(ctx->opcode), xtl); tcg_temp_free(EA); tcg_temp_free_i64(xth); tcg_temp_free_i64(xtl); @@ -185,8 +186,6 @@ static void gen_lxvh8x(DisasContext *ctx) } xth =3D tcg_temp_new_i64(); xtl =3D tcg_temp_new_i64(); - get_cpu_vsrh(xth, xT(ctx->opcode)); - get_cpu_vsrl(xtl, xT(ctx->opcode)); gen_set_access_type(ctx, ACCESS_INT); =20 EA =3D tcg_temp_new(); @@ -197,6 +196,8 @@ static void gen_lxvh8x(DisasContext *ctx) if (ctx->le_mode) { gen_bswap16x8(xth, xtl, xth, xtl); } + set_cpu_vsrh(xT(ctx->opcode), xth); + set_cpu_vsrl(xT(ctx->opcode), xtl); tcg_temp_free(EA); tcg_temp_free_i64(xth); tcg_temp_free_i64(xtl); @@ -214,14 +215,14 @@ static void gen_lxvb16x(DisasContext *ctx) } xth =3D tcg_temp_new_i64(); xtl =3D tcg_temp_new_i64(); - get_cpu_vsrh(xth, xT(ctx->opcode)); - get_cpu_vsrl(xtl, xT(ctx->opcode)); gen_set_access_type(ctx, ACCESS_INT); EA =3D tcg_temp_new(); gen_addr_reg_index(ctx, EA); tcg_gen_qemu_ld_i64(xth, EA, ctx->mem_idx, MO_BEQ); tcg_gen_addi_tl(EA, EA, 8); tcg_gen_qemu_ld_i64(xtl, EA, ctx->mem_idx, MO_BEQ); + set_cpu_vsrh(xT(ctx->opcode), xth); + set_cpu_vsrl(xT(ctx->opcode), xtl); tcg_temp_free(EA); tcg_temp_free_i64(xth); tcg_temp_free_i64(xtl); --=20 2.20.1