From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E1FDC004C9 for ; Tue, 7 May 2019 08:56:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1E1B204FD for ; Tue, 7 May 2019 08:56:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1E1B204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:42596 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNvtY-0004GQ-6q for qemu-devel@archiver.kernel.org; Tue, 07 May 2019 04:56:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNvp9-00010C-Lw for qemu-devel@nongnu.org; Tue, 07 May 2019 04:51:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNvp8-0002ro-Pe for qemu-devel@nongnu.org; Tue, 07 May 2019 04:51:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48254) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNvp8-0002rM-Hr for qemu-devel@nongnu.org; Tue, 07 May 2019 04:51:42 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7E04966993; Tue, 7 May 2019 08:51:41 +0000 (UTC) Received: from gondolin (dhcp-192-187.str.redhat.com [10.33.192.187]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB47C171C5; Tue, 7 May 2019 08:51:28 +0000 (UTC) Date: Tue, 7 May 2019 10:51:26 +0200 From: Cornelia Huck To: Yan Zhao Message-ID: <20190507105126.4be3a6da.cohuck@redhat.com> In-Reply-To: <20190507053913.GA14284@joy-OptiPlex-7040> References: <20190419083258.19580-1-yan.y.zhao@intel.com> <20190419083505.19654-1-yan.y.zhao@intel.com> <20190423115932.42619422.cohuck@redhat.com> <20190424031036.GB26247@joy-OptiPlex-7040> <20190424095624.0ce97328.cohuck@redhat.com> <20190424081558.GE26247@joy-OptiPlex-7040> <20190430172908.2ae77fa9.cohuck@redhat.com> <20190507053913.GA14284@joy-OptiPlex-7040> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 07 May 2019 08:51:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "cjia@nvidia.com" , "kvm@vger.kernel.org" , "aik@ozlabs.ru" , "Zhengxiao.zx@alibaba-inc.com" , "shuangtai.tst@alibaba-inc.com" , "qemu-devel@nongnu.org" , "kwankhede@nvidia.com" , "eauger@redhat.com" , "Liu, Yi L" , "eskultet@redhat.com" , "Yang, Ziye" , "mlevitsk@redhat.com" , "pasic@linux.ibm.com" , "libvir-list@redhat.com" , "arei.gonglei@huawei.com" , "felipe@nutanix.com" , "Ken.Xue@amd.com" , "Tian, Kevin" , "dgilbert@redhat.com" , "zhenyuw@linux.intel.com" , "alex.williamson@redhat.com" , "intel-gvt-dev@lists.freedesktop.org" , "Liu, Changpeng" , "linux-kernel@vger.kernel.org" , "Wang, Zhi A" , "jonathan.davies@nutanix.com" , "He, Shaopeng" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 7 May 2019 01:39:13 -0400 Yan Zhao wrote: > On Tue, Apr 30, 2019 at 11:29:08PM +0800, Cornelia Huck wrote: > > If I followed the discussion correctly, I think you plan to drop this > > format, don't you? I'd be happy if a vendor driver can use a simple > > number without any prefixes if it so chooses. > > > > I also like the idea of renaming this "migration_version" so that it is > > clear we're dealing with versioning of the migration capability (and > > not a version of the device or so). > hi Cornelia, > sorry I just saw this mail after sending v2 of this patch set... > yes, I dropped the common part and vendor driver now can define whatever it > wishes to identify a device version. Ok, I'll look at v2. > However, I don't agree to rename it to "migration_version", as it still may > bring some kind of confusing with the migration version a vendor driver is > using, e.g. vendor driver changes migration code and increases that migration > version. > In fact, what info we want to get from this attribute is whether this mdev > device is compatible with another mdev device, which is tied to device, and not > necessarily bound to migration. > > do you think so? I'm not 100% convinced; but we can continue the discussion on v2.