From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 08/15] qga: Fix mingw compilation warnings on enum conversion
Date: Tue, 7 May 2019 13:00:04 +0100 [thread overview]
Message-ID: <20190507120011.18100-9-peter.maydell@linaro.org> (raw)
In-Reply-To: <20190507120011.18100-1-peter.maydell@linaro.org>
From: Cao Jiaxi <driver1998@foxmail.com>
The win2qemu[] is supposed to be the conversion table to convert between
STORAGE_BUS_TYPE in Windows SDK and GuestDiskBusType in qga.
But it was incorrectly written that it forces to set a GuestDiskBusType
value to STORAGE_BUS_TYPE, which generates an enum conversion warning in clang.
Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Cao Jiaxi <driver1998@foxmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 20190503003650.10137-1-driver1998@foxmail.com
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
qga/commands-win32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index d40d61f605c..6b67f16faf1 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -457,7 +457,7 @@ void qmp_guest_file_flush(int64_t handle, Error **errp)
#ifdef CONFIG_QGA_NTDDSCSI
-static STORAGE_BUS_TYPE win2qemu[] = {
+static GuestDiskBusType win2qemu[] = {
[BusTypeUnknown] = GUEST_DISK_BUS_TYPE_UNKNOWN,
[BusTypeScsi] = GUEST_DISK_BUS_TYPE_SCSI,
[BusTypeAtapi] = GUEST_DISK_BUS_TYPE_IDE,
--
2.20.1
next prev parent reply other threads:[~2019-05-07 12:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 11:59 [Qemu-devel] [PULL 00/15] target-arm queue Peter Maydell
2019-05-07 11:59 ` [Qemu-devel] [PULL 01/15] pc: Rearrange pc_system_firmware_init()'s legacy -drive loop Peter Maydell
2019-05-07 11:59 ` [Qemu-devel] [PULL 02/15] pflash_cfi01: New pflash_cfi01_legacy_drive() Peter Maydell
2019-05-07 11:59 ` [Qemu-devel] [PULL 03/15] hw/arm/virt: Support firmware configuration with -blockdev Peter Maydell
2019-05-07 12:00 ` [Qemu-devel] [PULL 04/15] hw/arm/raspi: Diagnose requests for too much RAM Peter Maydell
2019-05-07 12:00 ` [Qemu-devel] [PULL 05/15] arm: Allow system registers for KVM guests to be changed by QEMU code Peter Maydell
2019-05-07 12:00 ` [Qemu-devel] [PULL 06/15] arm: aspeed: Set SDRAM size Peter Maydell
2019-05-07 12:00 ` [Qemu-devel] [PULL 07/15] QEMU_PACKED: Remove gcc_struct attribute in Windows non x86 targets Peter Maydell
2019-05-07 12:00 ` Peter Maydell [this message]
2019-05-07 12:00 ` [Qemu-devel] [PULL 09/15] util/cacheinfo: Use uint64_t on LLP64 model to satisfy Windows ARM64 Peter Maydell
2019-05-07 12:00 ` [Qemu-devel] [PULL 10/15] osdep: Fix mingw compilation regarding stdio formats Peter Maydell
2019-05-07 12:00 ` [Qemu-devel] [PULL 11/15] hw/arm/armv7m_nvic: Check subpriority in nvic_recompute_state_secure() Peter Maydell
2019-05-07 12:00 ` [Qemu-devel] [PULL 12/15] hw/intc/armv7m_nvic: NS BFAR and BFSR are RAZ/WI if BFHFNMINS == 0 Peter Maydell
2019-05-07 12:00 ` [Qemu-devel] [PULL 13/15] hw/intc/armv7m_nvic: Don't enable ARMV7M_EXCP_DEBUG from reset Peter Maydell
2019-05-07 12:00 ` [Qemu-devel] [PULL 14/15] target/arm: Implement XPSR GE bits Peter Maydell
2019-05-07 12:00 ` [Qemu-devel] [PULL 15/15] target/arm: Stop using variable length array in dc_zva Peter Maydell
2019-05-08 13:20 ` [Qemu-devel] [PULL 00/15] target-arm queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507120011.18100-9-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).