From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PULL 06/11] qcow2: discard bitmap when removed
Date: Tue, 7 May 2019 17:18:14 +0200 [thread overview]
Message-ID: <20190507151819.17401-7-mreitz@redhat.com> (raw)
In-Reply-To: <20190507151819.17401-1-mreitz@redhat.com>
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Bitmap data may take a lot of disk space, so it's better to discard it
always.
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Message-id: 1551346019-293202-1-git-send-email-andrey.shinkevich@virtuozzo.com
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
[mreitz: Use the commit message proposed by Vladimir]
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/qcow2-bitmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index e53a1609d7..8a75366c92 100644
--- a/block/qcow2-bitmap.c
+++ b/block/qcow2-bitmap.c
@@ -202,7 +202,7 @@ static void clear_bitmap_table(BlockDriverState *bs, uint64_t *bitmap_table,
continue;
}
- qcow2_free_clusters(bs, addr, s->cluster_size, QCOW2_DISCARD_OTHER);
+ qcow2_free_clusters(bs, addr, s->cluster_size, QCOW2_DISCARD_ALWAYS);
bitmap_table[i] = 0;
}
}
--
2.20.1
next prev parent reply other threads:[~2019-05-07 15:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 15:18 [Qemu-devel] [PULL 00/11] Block patches Max Reitz
2019-05-07 15:18 ` [Qemu-devel] [PULL 01/11] qcow2-refcount: fix check_oflag_copied Max Reitz
2019-05-07 15:18 ` [Qemu-devel] [PULL 02/11] qcow2-refcount: avoid eating RAM Max Reitz
2019-05-07 15:18 ` [Qemu-devel] [PULL 03/11] qcow2-refcount: check_refcounts_l2: reduce ignored overlaps Max Reitz
2019-05-07 15:18 ` [Qemu-devel] [PULL 04/11] qcow2-refcount: check_refcounts_l2: don't count fixed cluster as allocated Max Reitz
2019-05-07 15:18 ` [Qemu-devel] [PULL 05/11] qcow2-refcount: don't mask corruptions under internal errors Max Reitz
2019-05-07 15:18 ` Max Reitz [this message]
2019-05-07 15:18 ` [Qemu-devel] [PULL 07/11] block/ssh: Implement .bdrv_refresh_filename() Max Reitz
2019-05-07 15:18 ` [Qemu-devel] [PULL 08/11] block/ssh: Implement .bdrv_dirname() Max Reitz
2019-05-07 15:18 ` [Qemu-devel] [PULL 09/11] block: Assert that drv->bdrv_child_perm is set in bdrv_child_perm() Max Reitz
2019-05-07 15:18 ` [Qemu-devel] [PULL 10/11] commit: Use bdrv_append() in commit_start() Max Reitz
2019-05-07 15:18 ` [Qemu-devel] [PULL 11/11] iotests: Fix iotests 110 and 126 Max Reitz
2019-05-09 8:49 ` [Qemu-devel] [PULL 00/11] Block patches Peter Maydell
2019-05-09 13:27 ` Max Reitz
2019-05-09 16:17 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507151819.17401-7-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).