qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Antony Pavlov" <antonynpavlov@gmail.com>,
	"Paul Burton" <pburton@wavecomp.com>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
	"Joel Stanley" <joel@jms.id.au>,
	"Aleksandar Rikalo" <arikalo@wavecomp.com>,
	qemu-arm@nongnu.org, "Peter Chubb" <peter.chubb@nicta.com.au>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	qemu-ppc@nongnu.org,
	"Jean-Christophe Dubois" <jcd@tribudubois.net>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH v2 00/16] hw: Use object_initialize_child for correct reference counting
Date: Tue,  7 May 2019 18:34:00 +0200	[thread overview]
Message-ID: <20190507163416.24647-1-philmd@redhat.com> (raw)

Hi,

This series looks at Eduardo suggestions from [1]
and Thomas commit aff39be0ed97 to replace various
object_initialize + qdev_set_parent_bus calls by
sysbus_init_child_obj().

Important comment from Eduardo:

  It's possible, but we need a volunteer to review each
  hunk because the existing code might be (correctly)
  calling object_unref() (either immediately or when
  parent is finalized).

I tried to split it enough to make the review process
easier.

Regards,

Phil.

[*] https://patchwork.ozlabs.org/patch/943333/#1953608
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg05931.html

Philippe Mathieu-Daudé (16):
  hw/ppc/pnv: Use object_initialize_child for correct reference counting
  hw/misc/macio: Use object_initialize_child for correct ref. counting
  hw/virtio: Use object_initialize_child for correct reference counting
  hw/arm/bcm2835: Use TYPE_PL011 instead of hardcoded string
  hw/arm/bcm2835: Use object_initialize() on PL011State
  hw/arm/bcm2835: Use object_initialize_child for correct ref. counting
  hw/arm/aspeed: Use object_initialize_child for correct ref. counting
  hw/arm: Use object_initialize_child for correct reference counting
  hw/mips: Use object_initialize() on MIPSCPSState
  hw/mips: Use object_initialize_child for correct reference counting
  hw/microblaze/zynqmp: Move the IPI state into the PMUSoC state
  hw/microblaze/zynqmp: Let the SoC manage the IPI devices
  hw/microblaze/zynqmp: Use object_initialize_child for correct ref.
    counting
  hw/microblaze/zynqmp: Use object_initialize_child for correct ref.
    counting
  hw/arm/mps2: Use object_initialize_child for correct reference
    counting
  hw/intc/nvic: Use object_initialize_child for correct reference
    counting

 hw/arm/aspeed.c                      |  6 +--
 hw/arm/aspeed_soc.c                  | 50 +++++++++--------------
 hw/arm/bcm2835_peripherals.c         | 61 +++++++++++-----------------
 hw/arm/digic.c                       | 17 +++-----
 hw/arm/imx25_pdk.c                   |  5 +--
 hw/arm/kzm.c                         |  5 +--
 hw/arm/mps2-tz.c                     |  8 ++--
 hw/arm/mps2.c                        |  8 ++--
 hw/arm/raspi.c                       |  7 ++--
 hw/arm/sabrelite.c                   |  5 +--
 hw/arm/xlnx-zcu102.c                 |  5 +--
 hw/arm/xlnx-zynqmp.c                 |  8 ++--
 hw/intc/armv7m_nvic.c                |  6 +--
 hw/microblaze/xlnx-zynqmp-pmu.c      | 45 ++++++++++----------
 hw/mips/boston.c                     | 25 ++++++------
 hw/mips/cps.c                        | 20 ++++-----
 hw/mips/mips_malta.c                 | 17 ++++----
 hw/misc/macio/macio.c                |  8 ++--
 hw/ppc/pnv.c                         | 12 ++----
 hw/virtio/virtio.c                   |  5 +--
 include/hw/arm/bcm2835_peripherals.h |  3 +-
 21 files changed, 140 insertions(+), 186 deletions(-)

-- 
2.20.1



             reply	other threads:[~2019-05-07 16:37 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 16:34 Philippe Mathieu-Daudé [this message]
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 01/16] hw/ppc/pnv: Use object_initialize_child for correct reference counting Philippe Mathieu-Daudé
2019-05-08  1:23   ` David Gibson
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 02/16] hw/misc/macio: Use object_initialize_child for correct ref. counting Philippe Mathieu-Daudé
2019-05-08  1:23   ` David Gibson
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 03/16] hw/virtio: Use object_initialize_child for correct reference counting Philippe Mathieu-Daudé
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 04/16] hw/arm/bcm2835: Use TYPE_PL011 instead of hardcoded string Philippe Mathieu-Daudé
2019-05-08 11:09   ` Paolo Bonzini
2019-05-09 20:54   ` Alistair Francis
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 05/16] hw/arm/bcm2835: Use object_initialize() on PL011State Philippe Mathieu-Daudé
2019-05-08 11:09   ` Paolo Bonzini
2019-05-09 20:55   ` Alistair Francis
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 06/16] hw/arm/bcm2835: Use object_initialize_child for correct ref. counting Philippe Mathieu-Daudé
2019-05-08 11:09   ` Paolo Bonzini
2019-05-10 20:20   ` Alistair Francis
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 07/16] hw/arm/aspeed: " Philippe Mathieu-Daudé
2019-05-08 11:13   ` Paolo Bonzini
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 08/16] hw/arm: Use object_initialize_child for correct reference counting Philippe Mathieu-Daudé
2019-05-08 11:15   ` Paolo Bonzini
2019-05-10 20:44   ` Alistair Francis
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 09/16] hw/mips: Use object_initialize() on MIPSCPSState Philippe Mathieu-Daudé
2019-05-08 11:15   ` Paolo Bonzini
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 10/16] hw/mips: Use object_initialize_child for correct reference counting Philippe Mathieu-Daudé
2019-05-08 11:16   ` Paolo Bonzini
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 11/16] hw/microblaze/zynqmp: Move the IPI state into the PMUSoC state Philippe Mathieu-Daudé
2019-05-08 11:17   ` Paolo Bonzini
2019-05-10 20:45   ` Alistair Francis
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 12/16] hw/microblaze/zynqmp: Let the SoC manage the IPI devices Philippe Mathieu-Daudé
2019-05-08 11:18   ` Paolo Bonzini
2019-05-10 20:46   ` Alistair Francis
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 13/16] hw/microblaze/zynqmp: Use object_initialize_child for correct ref. counting Philippe Mathieu-Daudé
2019-05-08 11:18   ` Paolo Bonzini
2019-05-10 20:48   ` Alistair Francis
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 14/16] " Philippe Mathieu-Daudé
2019-05-08 11:19   ` Paolo Bonzini
2019-05-10 20:48   ` Alistair Francis
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 15/16] hw/arm/mps2: Use object_initialize_child for correct reference counting Philippe Mathieu-Daudé
2019-05-08 11:21   ` Paolo Bonzini
2019-05-07 16:34 ` [Qemu-devel] [PATCH v2 16/16] hw/intc/nvic: " Philippe Mathieu-Daudé
2019-05-08 11:20   ` Paolo Bonzini
2019-05-10 20:49   ` Alistair Francis
2019-05-17 10:32 ` [Qemu-devel] [PATCH v2 00/16] hw: " Philippe Mathieu-Daudé
2019-05-17 17:56   ` Eduardo Habkost
2019-05-17 18:06     ` Peter Maydell
2019-05-19 10:37     ` Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190507163416.24647-1-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=Andrew.Baumann@microsoft.com \
    --cc=alistair@alistair23.me \
    --cc=amarkovic@wavecomp.com \
    --cc=andrew@aj.id.au \
    --cc=antonynpavlov@gmail.com \
    --cc=arikalo@wavecomp.com \
    --cc=armbru@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=edgar.iglesias@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=jcd@tribudubois.net \
    --cc=joel@jms.id.au \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=pburton@wavecomp.com \
    --cc=peter.chubb@nicta.com.au \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).