From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749A1C004C9 for ; Tue, 7 May 2019 16:37:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48325205C9 for ; Tue, 7 May 2019 16:37:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48325205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:49794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO35o-0002dY-EH for qemu-devel@archiver.kernel.org; Tue, 07 May 2019 12:37:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO33O-0008UE-06 for qemu-devel@nongnu.org; Tue, 07 May 2019 12:34:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hO33L-0000h5-CM for qemu-devel@nongnu.org; Tue, 07 May 2019 12:34:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46462) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hO33E-0000VY-VH; Tue, 07 May 2019 12:34:46 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39E373001829; Tue, 7 May 2019 16:34:37 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-58.brq.redhat.com [10.40.204.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C25208162; Tue, 7 May 2019 16:34:19 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Markus Armbruster , Thomas Huth , qemu-devel@nongnu.org, Eduardo Habkost Date: Tue, 7 May 2019 18:34:00 +0200 Message-Id: <20190507163416.24647-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 07 May 2019 16:34:38 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 00/16] hw: Use object_initialize_child for correct reference counting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Antony Pavlov , Paul Burton , Andrew Jeffery , Alistair Francis , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Andrew Baumann , Joel Stanley , Aleksandar Rikalo , qemu-arm@nongnu.org, Peter Chubb , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Aleksandar Markovic , "Edgar E. Iglesias" , qemu-ppc@nongnu.org, Jean-Christophe Dubois , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, This series looks at Eduardo suggestions from [1] and Thomas commit aff39be0ed97 to replace various object_initialize + qdev_set_parent_bus calls by sysbus_init_child_obj(). Important comment from Eduardo: It's possible, but we need a volunteer to review each hunk because the existing code might be (correctly) calling object_unref() (either immediately or when parent is finalized). I tried to split it enough to make the review process easier. Regards, Phil. [*] https://patchwork.ozlabs.org/patch/943333/#1953608 v1: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg05931.html Philippe Mathieu-Daud=C3=A9 (16): hw/ppc/pnv: Use object_initialize_child for correct reference counting hw/misc/macio: Use object_initialize_child for correct ref. counting hw/virtio: Use object_initialize_child for correct reference counting hw/arm/bcm2835: Use TYPE_PL011 instead of hardcoded string hw/arm/bcm2835: Use object_initialize() on PL011State hw/arm/bcm2835: Use object_initialize_child for correct ref. counting hw/arm/aspeed: Use object_initialize_child for correct ref. counting hw/arm: Use object_initialize_child for correct reference counting hw/mips: Use object_initialize() on MIPSCPSState hw/mips: Use object_initialize_child for correct reference counting hw/microblaze/zynqmp: Move the IPI state into the PMUSoC state hw/microblaze/zynqmp: Let the SoC manage the IPI devices hw/microblaze/zynqmp: Use object_initialize_child for correct ref. counting hw/microblaze/zynqmp: Use object_initialize_child for correct ref. counting hw/arm/mps2: Use object_initialize_child for correct reference counting hw/intc/nvic: Use object_initialize_child for correct reference counting hw/arm/aspeed.c | 6 +-- hw/arm/aspeed_soc.c | 50 +++++++++-------------- hw/arm/bcm2835_peripherals.c | 61 +++++++++++----------------- hw/arm/digic.c | 17 +++----- hw/arm/imx25_pdk.c | 5 +-- hw/arm/kzm.c | 5 +-- hw/arm/mps2-tz.c | 8 ++-- hw/arm/mps2.c | 8 ++-- hw/arm/raspi.c | 7 ++-- hw/arm/sabrelite.c | 5 +-- hw/arm/xlnx-zcu102.c | 5 +-- hw/arm/xlnx-zynqmp.c | 8 ++-- hw/intc/armv7m_nvic.c | 6 +-- hw/microblaze/xlnx-zynqmp-pmu.c | 45 ++++++++++---------- hw/mips/boston.c | 25 ++++++------ hw/mips/cps.c | 20 ++++----- hw/mips/mips_malta.c | 17 ++++---- hw/misc/macio/macio.c | 8 ++-- hw/ppc/pnv.c | 12 ++---- hw/virtio/virtio.c | 5 +-- include/hw/arm/bcm2835_peripherals.h | 3 +- 21 files changed, 140 insertions(+), 186 deletions(-) --=20 2.20.1