From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v4 4/7] blkdebug: Add "none" event
Date: Tue, 7 May 2019 22:35:05 +0200 [thread overview]
Message-ID: <20190507203508.18026-5-mreitz@redhat.com> (raw)
In-Reply-To: <20190507203508.18026-1-mreitz@redhat.com>
Together with @iotypes and @sector, this can be used to trap e.g. the
first read or write access to a certain sector without having to know
what happens internally in the block layer, i.e. which "real" events
happen right before such an access.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
qapi/block-core.json | 4 +++-
block/blkdebug.c | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 34d261721b..54c927f1ad 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -3215,6 +3215,8 @@
#
# @cor_write: a write due to copy-on-read (since 2.11)
#
+# @none: triggers once at creation of the blkdebug node (since 4.1)
+#
# Since: 2.9
##
{ 'enum': 'BlkdebugEvent', 'prefix': 'BLKDBG',
@@ -3233,7 +3235,7 @@
'pwritev_rmw_tail', 'pwritev_rmw_after_tail', 'pwritev',
'pwritev_zero', 'pwritev_done', 'empty_image_prepare',
'l1_shrink_write_table', 'l1_shrink_free_l2_clusters',
- 'cor_write'] }
+ 'cor_write', 'none' ] }
##
# @BlkdebugIOType:
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 3f3ec11230..1663ed25af 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -491,6 +491,8 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags,
goto out;
}
+ bdrv_debug_event(bs, BLKDBG_NONE);
+
ret = 0;
out:
if (ret < 0) {
--
2.20.1
next prev parent reply other threads:[~2019-05-07 20:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 20:35 [Qemu-devel] [PATCH v4 0/7] qemu-img: Add salvaging mode to convert Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 1/7] qemu-img: Move quiet into ImgConvertState Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 2/7] qemu-img: Add salvaging mode to convert Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 3/7] blkdebug: Add @iotype error option Max Reitz
2019-05-07 20:35 ` Max Reitz [this message]
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 5/7] blkdebug: Inject errors on .bdrv_co_block_status() Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 6/7] iotests: Test qemu-img convert --salvage Max Reitz
2019-05-16 14:40 ` Vladimir Sementsov-Ogievskiy
2019-05-16 14:51 ` Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 7/7] iotests: Test qemu-img convert -C --salvage Max Reitz
2019-06-13 19:52 ` [Qemu-devel] [PATCH v4 0/7] qemu-img: Add salvaging mode to convert Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507203508.18026-5-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).