qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v4 7/7] iotests: Test qemu-img convert -C --salvage
Date: Tue,  7 May 2019 22:35:08 +0200	[thread overview]
Message-ID: <20190507203508.18026-8-mreitz@redhat.com> (raw)
In-Reply-To: <20190507203508.18026-1-mreitz@redhat.com>

We do not support this combination (yet), so this should yield an error
message.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Tested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 tests/qemu-iotests/082     | 1 +
 tests/qemu-iotests/082.out | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/tests/qemu-iotests/082 b/tests/qemu-iotests/082
index 278511dba4..804610c7eb 100755
--- a/tests/qemu-iotests/082
+++ b/tests/qemu-iotests/082
@@ -163,6 +163,7 @@ echo === convert: -C and other options ===
 run_qemu_img convert -C -S 4k -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
 run_qemu_img convert -C -S 8k -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
 run_qemu_img convert -C -c -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
+run_qemu_img convert -C --salvage -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
 
 echo
 echo === amend: Options specified more than once ===
diff --git a/tests/qemu-iotests/082.out b/tests/qemu-iotests/082.out
index 7e25706813..58de358b38 100644
--- a/tests/qemu-iotests/082.out
+++ b/tests/qemu-iotests/082.out
@@ -567,6 +567,9 @@ qemu-img: Cannot enable copy offloading when -S is used
 Testing: convert -C -c -O qcow2 TEST_DIR/t.qcow2 TEST_DIR/t.qcow2.target
 qemu-img: Cannot enable copy offloading when -c is used
 
+Testing: convert -C --salvage -O qcow2 TEST_DIR/t.qcow2 TEST_DIR/t.qcow2.target
+qemu-img: Cannot use copy offloading in salvaging mode
+
 === amend: Options specified more than once ===
 
 Testing: amend -f foo -f qcow2 -o lazy_refcounts=on TEST_DIR/t.qcow2
-- 
2.20.1



  parent reply	other threads:[~2019-05-07 20:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 20:35 [Qemu-devel] [PATCH v4 0/7] qemu-img: Add salvaging mode to convert Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 1/7] qemu-img: Move quiet into ImgConvertState Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 2/7] qemu-img: Add salvaging mode to convert Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 3/7] blkdebug: Add @iotype error option Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 4/7] blkdebug: Add "none" event Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 5/7] blkdebug: Inject errors on .bdrv_co_block_status() Max Reitz
2019-05-07 20:35 ` [Qemu-devel] [PATCH v4 6/7] iotests: Test qemu-img convert --salvage Max Reitz
2019-05-16 14:40   ` Vladimir Sementsov-Ogievskiy
2019-05-16 14:51     ` Max Reitz
2019-05-07 20:35 ` Max Reitz [this message]
2019-06-13 19:52 ` [Qemu-devel] [PATCH v4 0/7] qemu-img: Add salvaging mode to convert Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190507203508.18026-8-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).