From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B40C04AB1 for ; Thu, 9 May 2019 09:41:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43231216C4 for ; Thu, 9 May 2019 09:41:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43231216C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:51433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOfYp-0004bq-It for qemu-devel@archiver.kernel.org; Thu, 09 May 2019 05:41:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOfY5-0004Dd-B4 for qemu-devel@nongnu.org; Thu, 09 May 2019 05:41:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOfY4-0001j3-5t for qemu-devel@nongnu.org; Thu, 09 May 2019 05:41:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34746) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hOfY3-0001if-Fk for qemu-devel@nongnu.org; Thu, 09 May 2019 05:41:08 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AC1EDC057F2B; Thu, 9 May 2019 09:41:06 +0000 (UTC) Received: from redhat.com (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E53EA5C221; Thu, 9 May 2019 09:40:54 +0000 (UTC) Date: Thu, 9 May 2019 10:40:51 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Kevin Wolf Message-ID: <20190509094051.GI31299@redhat.com> References: <20190508182339.22447-1-ehabkost@redhat.com> <87ftpo89le.fsf@dusky.pond.sub.org> <20190509092425.GB6850@localhost.localdomain> <20190509093604.GC6850@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190509093604.GC6850@localhost.localdomain> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 09 May 2019 09:41:06 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] configure: Require python3 >= 3.5 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Thomas Huth , Eduardo Habkost , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Cleber Rosa , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, May 09, 2019 at 11:36:04AM +0200, Kevin Wolf wrote: > Am 09.05.2019 um 11:24 hat Kevin Wolf geschrieben: > > Am 09.05.2019 um 07:45 hat Markus Armbruster geschrieben: > > > Eduardo Habkost writes: > > > > diff --git a/.travis.yml b/.travis.yml > > > > index 66448d99d6..0f6986b3f1 100644 > > > > --- a/.travis.yml > > > > +++ b/.travis.yml > > > > @@ -211,7 +211,7 @@ matrix: > > > > - CONFIG="--target-list=x86_64-softmmu" > > > > language: python > > > > python: > > > > - - "3.4" > > > > + - "3.5" > > > > > > > > > > > > - env: > > > > > > Easily missed, good work. > > > > > > My grep for similar references to Python versions we don't support found > > > a few 2.x, x < 7. Not this patch's problem, of course, but let me show > > > them anyway: > > > > I'm sure that we have a few more instances of Python 2 compatibility > > code in qemu-iotests that can be removed after this is merged. These are > > what I could find quickly, but there are probably more: > > > > 242: # Read one byte in a way compatible with Python 2 > > iotests.py: # Python < 3.4 needs to know not to add whitespace when pretty-printing: > > > > 149:from __future__ import print_function > > 165:from __future__ import print_function > > iotests.py:from __future__ import print_function > > nbd-fault-injector.py:from __future__ import print_function > > qcow2.py:from __future__ import print_function > > qed.py:from __future__ import print_function > > > > 044:if sys.version_info.major == 2: > > 163:if sys.version_info.major == 2: > > iotests.py: if sys.version_info.major >= 3: > > iotests.py: if sys.version_info.major >= 3: > > nbd-fault-injector.py:if sys.version_info.major >= 3: > > > > I'm planning to take care of the qemu-iotests ones. > > > > Also, with Python 3.5 as the new minimum, I think I'd like to add type > > hints to iotests.py and possibly the qemu package (for QEMUQtestMachine > > and friends). The syntax isn't as nice as if we could go straight to > > 3.6, but still, finally some type checking instead of running into > > stupid runtime bugs! > > Ah, sorry, I was getting too excited there. We only deprecate 2.x now > (and not even in this patch), but don't remove it yet. So I guess this > will have to wait until next year. If you're happy using one of the comment based hinting syntax, that will work, or at least not break, with python 2 https://www.bernat.tech/the-state-of-type-hints-in-python/ Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|