From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06BBCC04AB1 for ; Thu, 9 May 2019 14:48:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D09C920644 for ; Thu, 9 May 2019 14:48:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D09C920644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:55901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOkLN-0007k7-6v for qemu-devel@archiver.kernel.org; Thu, 09 May 2019 10:48:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOkJe-0006Wk-5u for qemu-devel@nongnu.org; Thu, 09 May 2019 10:46:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOkJc-00058z-O0 for qemu-devel@nongnu.org; Thu, 09 May 2019 10:46:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60831) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hOkJc-00058g-7F for qemu-devel@nongnu.org; Thu, 09 May 2019 10:46:32 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 405D4806D3; Thu, 9 May 2019 14:46:31 +0000 (UTC) Received: from redhat.com (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5708F5C582; Thu, 9 May 2019 14:46:20 +0000 (UTC) Date: Thu, 9 May 2019 15:46:17 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Laurent Vivier Message-ID: <20190509144617.GE31299@redhat.com> References: <20190509142342.6132-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190509142342.6132-1-lvivier@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 09 May 2019 14:46:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [RFC] rng-builtin: add an RNG backend that uses qemu_guest_getrandom() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Amit Shah , qemu-devel@nongnu.org, Kashyap Chamarthy , Richard Henderson , Markus Armbruster , "Richard W . M . Jones" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, May 09, 2019 at 04:23:42PM +0200, Laurent Vivier wrote: > Add a new RNG backend using QEMU builtin getrandom function. > > It can be created with "-object rng-builtin". > > This patch applies on top of > "[PATCH v4 00/24] Add qemu_getrandom and ARMv8.5-RNG etc" > Based-on: <20190506173353.32206-1-richard.henderson@linaro.org> These 3 lines ought to be below the "---" since they're not relevant once merged. > Signed-off-by: Laurent Vivier > --- > backends/Makefile.objs | 2 +- > backends/rng-builtin.c | 56 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 57 insertions(+), 1 deletion(-) > create mode 100644 backends/rng-builtin.c qemu-options.hx has docs for each backend object type. We should add rng-builtin there, and also perhaps update rng-random docs to have it encourse use of rng-builtin by default instead. The code itself looks good. > > diff --git a/backends/Makefile.objs b/backends/Makefile.objs > index ff619d31b461..8da4a508d97b 100644 > --- a/backends/Makefile.objs > +++ b/backends/Makefile.objs > @@ -1,4 +1,4 @@ > -common-obj-y += rng.o rng-egd.o > +common-obj-y += rng.o rng-egd.o rng-builtin.o > common-obj-$(CONFIG_POSIX) += rng-random.o > > common-obj-$(CONFIG_TPM) += tpm.o > diff --git a/backends/rng-builtin.c b/backends/rng-builtin.c > new file mode 100644 > index 000000000000..b1264b745407 > --- /dev/null > +++ b/backends/rng-builtin.c > @@ -0,0 +1,56 @@ > +/* > + * QEMU Builtin Random Number Generator Backend > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > + > +#include "qemu/osdep.h" > +#include "sysemu/rng.h" > +#include "qapi/error.h" > +#include "qapi/qmp/qerror.h" > +#include "qemu/main-loop.h" > +#include "qemu/guest-random.h" > + > +#define TYPE_RNG_BUILTIN "rng-builtin" > +#define RNG_BUILTIN(obj) OBJECT_CHECK(RngBuiltin, (obj), TYPE_RNG_BUILTIN) > + > +typedef struct RngBuiltin { > + RngBackend parent; > +} RngBuiltin; > + > +static void rng_builtin_request_entropy(RngBackend *b, RngRequest *req) > +{ > + RngBuiltin *s = RNG_BUILTIN(b); > + > + while (!QSIMPLEQ_EMPTY(&s->parent.requests)) { > + RngRequest *req = QSIMPLEQ_FIRST(&s->parent.requests); > + > + qemu_guest_getrandom_nofail(req->data, req->size); > + > + req->receive_entropy(req->opaque, req->data, req->size); > + > + rng_backend_finalize_request(&s->parent, req); > + } > +} > + > +static void rng_builtin_class_init(ObjectClass *klass, void *data) > +{ > + RngBackendClass *rbc = RNG_BACKEND_CLASS(klass); > + > + rbc->request_entropy = rng_builtin_request_entropy; > +} > + > +static const TypeInfo rng_builtin_info = { > + .name = TYPE_RNG_BUILTIN, > + .parent = TYPE_RNG_BACKEND, > + .instance_size = sizeof(RngBuiltin), > + .class_init = rng_builtin_class_init, > +}; > + > +static void register_types(void) > +{ > + type_register_static(&rng_builtin_info); > +} > + > +type_init(register_types); > -- > 2.20.1 > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|