From: Greg Kurz <groug@kaod.org>
To: Thomas Huth <thuth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/6] fsdev: Move some types definition to qemu-fsdev.c
Date: Thu, 9 May 2019 15:21:32 +0200 [thread overview]
Message-ID: <20190509152132.2104490f@bahia.lan> (raw)
In-Reply-To: <856d5954-7198-2b72-df90-12de16813761@redhat.com>
On Wed, 8 May 2019 10:28:03 +0200
Thomas Huth <thuth@redhat.com> wrote:
> On 07/05/2019 10.45, Greg Kurz wrote:
> > It would make sense for these types to be defined in a header file if
> > we had an API for fsdrivers to register themselves. In practice, we
> > only have three of them and it is very unlikely we add new ones since
> > the future of file sharing between host and guest is the upcoming
> > virtio-fs.
> >
> > Move the types to qemu-fsdev.c instead since they are only used there.
> >
> > Signed-off-by: Greg Kurz <groug@kaod.org>
> > ---
> > fsdev/qemu-fsdev.c | 23 +++++++++++++++++++++++
> > fsdev/qemu-fsdev.h | 24 ------------------------
> > 2 files changed, 23 insertions(+), 24 deletions(-)
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Applied to https://github.com/gkurz/qemu/commits/9p-next
Cheers,
--
Greg
next prev parent reply other threads:[~2019-05-09 13:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 8:44 [Qemu-devel] [PATCH 0/6] fsdev/virtfs: Assorted cleanups and fixes Greg Kurz
2019-05-07 8:44 ` [Qemu-devel] [PATCH 1/6] fsdev: Drop unused extern declaration Greg Kurz
2019-05-07 10:15 ` Thomas Huth
2019-05-09 13:20 ` Greg Kurz
2019-05-07 8:44 ` [Qemu-devel] [PATCH 2/6] fsdev: Drop unused opaque field Greg Kurz
2019-05-07 10:24 ` Thomas Huth
2019-05-09 13:21 ` Greg Kurz
2019-05-07 8:45 ` [Qemu-devel] [PATCH 3/6] fsdev: Move some types definition to qemu-fsdev.c Greg Kurz
2019-05-08 8:28 ` Thomas Huth
2019-05-09 13:21 ` Greg Kurz [this message]
2019-05-07 8:45 ` [Qemu-devel] [PATCH 4/6] fsdev: Error out when unsupported option is passed Greg Kurz
2019-05-08 16:23 ` Eric Blake
2019-05-09 13:22 ` Greg Kurz
2019-05-07 8:45 ` [Qemu-devel] [PATCH 5/6] vl: Deprecate -virtfs_synth Greg Kurz
2019-05-08 8:26 ` Thomas Huth
2019-05-08 8:55 ` Greg Kurz
2019-05-07 8:45 ` [Qemu-devel] [PATCH 6/6] virtfs: Fix documentation of -fsdev and -virtfs Greg Kurz
2019-05-08 15:54 ` Thomas Huth
2019-05-09 13:18 ` Greg Kurz
2019-05-13 8:39 ` Thomas Huth
2019-05-13 9:34 ` Greg Kurz
2019-05-13 9:47 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509152132.2104490f@bahia.lan \
--to=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).