From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62FE8C04AB1 for ; Thu, 9 May 2019 13:23:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 356D121479 for ; Thu, 9 May 2019 13:23:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 356D121479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:54498 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOj10-0001OP-Dm for qemu-devel@archiver.kernel.org; Thu, 09 May 2019 09:23:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOizW-0000Rb-9i for qemu-devel@nongnu.org; Thu, 09 May 2019 09:21:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOizV-0000vu-A6 for qemu-devel@nongnu.org; Thu, 09 May 2019 09:21:42 -0400 Received: from 20.mo3.mail-out.ovh.net ([178.33.47.94]:45952) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hOizV-0000sl-2x for qemu-devel@nongnu.org; Thu, 09 May 2019 09:21:41 -0400 Received: from player772.ha.ovh.net (unknown [10.108.35.90]) by mo3.mail-out.ovh.net (Postfix) with ESMTP id 7A28820A132 for ; Thu, 9 May 2019 15:21:37 +0200 (CEST) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player772.ha.ovh.net (Postfix) with ESMTPSA id 97E0B58D661F; Thu, 9 May 2019 13:21:34 +0000 (UTC) Date: Thu, 9 May 2019 15:21:32 +0200 From: Greg Kurz To: Thomas Huth Message-ID: <20190509152132.2104490f@bahia.lan> In-Reply-To: <856d5954-7198-2b72-df90-12de16813761@redhat.com> References: <155721868351.451636.16735088470797960209.stgit@bahia.lan> <155721870044.451636.8272207759150286399.stgit@bahia.lan> <856d5954-7198-2b72-df90-12de16813761@redhat.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 2981664429618272562 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigddtvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 178.33.47.94 Subject: Re: [Qemu-devel] [PATCH 3/6] fsdev: Move some types definition to qemu-fsdev.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 8 May 2019 10:28:03 +0200 Thomas Huth wrote: > On 07/05/2019 10.45, Greg Kurz wrote: > > It would make sense for these types to be defined in a header file if > > we had an API for fsdrivers to register themselves. In practice, we > > only have three of them and it is very unlikely we add new ones since > > the future of file sharing between host and guest is the upcoming > > virtio-fs. > > > > Move the types to qemu-fsdev.c instead since they are only used there. > > > > Signed-off-by: Greg Kurz > > --- > > fsdev/qemu-fsdev.c | 23 +++++++++++++++++++++++ > > fsdev/qemu-fsdev.h | 24 ------------------------ > > 2 files changed, 23 insertions(+), 24 deletions(-) > > Reviewed-by: Thomas Huth Applied to https://github.com/gkurz/qemu/commits/9p-next Cheers, -- Greg