qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive
@ 2019-05-09  8:07 sathnaga
  2019-05-09  8:10 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: sathnaga @ 2019-05-09  8:07 UTC (permalink / raw)
  To: qemu-ppc, qemu-devel; +Cc: Satheesh Rajendran, clg, david

From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>

Instead of LISN i.e "Logical Interrupt Source Number" as per
Xive PAPR document "info pic" prints as LSIN, let's fix it.

Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
---
 hw/intc/spapr_xive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c
index 7faf03b1fb..df3c879826 100644
--- a/hw/intc/spapr_xive.c
+++ b/hw/intc/spapr_xive.c
@@ -141,7 +141,7 @@ void spapr_xive_pic_print_info(SpaprXive *xive, Monitor *mon)
     XiveSource *xsrc = &xive->source;
     int i;
 
-    monitor_printf(mon, "  LSIN         PQ    EISN     CPU/PRIO EQ\n");
+    monitor_printf(mon, "  LISN         PQ    EISN     CPU/PRIO EQ\n");
 
     for (i = 0; i < xive->nr_irqs; i++) {
         uint8_t pq = xive_source_esb_get(xsrc, i);
-- 
2.21.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [Qemu-ppc] [PATCH] Fix typo on "info pic" monitor cmd output for xive
  2019-05-09  8:07 [Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive sathnaga
@ 2019-05-09  8:10 ` Greg Kurz
  2019-05-09  9:11 ` [Qemu-devel] " Cédric Le Goater
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Greg Kurz @ 2019-05-09  8:10 UTC (permalink / raw)
  To: sathnaga; +Cc: david, qemu-ppc, qemu-devel, clg

On Thu,  9 May 2019 13:37:50 +0530
sathnaga@linux.vnet.ibm.com wrote:

> From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> 
> Instead of LISN i.e "Logical Interrupt Source Number" as per
> Xive PAPR document "info pic" prints as LSIN, let's fix it.
> 
> Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> ---

Reviewed-by: Greg Kurz <groug@kaod.org>

>  hw/intc/spapr_xive.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c
> index 7faf03b1fb..df3c879826 100644
> --- a/hw/intc/spapr_xive.c
> +++ b/hw/intc/spapr_xive.c
> @@ -141,7 +141,7 @@ void spapr_xive_pic_print_info(SpaprXive *xive, Monitor *mon)
>      XiveSource *xsrc = &xive->source;
>      int i;
>  
> -    monitor_printf(mon, "  LSIN         PQ    EISN     CPU/PRIO EQ\n");
> +    monitor_printf(mon, "  LISN         PQ    EISN     CPU/PRIO EQ\n");
>  
>      for (i = 0; i < xive->nr_irqs; i++) {
>          uint8_t pq = xive_source_esb_get(xsrc, i);



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive
  2019-05-09  8:07 [Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive sathnaga
  2019-05-09  8:10 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
@ 2019-05-09  9:11 ` Cédric Le Goater
  2019-05-09 14:08 ` Stefano Garzarella
  2019-05-10  2:01 ` David Gibson
  3 siblings, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2019-05-09  9:11 UTC (permalink / raw)
  To: sathnaga, qemu-ppc, qemu-devel; +Cc: david

On 5/9/19 10:07 AM, sathnaga@linux.vnet.ibm.com wrote:
> From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> 
> Instead of LISN i.e "Logical Interrupt Source Number" as per
> Xive PAPR document "info pic" prints as LSIN, let's fix it.
> 
> Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>



Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>  hw/intc/spapr_xive.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c
> index 7faf03b1fb..df3c879826 100644
> --- a/hw/intc/spapr_xive.c
> +++ b/hw/intc/spapr_xive.c
> @@ -141,7 +141,7 @@ void spapr_xive_pic_print_info(SpaprXive *xive, Monitor *mon)
>      XiveSource *xsrc = &xive->source;
>      int i;
>  
> -    monitor_printf(mon, "  LSIN         PQ    EISN     CPU/PRIO EQ\n");
> +    monitor_printf(mon, "  LISN         PQ    EISN     CPU/PRIO EQ\n");
>  
>      for (i = 0; i < xive->nr_irqs; i++) {
>          uint8_t pq = xive_source_esb_get(xsrc, i);
> 



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive
  2019-05-09  8:07 [Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive sathnaga
  2019-05-09  8:10 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
  2019-05-09  9:11 ` [Qemu-devel] " Cédric Le Goater
@ 2019-05-09 14:08 ` Stefano Garzarella
  2019-05-10  2:01 ` David Gibson
  3 siblings, 0 replies; 5+ messages in thread
From: Stefano Garzarella @ 2019-05-09 14:08 UTC (permalink / raw)
  To: sathnaga; +Cc: qemu-trivial, david, qemu-ppc, qemu-devel, clg

On Thu, May 09, 2019 at 01:37:50PM +0530, sathnaga@linux.vnet.ibm.com wrote:
> From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> 
> Instead of LISN i.e "Logical Interrupt Source Number" as per
> Xive PAPR document "info pic" prints as LSIN, let's fix it.
> 
> Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> ---
>  hw/intc/spapr_xive.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

CCing qemu-trivial

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks,
Stefano


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive
  2019-05-09  8:07 [Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive sathnaga
                   ` (2 preceding siblings ...)
  2019-05-09 14:08 ` Stefano Garzarella
@ 2019-05-10  2:01 ` David Gibson
  3 siblings, 0 replies; 5+ messages in thread
From: David Gibson @ 2019-05-10  2:01 UTC (permalink / raw)
  To: sathnaga; +Cc: qemu-ppc, qemu-devel, clg

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

On Thu, May 09, 2019 at 01:37:50PM +0530, sathnaga@linux.vnet.ibm.com wrote:
> From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> 
> Instead of LISN i.e "Logical Interrupt Source Number" as per
> Xive PAPR document "info pic" prints as LSIN, let's fix it.
> 
> Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>

Applied to ppc-for-4.1, thanks.

> ---
>  hw/intc/spapr_xive.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c
> index 7faf03b1fb..df3c879826 100644
> --- a/hw/intc/spapr_xive.c
> +++ b/hw/intc/spapr_xive.c
> @@ -141,7 +141,7 @@ void spapr_xive_pic_print_info(SpaprXive *xive, Monitor *mon)
>      XiveSource *xsrc = &xive->source;
>      int i;
>  
> -    monitor_printf(mon, "  LSIN         PQ    EISN     CPU/PRIO EQ\n");
> +    monitor_printf(mon, "  LISN         PQ    EISN     CPU/PRIO EQ\n");
>  
>      for (i = 0; i < xive->nr_irqs; i++) {
>          uint8_t pq = xive_source_esb_get(xsrc, i);

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-05-10  2:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-09  8:07 [Qemu-devel] [PATCH] Fix typo on "info pic" monitor cmd output for xive sathnaga
2019-05-09  8:10 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2019-05-09  9:11 ` [Qemu-devel] " Cédric Le Goater
2019-05-09 14:08 ` Stefano Garzarella
2019-05-10  2:01 ` David Gibson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).