From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 02/24] crypto: Merge crypto-obj-y into libqemuutil.a
Date: Fri, 10 May 2019 09:55:58 +0100 [thread overview]
Message-ID: <20190510085558.GE7671@redhat.com> (raw)
In-Reply-To: <20190510012458.22706-3-richard.henderson@linaro.org>
On Thu, May 09, 2019 at 06:24:36PM -0700, Richard Henderson wrote:
> We will shortly need this in the user-only binaries, so drop the split
> into system and tools binaries. This also means that crypto-aes-obj-y
> can be merged back into crypto-obj-y.
>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> Makefile | 12 +++++-------
> Makefile.objs | 8 ++------
> Makefile.target | 4 ----
> configure | 9 +++------
> crypto/Makefile.objs | 5 +----
> 5 files changed, 11 insertions(+), 27 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index a971247cac..7c9c208207 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -410,7 +410,6 @@ dummy := $(call unnest-vars,, \
> block-obj-y \
> block-obj-m \
> crypto-obj-y \
> - crypto-aes-obj-y \
> qom-obj-y \
> io-obj-y \
> common-obj-y \
> @@ -446,7 +445,6 @@ SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
>
> $(SOFTMMU_SUBDIR_RULES): $(authz-obj-y)
> $(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
> -$(SOFTMMU_SUBDIR_RULES): $(crypto-obj-y)
> $(SOFTMMU_SUBDIR_RULES): $(io-obj-y)
> $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak
> $(SOFTMMU_SUBDIR_RULES): $(edk2-decompressed)
> @@ -502,7 +500,7 @@ Makefile: $(version-obj-y)
> ######################################################################
> # Build libraries
>
> -libqemuutil.a: $(util-obj-y) $(trace-obj-y) $(stub-obj-y)
> +libqemuutil.a: $(util-obj-y) $(trace-obj-y) $(stub-obj-y) $(crypto-obj-y)
The main reason for a separate crypto-obj-y variable was that it was only
built into some pieces of QEMU. Since we're building into libqemuutil.a
now, we might as well just add all the crypto object files directly
to the util-obj-y variable & drop crypto-obj-y entirely.
That said, what you've done here is fine, so don't feel this comment
is mandatory. Its just an idea for a cleanup if you need to repost
again for another reason.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-05-10 8:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 1:24 [Qemu-devel] [PATCH v5 00/24] Add qemu_getrandom and ARMv8.5-RNG etc Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 01/24] configure: Link test before auto-enabling crypto libraries Richard Henderson
2019-05-10 8:52 ` Daniel P. Berrangé
2019-05-10 9:50 ` Laurent Vivier
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 02/24] crypto: Merge crypto-obj-y into libqemuutil.a Richard Henderson
2019-05-10 8:55 ` Daniel P. Berrangé [this message]
2019-05-10 9:57 ` Laurent Vivier
2019-05-10 15:27 ` Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 03/24] crypto: Reverse code blocks in random-platform.c Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 04/24] crypto: Do not fail for EINTR during qcrypto_random_bytes Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 05/24] crypto: Use O_CLOEXEC in qcrypto_random_init Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 06/24] crypto: Use getrandom for qcrypto_random_bytes Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 07/24] crypto: Change the qcrypto_random_bytes buffer type to void* Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 08/24] ui/vnc: Split out authentication_failed Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 09/24] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 10/24] util: Add qemu_guest_getrandom and associated routines Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 11/24] cpus: Initialize pseudo-random seeds for all guest cpus Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 12/24] linux-user: " Richard Henderson
2019-05-10 8:31 ` Laurent Vivier
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 13/24] linux-user: Call qcrypto_init if not using -seed Richard Henderson
2019-05-10 10:03 ` Laurent Vivier
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 14/24] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 15/24] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 16/24] linux-user: Remove srand call Richard Henderson
2019-05-10 8:32 ` Laurent Vivier
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 17/24] aspeed/scu: Use qemu_guest_getrandom_nofail Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 18/24] hw/misc/nrf51_rng: " Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 19/24] hw/misc/bcm2835_rng: " Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 20/24] hw/misc/exynos4210_rng: Use qemu_guest_getrandom Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 21/24] target/arm: Put all PAC keys into a structure Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG Richard Henderson
2019-05-10 16:01 ` Peter Maydell
2019-05-10 16:17 ` Richard Henderson
2019-05-10 16:20 ` Peter Maydell
2019-05-10 16:21 ` Richard Henderson
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 23/24] target/ppc: Use qemu_guest_getrandom for DARN Richard Henderson
2019-05-10 8:33 ` Laurent Vivier
2019-05-10 1:24 ` [Qemu-devel] [PATCH v5 24/24] target/i386: Implement CPUID_EXT_RDRAND Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510085558.GE7671@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).