From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: [Qemu-devel] [PULL v2 6/7] linux-user: avoid treading on gprof's SIGPROF signals
Date: Fri, 10 May 2019 12:45:35 +0200 [thread overview]
Message-ID: <20190510104536.17483-7-laurent@vivier.eu> (raw)
In-Reply-To: <20190510104536.17483-1-laurent@vivier.eu>
From: Alex Bennée <alex.bennee@linaro.org>
The guest tends to get confused when it receives signals it doesn't
know about. Given the gprof magic has also set up it's own handler we
would do well to avoid stomping on it as well.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20190502145846.26226-1-alex.bennee@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/signal.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index e2c0b3717357..44b2d3b35a0d 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -508,6 +508,11 @@ void signal_init(void)
act.sa_flags = SA_SIGINFO;
act.sa_sigaction = host_signal_handler;
for(i = 1; i <= TARGET_NSIG; i++) {
+#ifdef TARGET_GPROF
+ if (i == SIGPROF) {
+ continue;
+ }
+#endif
host_sig = target_to_host_signal(i);
sigaction(host_sig, NULL, &oact);
if (oact.sa_sigaction == (void *)SIG_IGN) {
--
2.20.1
next prev parent reply other threads:[~2019-05-10 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 10:45 [Qemu-devel] [PULL v2 0/7] Linux user for 4.1 patches Laurent Vivier
2019-05-10 10:45 ` [Qemu-devel] [PULL v2 1/7] linux-user: Add missing IPV6 sockopts Laurent Vivier
2019-05-10 10:45 ` [Qemu-devel] [PULL v2 2/7] linux-user/elfload: Fix GCC 9 build warnings Laurent Vivier
2019-05-10 10:45 ` [Qemu-devel] [PULL v2 3/7] linux-user: avoid string truncation warnings in uname field copying Laurent Vivier
2019-05-10 10:45 ` [Qemu-devel] [PULL v2 4/7] The ioctl(SIOCGIFNAME) call requires a struct ifreq Laurent Vivier
2019-05-10 10:45 ` [Qemu-devel] [PULL v2 5/7] linux-user: elf: Map empty PT_LOAD segments Laurent Vivier
2019-05-10 10:45 ` Laurent Vivier [this message]
2019-05-10 10:45 ` [Qemu-devel] [PULL v2 7/7] linux-user: fix GPROF build failure Laurent Vivier
2019-05-10 12:32 ` [Qemu-devel] [PULL v2 0/7] Linux user for 4.1 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510104536.17483-7-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).