From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0999C04A6B for ; Fri, 10 May 2019 13:45:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76C92216C4 for ; Fri, 10 May 2019 13:45:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76C92216C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:43617 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP5q0-0004bD-Nz for qemu-devel@archiver.kernel.org; Fri, 10 May 2019 09:45:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP5n8-0002ab-8A for qemu-devel@nongnu.org; Fri, 10 May 2019 09:42:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hP5n6-0007XJ-HU for qemu-devel@nongnu.org; Fri, 10 May 2019 09:42:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46028) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hP5n6-0007Wc-A3 for qemu-devel@nongnu.org; Fri, 10 May 2019 09:42:24 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5329E308FBA6; Fri, 10 May 2019 13:42:22 +0000 (UTC) Received: from thinkpad.redhat.com (unknown [10.40.205.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94A121018A2A; Fri, 10 May 2019 13:42:16 +0000 (UTC) From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 10 May 2019 15:42:02 +0200 Message-Id: <20190510134203.24012-3-lvivier@redhat.com> In-Reply-To: <20190510134203.24012-1-lvivier@redhat.com> References: <20190510134203.24012-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 10 May 2019 13:42:22 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 2/3] rng-builtin: add an RNG backend that uses qemu_guest_getrandom() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Kashyap Chamarthy , "Michael S. Tsirkin" , Richard Henderson , Markus Armbruster , Amit Shah , "Richard W . M . Jones" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Add a new RNG backend using QEMU builtin getrandom function. It can be created and used with something like: ... -object rng-builtin,id=3Drng0 -device virtio-rng,rng=3Drng0 ... Reviewed-by: Richard Henderson Signed-off-by: Laurent Vivier --- backends/Makefile.objs | 2 +- backends/rng-builtin.c | 56 ++++++++++++++++++++++++++++++++++++++++++ qemu-options.hx | 10 +++++++- 3 files changed, 66 insertions(+), 2 deletions(-) create mode 100644 backends/rng-builtin.c diff --git a/backends/Makefile.objs b/backends/Makefile.objs index ff619d31b461..8da4a508d97b 100644 --- a/backends/Makefile.objs +++ b/backends/Makefile.objs @@ -1,4 +1,4 @@ -common-obj-y +=3D rng.o rng-egd.o +common-obj-y +=3D rng.o rng-egd.o rng-builtin.o common-obj-$(CONFIG_POSIX) +=3D rng-random.o =20 common-obj-$(CONFIG_TPM) +=3D tpm.o diff --git a/backends/rng-builtin.c b/backends/rng-builtin.c new file mode 100644 index 000000000000..b1264b745407 --- /dev/null +++ b/backends/rng-builtin.c @@ -0,0 +1,56 @@ +/* + * QEMU Builtin Random Number Generator Backend + * + * This work is licensed under the terms of the GNU GPL, version 2 or la= ter. + * See the COPYING file in the top-level directory. + */ + +#include "qemu/osdep.h" +#include "sysemu/rng.h" +#include "qapi/error.h" +#include "qapi/qmp/qerror.h" +#include "qemu/main-loop.h" +#include "qemu/guest-random.h" + +#define TYPE_RNG_BUILTIN "rng-builtin" +#define RNG_BUILTIN(obj) OBJECT_CHECK(RngBuiltin, (obj), TYPE_RNG_BUILTI= N) + +typedef struct RngBuiltin { + RngBackend parent; +} RngBuiltin; + +static void rng_builtin_request_entropy(RngBackend *b, RngRequest *req) +{ + RngBuiltin *s =3D RNG_BUILTIN(b); + + while (!QSIMPLEQ_EMPTY(&s->parent.requests)) { + RngRequest *req =3D QSIMPLEQ_FIRST(&s->parent.requests); + + qemu_guest_getrandom_nofail(req->data, req->size); + + req->receive_entropy(req->opaque, req->data, req->size); + + rng_backend_finalize_request(&s->parent, req); + } +} + +static void rng_builtin_class_init(ObjectClass *klass, void *data) +{ + RngBackendClass *rbc =3D RNG_BACKEND_CLASS(klass); + + rbc->request_entropy =3D rng_builtin_request_entropy; +} + +static const TypeInfo rng_builtin_info =3D { + .name =3D TYPE_RNG_BUILTIN, + .parent =3D TYPE_RNG_BACKEND, + .instance_size =3D sizeof(RngBuiltin), + .class_init =3D rng_builtin_class_init, +}; + +static void register_types(void) +{ + type_register_static(&rng_builtin_info); +} + +type_init(register_types); diff --git a/qemu-options.hx b/qemu-options.hx index 4df0ea3aed5c..6ab920f12be4 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4280,13 +4280,21 @@ other options. =20 The @option{share} boolean option is @var{on} by default with memfd. =20 +@item -object rng-builtin,id=3D@var{id} + +Creates a random number generator backend which obtains entropy from +QEMU builtin functions. The @option{id} parameter is a unique ID that +will be used to reference this entropy backend from the @option{virtio-r= ng} +device. + @item -object rng-random,id=3D@var{id},filename=3D@var{/dev/random} =20 Creates a random number generator backend which obtains entropy from a device on the host. The @option{id} parameter is a unique ID that will be used to reference this entropy backend from the @option{virtio-r= ng} device. The @option{filename} parameter specifies which file to obtain -entropy from and if omitted defaults to @option{/dev/urandom}. +entropy from and if omitted defaults to @option{/dev/urandom}. By defaul= t, +the @option{virtio-rng} device uses this RNG backend. =20 @item -object rng-egd,id=3D@var{id},chardev=3D@var{chardevid} =20 --=20 2.20.1