From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: mprivozn@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP
Date: Fri, 10 May 2019 18:26:41 +0100 [thread overview]
Message-ID: <20190510172641.GS7671@redhat.com> (raw)
In-Reply-To: <20190510171711.GS4189@habkost.net>
On Fri, May 10, 2019 at 02:17:11PM -0300, Eduardo Habkost wrote:
> On Fri, May 10, 2019 at 11:29:53AM +0200, Markus Armbruster wrote:
> [...]
> > I'm afraid our command line is awkward both for machines and for humans,
> > albeit for different reasons.
> >
> > For humans doing simple things, the command line is okay. But beyond
> > that, it gets forbiddingly unwieldy[2].
> >
> > Machines are fine with that kind of unwieldy, but would prefer something
> > with more structure, both on input (talking to QEMU) and even more so on
> > output (QEMU talking back).
> >
> > Ideally, we'd support machines do their work in (structured) QMP,
> > resorting to the command line only to set up a QMP monitor. We're not
> > anywhere close to this.
> >
> > As long as management applications use the command line in not-trivial
> > ways, they have to deal with configuration errors reported via stderr.
>
> That's only true if we want to.
>
> Command line is an interface usable by machines. Not the ideal,
> but it works.
>
> Messages on stderr are not an interface for machines. We must
> provide something better, and I don't think "wait until we
> convert everything to QMP" is a reasonable answer.
If QEMU successfully starts then libvirt essentially ignores stderr
just letting it go to the logfile.
If we see any deprecated features used during startup the natural
thing would be to queue up a list of warnings, and then once the
client (libvirt) connects to QMP emit them as events.
QEMU still ought to emit them on stderr anyway so they do end up
in the logs regardless of whether anyone actually procsses the
deprecation QMP events.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-05-10 17:27 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 21:22 [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP Eduardo Habkost
2019-04-23 21:22 ` Eduardo Habkost
2019-04-23 21:22 ` [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct Eduardo Habkost
2019-04-23 21:22 ` Eduardo Habkost
2019-04-23 22:23 ` Philippe Mathieu-Daudé
2019-04-23 22:23 ` Philippe Mathieu-Daudé
2019-04-24 18:24 ` Eduardo Habkost
2019-04-24 18:24 ` Eduardo Habkost
2019-04-24 8:26 ` Daniel P. Berrangé
2019-04-24 8:26 ` Daniel P. Berrangé
2019-04-24 18:20 ` Eduardo Habkost
2019-04-24 18:20 ` Eduardo Habkost
2019-04-30 10:10 ` Daniel P. Berrangé
2019-04-30 10:10 ` Daniel P. Berrangé
2019-04-30 12:42 ` Eduardo Habkost
2019-04-30 12:42 ` Eduardo Habkost
2019-04-30 12:47 ` Daniel P. Berrangé
2019-04-30 12:47 ` Daniel P. Berrangé
2019-04-25 14:20 ` Wainer dos Santos Moschetta
2019-04-25 14:20 ` Wainer dos Santos Moschetta
2019-04-25 17:42 ` Eduardo Habkost
2019-04-25 17:42 ` Eduardo Habkost
2019-04-30 10:03 ` Daniel P. Berrangé
2019-04-30 10:03 ` Daniel P. Berrangé
2019-04-23 21:22 ` [Qemu-devel] [PATCH 2/3] machine: Use SupportStatusInfo for deprecation info Eduardo Habkost
2019-04-23 21:22 ` Eduardo Habkost
2019-04-23 22:26 ` Philippe Mathieu-Daudé
2019-04-23 22:26 ` Philippe Mathieu-Daudé
2019-04-24 1:37 ` David Gibson
2019-04-24 1:37 ` David Gibson
2019-04-24 8:23 ` Daniel P. Berrangé
2019-04-24 8:23 ` Daniel P. Berrangé
2019-04-24 18:29 ` Eduardo Habkost
2019-04-24 18:29 ` Eduardo Habkost
2019-04-23 21:22 ` [Qemu-devel] [PATCH 3/3] qmp: Add deprecation information to query-machines Eduardo Habkost
2019-04-23 21:22 ` Eduardo Habkost
2019-04-24 8:28 ` Daniel P. Berrangé
2019-04-24 8:28 ` Daniel P. Berrangé
2019-04-25 14:54 ` Wainer dos Santos Moschetta
2019-04-25 14:54 ` Wainer dos Santos Moschetta
2019-04-25 17:43 ` Eduardo Habkost
2019-04-25 17:43 ` Eduardo Habkost
2019-04-23 21:28 ` [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP no-reply
2019-04-23 21:28 ` no-reply
2019-04-24 7:56 ` Thomas Huth
2019-04-24 7:56 ` Thomas Huth
2019-04-24 8:31 ` Daniel P. Berrangé
2019-04-24 8:31 ` Daniel P. Berrangé
2019-04-24 18:14 ` Eduardo Habkost
2019-04-24 18:14 ` Eduardo Habkost
2019-04-24 18:10 ` Eduardo Habkost
2019-04-24 18:10 ` Eduardo Habkost
2019-04-25 7:38 ` Thomas Huth
2019-04-25 7:38 ` Thomas Huth
2019-04-30 10:11 ` Daniel P. Berrangé
2019-04-30 10:11 ` Daniel P. Berrangé
2019-04-24 8:23 ` Michal Privoznik
2019-04-24 8:23 ` Michal Privoznik
2019-05-07 5:07 ` Markus Armbruster
2019-05-07 16:18 ` Eduardo Habkost
2019-05-08 9:16 ` Markus Armbruster
2019-05-08 20:28 ` Eduardo Habkost
2019-05-09 8:31 ` Markus Armbruster
2019-05-09 9:14 ` Daniel P. Berrangé
2019-05-09 15:52 ` Eduardo Habkost
2019-05-09 16:08 ` Daniel P. Berrangé
2019-05-09 17:44 ` Eduardo Habkost
2019-05-10 6:28 ` Markus Armbruster
2019-05-10 17:03 ` Eduardo Habkost
2019-05-10 6:19 ` Markus Armbruster
2019-05-10 17:00 ` Eduardo Habkost
2019-05-09 18:19 ` Eduardo Habkost
2019-05-10 9:29 ` Markus Armbruster
2019-05-10 17:17 ` Eduardo Habkost
2019-05-10 17:26 ` Daniel P. Berrangé [this message]
2019-05-13 11:49 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510172641.GS7671@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).