From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH v6 24/25] target/ppc: Use gen_io_start/end around DARN
Date: Fri, 10 May 2019 10:30:48 -0700 [thread overview]
Message-ID: <20190510173049.28171-25-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190510173049.28171-1-richard.henderson@linaro.org>
Generating a random number counts as I/O, as it cannot be
replayed and produce the same results.
Cc: David Gibson <david@gibson.dropbear.id.au>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/ppc/translate.c | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 8d08625c33..76628df6dd 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -1847,13 +1847,22 @@ static void gen_darn(DisasContext *ctx)
{
int l = L(ctx->opcode);
- if (l == 0) {
- gen_helper_darn32(cpu_gpr[rD(ctx->opcode)]);
- } else if (l <= 2) {
- /* Return 64-bit random for both CRN and RRN */
- gen_helper_darn64(cpu_gpr[rD(ctx->opcode)]);
- } else {
+ if (l > 2) {
tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], -1);
+ } else {
+ if (tb_cflags(ctx->base.tb) & CF_USE_ICOUNT) {
+ gen_io_start();
+ }
+ if (l == 0) {
+ gen_helper_darn32(cpu_gpr[rD(ctx->opcode)]);
+ } else {
+ /* Return 64-bit random for both CRN and RRN */
+ gen_helper_darn64(cpu_gpr[rD(ctx->opcode)]);
+ }
+ if (tb_cflags(ctx->base.tb) & CF_USE_ICOUNT) {
+ gen_io_end();
+ gen_stop_exception(ctx);
+ }
}
}
#endif
--
2.17.1
next prev parent reply other threads:[~2019-05-10 17:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 17:30 [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 01/25] configure: Link test before auto-enabling crypto libraries Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 02/25] crypto: Merge crypto-obj-y into libqemuutil.a Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 03/25] crypto: Reverse code blocks in random-platform.c Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 04/25] crypto: Do not fail for EINTR during qcrypto_random_bytes Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 05/25] crypto: Use O_CLOEXEC in qcrypto_random_init Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 06/25] crypto: Use getrandom for qcrypto_random_bytes Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 07/25] crypto: Change the qcrypto_random_bytes buffer type to void* Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 08/25] ui/vnc: Split out authentication_failed Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 09/25] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 10/25] util: Add qemu_guest_getrandom and associated routines Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 11/25] cpus: Initialize pseudo-random seeds for all guest cpus Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 12/25] linux-user: " Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 13/25] linux-user: Call qcrypto_init if not using -seed Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 14/25] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 15/25] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 16/25] linux-user: Remove srand call Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 17/25] aspeed/scu: Use qemu_guest_getrandom_nofail Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 18/25] hw/misc/nrf51_rng: " Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 19/25] hw/misc/bcm2835_rng: " Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 21/25] target/arm: Put all PAC keys into a structure Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 22/25] target/arm: Implement ARMv8.5-RNG Richard Henderson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 23/25] target/ppc: Use qemu_guest_getrandom for DARN Richard Henderson
2019-05-10 17:30 ` Richard Henderson [this message]
2019-05-13 1:38 ` [Qemu-devel] [PATCH v6 24/25] target/ppc: Use gen_io_start/end around DARN David Gibson
2019-05-13 12:48 ` Laurent Vivier
2019-05-16 1:48 ` David Gibson
2019-05-10 17:30 ` [Qemu-devel] [PATCH v6 25/25] target/i386: Implement CPUID_EXT_RDRAND Richard Henderson
2019-05-14 15:15 ` [Qemu-devel] [PATCH v6 00/25] Add qemu_getrandom and ARMv8.5-RNG etc Markus Armbruster
2019-05-14 15:23 ` Daniel P. Berrangé
2019-05-14 16:14 ` Richard Henderson
2019-05-14 16:50 ` Daniel P. Berrangé
2019-05-14 17:46 ` Richard Henderson
2019-05-14 21:43 ` Eric Blake
2019-05-14 23:22 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510173049.28171-25-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).