From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] monitor: Call mon_get_cpu() only once at hmp_gva2gpa()
Date: Fri, 10 May 2019 20:16:49 +0100 [thread overview]
Message-ID: <20190510191648.GB2895@work-vm> (raw)
In-Reply-To: <ffe6be45-7c22-1264-08f2-faa21ab9db69@linaro.org>
* Richard Henderson (richard.henderson@linaro.org) wrote:
> On 5/10/19 11:56 AM, Eduardo Habkost wrote:
> > hmp_gva2gpa() calls mon_get_cpu() twice, which is unnecessary.
> > Not an actual bug, but this is reported as a defect by Coverity
> > Scan (CID 1401346).
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > monitor.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> I was about to send the same patch. ;-)
I did :-)
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
>
> r~
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-05-10 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 18:56 [Qemu-devel] [PATCH] monitor: Call mon_get_cpu() only once at hmp_gva2gpa() Eduardo Habkost
2019-05-10 19:15 ` Richard Henderson
2019-05-10 19:16 ` Dr. David Alan Gilbert [this message]
2019-05-14 17:13 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510191648.GB2895@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).