From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,T_HK_NAME_DR,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4E0C04A6B for ; Fri, 10 May 2019 19:17:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CFDC217D6 for ; Fri, 10 May 2019 19:17:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CFDC217D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:48868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPB1m-0000Oh-HU for qemu-devel@archiver.kernel.org; Fri, 10 May 2019 15:17:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPB0s-00005M-Rz for qemu-devel@nongnu.org; Fri, 10 May 2019 15:16:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPB0q-00071p-HY for qemu-devel@nongnu.org; Fri, 10 May 2019 15:16:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58814) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hPB0q-00070k-9y for qemu-devel@nongnu.org; Fri, 10 May 2019 15:16:56 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F3574307D849; Fri, 10 May 2019 19:16:54 +0000 (UTC) Received: from work-vm (ovpn-117-163.ams2.redhat.com [10.36.117.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B59DF22711; Fri, 10 May 2019 19:16:51 +0000 (UTC) Date: Fri, 10 May 2019 20:16:49 +0100 From: "Dr. David Alan Gilbert" To: Richard Henderson Message-ID: <20190510191648.GB2895@work-vm> References: <20190510185620.15757-1-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 10 May 2019 19:16:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] monitor: Call mon_get_cpu() only once at hmp_gva2gpa() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , Eduardo Habkost , Stefan Hajnoczi , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Richard Henderson (richard.henderson@linaro.org) wrote: > On 5/10/19 11:56 AM, Eduardo Habkost wrote: > > hmp_gva2gpa() calls mon_get_cpu() twice, which is unnecessary. > > Not an actual bug, but this is reported as a defect by Coverity > > Scan (CID 1401346). > > > > Signed-off-by: Eduardo Habkost > > --- > > monitor.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Reviewed-by: Richard Henderson > > I was about to send the same patch. ;-) I did :-) Reviewed-by: Dr. David Alan Gilbert > > > r~ > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK