From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A78C04AB4 for ; Tue, 14 May 2019 08:10:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 897332084A for ; Tue, 14 May 2019 08:10:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 897332084A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:41586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQSW3-0007hr-8s for qemu-devel@archiver.kernel.org; Tue, 14 May 2019 04:10:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQSUm-00072J-M4 for qemu-devel@nongnu.org; Tue, 14 May 2019 04:09:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQSUk-0001xn-Oj for qemu-devel@nongnu.org; Tue, 14 May 2019 04:09:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54230) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQSUi-0001pT-QB for qemu-devel@nongnu.org; Tue, 14 May 2019 04:09:06 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 28DEB88318; Tue, 14 May 2019 08:09:01 +0000 (UTC) Received: from paraplu.localdomain (ovpn-117-140.ams2.redhat.com [10.36.117.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F2F87608AC; Tue, 14 May 2019 08:08:55 +0000 (UTC) Received: by paraplu.localdomain (Postfix, from userid 1001) id 8503A3E0060; Tue, 14 May 2019 10:08:54 +0200 (CEST) Date: Tue, 14 May 2019 10:08:54 +0200 From: Kashyap Chamarthy To: Laurent Vivier Message-ID: <20190514080854.GD17214@paraplu> References: <20190514075602.7674-1-lvivier@redhat.com> <20190514075602.7674-2-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190514075602.7674-2-lvivier@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 14 May 2019 08:09:01 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v4 1/3] VirtIO-RNG: Update default entropy source to `/dev/urandom` X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , "Michael S. Tsirkin" , Markus Armbruster , Amit Shah , Richard Henderson , "Richard W . M . Jones" , qemu-devel@nongnu.org, Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, May 14, 2019 at 09:56:00AM +0200, Laurent Vivier wrote: > From: Kashyap Chamarthy > > When QEMU exposes a VirtIO-RNG device to the guest, that device needs a > source of entropy, and that source needs to be "non-blocking", like > `/dev/urandom`. However, currently QEMU defaults to the problematic > `/dev/random`, which on linux is "blocking" (as in, it waits until OCD nit: s/linux/Linux/ Maybe Michael can do the touch up when applying. Thanks, Laurent, for reworking the commit message update. > sufficient entropy is available). [...] -- /kashyap