* Re: [Qemu-devel] [PATCH] migration: not necessary to check ops again
[not found] <20190327013130.26259-1-richardw.yang@linux.intel.com>
@ 2019-05-14 11:26 ` Dr. David Alan Gilbert
0 siblings, 0 replies; only message in thread
From: Dr. David Alan Gilbert @ 2019-05-14 11:26 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, quintela
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> During each iteration, se->ops is checked before each loop. So it is not
> necessary to check it again and simplify the following check a little.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Queued
> ---
> migration/savevm.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 1415001d1c..5f0ca7fac2 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1157,15 +1157,13 @@ int qemu_savevm_state_iterate(QEMUFile *f, bool postcopy)
> if (!se->ops || !se->ops->save_live_iterate) {
> continue;
> }
> - if (se->ops && se->ops->is_active) {
> - if (!se->ops->is_active(se->opaque)) {
> - continue;
> - }
> + if (se->ops->is_active &&
> + !se->ops->is_active(se->opaque)) {
> + continue;
> }
> - if (se->ops && se->ops->is_active_iterate) {
> - if (!se->ops->is_active_iterate(se->opaque)) {
> - continue;
> - }
> + if (se->ops->is_active_iterate &&
> + !se->ops->is_active_iterate(se->opaque)) {
> + continue;
> }
> /*
> * In the postcopy phase, any device that doesn't know how to
> --
> 2.19.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-14 11:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190327013130.26259-1-richardw.yang@linux.intel.com>
2019-05-14 11:26 ` [Qemu-devel] [PATCH] migration: not necessary to check ops again Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).