From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,T_HK_NAME_DR, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C40C04AB4 for ; Tue, 14 May 2019 11:37:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2967D208CA for ; Tue, 14 May 2019 11:37:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2967D208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:46103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQVk0-0000UJ-Dm for qemu-devel@archiver.kernel.org; Tue, 14 May 2019 07:37:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQVaA-0001YU-8R for qemu-devel@nongnu.org; Tue, 14 May 2019 07:26:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQVa9-0005pG-41 for qemu-devel@nongnu.org; Tue, 14 May 2019 07:26:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8180) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQVa8-0005oZ-UU for qemu-devel@nongnu.org; Tue, 14 May 2019 07:26:53 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E934D3082B40; Tue, 14 May 2019 11:26:51 +0000 (UTC) Received: from work-vm (ovpn-117-232.ams2.redhat.com [10.36.117.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1DA84608BB; Tue, 14 May 2019 11:26:50 +0000 (UTC) Date: Tue, 14 May 2019 12:26:48 +0100 From: "Dr. David Alan Gilbert" To: Wei Yang Message-ID: <20190514112648.GC8632@work-vm> References: <20190327013130.26259-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190327013130.26259-1-richardw.yang@linux.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 14 May 2019 11:26:51 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] migration: not necessary to check ops again X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Wei Yang (richardw.yang@linux.intel.com) wrote: > During each iteration, se->ops is checked before each loop. So it is not > necessary to check it again and simplify the following check a little. > > Signed-off-by: Wei Yang Queued > --- > migration/savevm.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/migration/savevm.c b/migration/savevm.c > index 1415001d1c..5f0ca7fac2 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -1157,15 +1157,13 @@ int qemu_savevm_state_iterate(QEMUFile *f, bool postcopy) > if (!se->ops || !se->ops->save_live_iterate) { > continue; > } > - if (se->ops && se->ops->is_active) { > - if (!se->ops->is_active(se->opaque)) { > - continue; > - } > + if (se->ops->is_active && > + !se->ops->is_active(se->opaque)) { > + continue; > } > - if (se->ops && se->ops->is_active_iterate) { > - if (!se->ops->is_active_iterate(se->opaque)) { > - continue; > - } > + if (se->ops->is_active_iterate && > + !se->ops->is_active_iterate(se->opaque)) { > + continue; > } > /* > * In the postcopy phase, any device that doesn't know how to > -- > 2.19.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK