* Re: [Qemu-devel] [PATCH] migration: remove not used field xfer_limit [not found] ` <20190401031034.GA4680@richard> @ 2019-04-01 8:51 ` Dr. David Alan Gilbert 2019-04-01 14:03 ` Wei Yang 0 siblings, 1 reply; 3+ messages in thread From: Dr. David Alan Gilbert @ 2019-04-01 8:51 UTC (permalink / raw) To: Wei Yang; +Cc: qemu-devel, quintela * Wei Yang (richardw.yang@linux.intel.com) wrote: > On Wed, Mar 27, 2019 at 08:24:21PM +0000, Dr. David Alan Gilbert wrote: > >* Wei Yang (richardw.yang@linux.intel.com) wrote: > >> MigrationState->xfer_limit is only set to 0 in migrate_init(). > >> > >> Remove this unnecessary field. > >> > >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > > > >Nice; I think that field has been unneeded since 1964a397063967 > >just over 5 years ago :-) > > > > Hi, David, > > I found xfer_limit has an orphan brother, bytes_xfer. > > Do you want me to send a separate patch or spin v2 to adopt these two > together? Either is fine; since we're in 4.0 freeze at the moment, either way it wont get merged for a few weeks. Dave > > > >Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > > >> --- > >> migration/migration.c | 1 - > >> migration/migration.h | 1 - > >> 2 files changed, 2 deletions(-) > >> > >> diff --git a/migration/migration.c b/migration/migration.c > >> index e88acab53b..533c2102c7 100644 > >> --- a/migration/migration.c > >> +++ b/migration/migration.c > >> @@ -1682,7 +1682,6 @@ void migrate_init(MigrationState *s) > >> * locks. > >> */ > >> s->bytes_xfer = 0; > >> - s->xfer_limit = 0; > >> s->cleanup_bh = 0; > >> s->to_dst_file = NULL; > >> s->rp_state.from_dst_file = NULL; > >> diff --git a/migration/migration.h b/migration/migration.h > >> index 99e99e56bd..852eb3c4e9 100644 > >> --- a/migration/migration.h > >> +++ b/migration/migration.h > >> @@ -117,7 +117,6 @@ struct MigrationState > >> > >> /*< public >*/ > >> size_t bytes_xfer; > >> - size_t xfer_limit; > >> QemuThread thread; > >> QEMUBH *cleanup_bh; > >> QEMUFile *to_dst_file; > >> -- > >> 2.19.1 > >> > >-- > >Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > -- > Wei Yang > Help you, Help me -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: remove not used field xfer_limit 2019-04-01 8:51 ` [Qemu-devel] [PATCH] migration: remove not used field xfer_limit Dr. David Alan Gilbert @ 2019-04-01 14:03 ` Wei Yang 0 siblings, 0 replies; 3+ messages in thread From: Wei Yang @ 2019-04-01 14:03 UTC (permalink / raw) To: Dr. David Alan Gilbert; +Cc: Wei Yang, qemu-devel, quintela On Mon, Apr 01, 2019 at 09:51:55AM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.yang@linux.intel.com) wrote: >> On Wed, Mar 27, 2019 at 08:24:21PM +0000, Dr. David Alan Gilbert wrote: >> >* Wei Yang (richardw.yang@linux.intel.com) wrote: >> >> MigrationState->xfer_limit is only set to 0 in migrate_init(). >> >> >> >> Remove this unnecessary field. >> >> >> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> >> > >> >Nice; I think that field has been unneeded since 1964a397063967 >> >just over 5 years ago :-) >> > >> >> Hi, David, >> >> I found xfer_limit has an orphan brother, bytes_xfer. >> >> Do you want me to send a separate patch or spin v2 to adopt these two >> together? > >Either is fine; since we're in 4.0 freeze at the moment, either way it >wont get merged for a few weeks. > Got it, thanks :-) >Dave -- Wei Yang Help you, Help me ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: remove not used field xfer_limit [not found] ` <20190327202421.GH2636@work-vm> [not found] ` <20190401031034.GA4680@richard> @ 2019-05-14 13:31 ` Dr. David Alan Gilbert 1 sibling, 0 replies; 3+ messages in thread From: Dr. David Alan Gilbert @ 2019-05-14 13:31 UTC (permalink / raw) To: Wei Yang; +Cc: qemu-devel, quintela * Dr. David Alan Gilbert (dgilbert@redhat.com) wrote: > * Wei Yang (richardw.yang@linux.intel.com) wrote: > > MigrationState->xfer_limit is only set to 0 in migrate_init(). > > > > Remove this unnecessary field. > > > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > > Nice; I think that field has been unneeded since 1964a397063967 > just over 5 years ago :-) > > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Queued > > > --- > > migration/migration.c | 1 - > > migration/migration.h | 1 - > > 2 files changed, 2 deletions(-) > > > > diff --git a/migration/migration.c b/migration/migration.c > > index e88acab53b..533c2102c7 100644 > > --- a/migration/migration.c > > +++ b/migration/migration.c > > @@ -1682,7 +1682,6 @@ void migrate_init(MigrationState *s) > > * locks. > > */ > > s->bytes_xfer = 0; > > - s->xfer_limit = 0; > > s->cleanup_bh = 0; > > s->to_dst_file = NULL; > > s->rp_state.from_dst_file = NULL; > > diff --git a/migration/migration.h b/migration/migration.h > > index 99e99e56bd..852eb3c4e9 100644 > > --- a/migration/migration.h > > +++ b/migration/migration.h > > @@ -117,7 +117,6 @@ struct MigrationState > > > > /*< public >*/ > > size_t bytes_xfer; > > - size_t xfer_limit; > > QemuThread thread; > > QEMUBH *cleanup_bh; > > QEMUFile *to_dst_file; > > -- > > 2.19.1 > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-14 13:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190326055726.10539-1-richardw.yang@linux.intel.com>
[not found] ` <20190327202421.GH2636@work-vm>
[not found] ` <20190401031034.GA4680@richard>
2019-04-01 8:51 ` [Qemu-devel] [PATCH] migration: remove not used field xfer_limit Dr. David Alan Gilbert
2019-04-01 14:03 ` Wei Yang
2019-05-14 13:31 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).