[Qemu-devel] [PATCH] migration/ram.c: fix typos in comments

[Qemu-devel] [PATCH] migration/ram.c: fix typos in comments

[Wei Yang]

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 migration/ram.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/migration/ram.c b/migration/ram.c
index 1def8122e9..720c2b73ca 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -888,7 +888,7 @@ struct {
  *    - to make easier to know what to free at the end of migration
  *
  * This way we always know who is the owner of each "pages" struct,
- * and we don't need any loocking.  It belongs to the migration thread
+ * and we don't need any locking.  It belongs to the migration thread
  * or to the channel thread.  Switching is safe because the migration
  * thread is using the channel mutex when changing it, and the channel
  * have to had finish with its own, otherwise pending_job can't be
@@ -1594,7 +1594,7 @@ static int save_xbzrle_page(RAMState *rs, uint8_t **current_data,
  *
  * Called with rcu_read_lock() to protect migration_bitmap
  *
- * Returns the byte offset within memory region of the start of a dirty page
+ * Returns the page offset within memory region of the start of a dirty page
  *
  * @rs: current RAM state
  * @rb: RAMBlock where to search for dirty pages
@@ -2108,7 +2108,7 @@ retry:
  * find_dirty_block: find the next dirty page and update any state
  * associated with the search process.
  *
- * Returns if a page is found
+ * Returns true if a page is found
  *
  * @rs: current RAM state
  * @pss: data about the state of the current dirty page scan
@@ -2204,7 +2204,7 @@ static RAMBlock *unqueue_page(RAMState *rs, ram_addr_t *offset)
  *
  * Skips pages that are already sent (!dirty)
  *
- * Returns if a queued page is found
+ * Returns true if a queued page is found
  *
  * @rs: current RAM state
  * @pss: data about the state of the current dirty page scan
@@ -3411,7 +3411,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
 
         /* we want to check in the 1st loop, just in case it was the 1st time
            and we had to sync the dirty bitmap.
-           qemu_get_clock_ns() is a bit expensive, so we only check each some
+           qemu_clock_get_ns() is a bit expensive, so we only check each some
            iterations
         */
         if ((i & 63) == 0) {
-- 
2.19.1

Re: [Qemu-devel] [PATCH] migration/ram.c: fix typos in comments

[Dr. David Alan Gilbert]

* Wei Yang (richardw.yang@linux.intel.com) wrote:
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
>  migration/ram.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

and queued.

> diff --git a/migration/ram.c b/migration/ram.c
> index 1def8122e9..720c2b73ca 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -888,7 +888,7 @@ struct {
>   *    - to make easier to know what to free at the end of migration
>   *
>   * This way we always know who is the owner of each "pages" struct,
> - * and we don't need any loocking.  It belongs to the migration thread
> + * and we don't need any locking.  It belongs to the migration thread
>   * or to the channel thread.  Switching is safe because the migration
>   * thread is using the channel mutex when changing it, and the channel
>   * have to had finish with its own, otherwise pending_job can't be
> @@ -1594,7 +1594,7 @@ static int save_xbzrle_page(RAMState *rs, uint8_t **current_data,
>   *
>   * Called with rcu_read_lock() to protect migration_bitmap
>   *
> - * Returns the byte offset within memory region of the start of a dirty page
> + * Returns the page offset within memory region of the start of a dirty page
>   *
>   * @rs: current RAM state
>   * @rb: RAMBlock where to search for dirty pages
> @@ -2108,7 +2108,7 @@ retry:
>   * find_dirty_block: find the next dirty page and update any state
>   * associated with the search process.
>   *
> - * Returns if a page is found
> + * Returns true if a page is found
>   *
>   * @rs: current RAM state
>   * @pss: data about the state of the current dirty page scan
> @@ -2204,7 +2204,7 @@ static RAMBlock *unqueue_page(RAMState *rs, ram_addr_t *offset)
>   *
>   * Skips pages that are already sent (!dirty)
>   *
> - * Returns if a queued page is found
> + * Returns true if a queued page is found
>   *
>   * @rs: current RAM state
>   * @pss: data about the state of the current dirty page scan
> @@ -3411,7 +3411,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
>  
>          /* we want to check in the 1st loop, just in case it was the 1st time
>             and we had to sync the dirty bitmap.
> -           qemu_get_clock_ns() is a bit expensive, so we only check each some
> +           qemu_clock_get_ns() is a bit expensive, so we only check each some
>             iterations
>          */
>          if ((i & 63) == 0) {
> -- 
> 2.19.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK