From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95C0AC04E53 for ; Wed, 15 May 2019 08:08:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67EAD20862 for ; Wed, 15 May 2019 08:08:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67EAD20862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:33155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQoxY-0000og-Mi for qemu-devel@archiver.kernel.org; Wed, 15 May 2019 04:08:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQowm-0000Sr-4H for qemu-devel@nongnu.org; Wed, 15 May 2019 04:07:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQowl-0000h1-6V for qemu-devel@nongnu.org; Wed, 15 May 2019 04:07:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39938) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQowi-0000bw-TU; Wed, 15 May 2019 04:07:29 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2F2E1307D840; Wed, 15 May 2019 08:07:28 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-220.ams2.redhat.com [10.36.116.220]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 07823608BB; Wed, 15 May 2019 08:07:23 +0000 (UTC) Date: Wed, 15 May 2019 10:07:22 +0200 From: Kevin Wolf To: Vladimir Sementsov-Ogievskiy Message-ID: <20190515080722.GA7508@localhost.localdomain> References: <20190124122525.145968-1-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190124122525.145968-1-vsementsov@virtuozzo.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 15 May 2019 08:07:28 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 0/2] fix qmp-cont vs migration-finish race-crash X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, mreitz@redhat.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 24.01.2019 um 13:25 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi. > > It's a simple fix for problems reported in "Aborts in iotest 169" > by Max: > https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg05907.html > > In thread Kevin described that a problem itself is bigger and needs > more effort: > https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06136.html > > So, we may continue discussion in "Aborts in iotest 169", and in > parallel apply these patches at least as a temporary fix. > > The problem of this fix is that we finally have a bit weird interface: > > User gets event MIGRATION_COMPLETED, and after it he can get error > message "Migration is not finalized yet". > > But it is better than crash, anyway. Thanks, applied to the block branch. Kevin