* [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message
@ 2019-05-15 9:08 Stefano Garzarella
2019-05-15 12:33 ` Markus Armbruster
2019-05-17 8:28 ` Jason Wang
0 siblings, 2 replies; 5+ messages in thread
From: Stefano Garzarella @ 2019-05-15 9:08 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Jan Kiszka, Jason Wang, Markus Armbruster,
Samuel Thibault, Marc-André Lureau
Reword and add a missing parentheses at the end of the
error message.
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
v2:
- Reworded the error message (Markus)
- Added Marc-André's R-b
I made a little change to the error message, let me now
if I should remove yuor R-b.
---
net/slirp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/slirp.c b/net/slirp.c
index 95934fb36d..b34cb29276 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -498,7 +498,8 @@ static int net_slirp_init(NetClientState *peer, const char *model,
}
if (vprefix6_len < 0 || vprefix6_len > 126) {
error_setg(errp,
- "Invalid prefix provided (prefix len must be in range 0-126");
+ "Invalid IPv6 prefix provided "
+ "(IPv6 prefix length must be between 0 and 126)");
return -1;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message
2019-05-15 9:08 [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message Stefano Garzarella
@ 2019-05-15 12:33 ` Markus Armbruster
2019-05-15 13:01 ` Stefano Garzarella
2019-05-17 8:28 ` Jason Wang
1 sibling, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2019-05-15 12:33 UTC (permalink / raw)
To: Stefano Garzarella
Cc: qemu-trivial, Jan Kiszka, Jason Wang, qemu-devel, Samuel Thibault,
Marc-André Lureau
Stefano Garzarella <sgarzare@redhat.com> writes:
> Reword and add a missing parentheses at the end of the
> error message.
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> v2:
> - Reworded the error message (Markus)
> - Added Marc-André's R-b
> I made a little change to the error message, let me now
> if I should remove yuor R-b.
> ---
> net/slirp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index 95934fb36d..b34cb29276 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -498,7 +498,8 @@ static int net_slirp_init(NetClientState *peer, const char *model,
> }
> if (vprefix6_len < 0 || vprefix6_len > 126) {
> error_setg(errp,
> - "Invalid prefix provided (prefix len must be in range 0-126");
> + "Invalid IPv6 prefix provided "
> + "(IPv6 prefix length must be between 0 and 126)");
> return -1;
> }
"Parameter 'ipv6-prefixlen' expects a value between 0 and 126" would be
closer to how we report similar errors elsewhere.
Regardless:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message
2019-05-15 12:33 ` Markus Armbruster
@ 2019-05-15 13:01 ` Stefano Garzarella
2019-05-15 16:17 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 5+ messages in thread
From: Stefano Garzarella @ 2019-05-15 13:01 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu-trivial, Jan Kiszka, Jason Wang, qemu-devel, Samuel Thibault,
Marc-André Lureau
On Wed, May 15, 2019 at 02:33:03PM +0200, Markus Armbruster wrote:
> Stefano Garzarella <sgarzare@redhat.com> writes:
>
> > Reword and add a missing parentheses at the end of the
> > error message.
> >
> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > v2:
> > - Reworded the error message (Markus)
> > - Added Marc-André's R-b
> > I made a little change to the error message, let me now
> > if I should remove yuor R-b.
> > ---
> > net/slirp.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/net/slirp.c b/net/slirp.c
> > index 95934fb36d..b34cb29276 100644
> > --- a/net/slirp.c
> > +++ b/net/slirp.c
> > @@ -498,7 +498,8 @@ static int net_slirp_init(NetClientState *peer, const char *model,
> > }
> > if (vprefix6_len < 0 || vprefix6_len > 126) {
> > error_setg(errp,
> > - "Invalid prefix provided (prefix len must be in range 0-126");
> > + "Invalid IPv6 prefix provided "
> > + "(IPv6 prefix length must be between 0 and 126)");
> > return -1;
> > }
>
> "Parameter 'ipv6-prefixlen' expects a value between 0 and 126" would be
> closer to how we report similar errors elsewhere.
This error is shown when 'ipv6-net' or 'ipv6-prefixlen' parameters are
used, so I preferred to leave a more generic error to fit both cases.
>
> Regardless:
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Thanks,
Stefano
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message
2019-05-15 13:01 ` Stefano Garzarella
@ 2019-05-15 16:17 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-15 16:17 UTC (permalink / raw)
To: Stefano Garzarella, Markus Armbruster
Cc: qemu-trivial, Jan Kiszka, Jason Wang, qemu-devel, Samuel Thibault,
Marc-André Lureau
On 5/15/19 3:01 PM, Stefano Garzarella wrote:
> On Wed, May 15, 2019 at 02:33:03PM +0200, Markus Armbruster wrote:
>> Stefano Garzarella <sgarzare@redhat.com> writes:
>>
>>> Reword and add a missing parentheses at the end of the
>>> error message.
>>>
>>> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>>> ---
>>> v2:
>>> - Reworded the error message (Markus)
>>> - Added Marc-André's R-b
>>> I made a little change to the error message, let me now
>>> if I should remove yuor R-b.
>>> ---
>>> net/slirp.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/net/slirp.c b/net/slirp.c
>>> index 95934fb36d..b34cb29276 100644
>>> --- a/net/slirp.c
>>> +++ b/net/slirp.c
>>> @@ -498,7 +498,8 @@ static int net_slirp_init(NetClientState *peer, const char *model,
>>> }
>>> if (vprefix6_len < 0 || vprefix6_len > 126) {
>>> error_setg(errp,
>>> - "Invalid prefix provided (prefix len must be in range 0-126");
>>> + "Invalid IPv6 prefix provided "
>>> + "(IPv6 prefix length must be between 0 and 126)");
>>> return -1;
>>> }
>>
>> "Parameter 'ipv6-prefixlen' expects a value between 0 and 126" would be
>> closer to how we report similar errors elsewhere.
>
> This error is shown when 'ipv6-net' or 'ipv6-prefixlen' parameters are
> used, so I preferred to leave a more generic error to fit both cases.
>
>>
>> Regardless:
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message
2019-05-15 9:08 [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message Stefano Garzarella
2019-05-15 12:33 ` Markus Armbruster
@ 2019-05-17 8:28 ` Jason Wang
1 sibling, 0 replies; 5+ messages in thread
From: Jason Wang @ 2019-05-17 8:28 UTC (permalink / raw)
To: Stefano Garzarella, qemu-devel
Cc: qemu-trivial, Jan Kiszka, Markus Armbruster,
Marc-André Lureau, Samuel Thibault
On 2019/5/15 下午5:08, Stefano Garzarella wrote:
> Reword and add a missing parentheses at the end of the
> error message.
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> v2:
> - Reworded the error message (Markus)
> - Added Marc-André's R-b
> I made a little change to the error message, let me now
> if I should remove yuor R-b.
> ---
> net/slirp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index 95934fb36d..b34cb29276 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -498,7 +498,8 @@ static int net_slirp_init(NetClientState *peer, const char *model,
> }
> if (vprefix6_len < 0 || vprefix6_len > 126) {
> error_setg(errp,
> - "Invalid prefix provided (prefix len must be in range 0-126");
> + "Invalid IPv6 prefix provided "
> + "(IPv6 prefix length must be between 0 and 126)");
> return -1;
> }
>
Applied.
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-17 8:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-15 9:08 [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message Stefano Garzarella
2019-05-15 12:33 ` Markus Armbruster
2019-05-15 13:01 ` Stefano Garzarella
2019-05-15 16:17 ` Philippe Mathieu-Daudé
2019-05-17 8:28 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).