From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/8] WIP: Multifd compression support
Date: Wed, 15 May 2019 14:15:36 +0200 [thread overview]
Message-ID: <20190515121544.4597-1-quintela@redhat.com> (raw)
v3:
- improve the code
- address David and Markus comments
- make compression code into methods
so we can add any other method ading just three functions
Please review, as far as I know everything is ok now.
Todo: Add zstd support
v2:
- improve the code left and right
- Split better the zlib code
- rename everything to v4.1
- Add tests for multifd-compress zlib
- Parameter is now an enum (soon will see sztd)
ToDo:
- Make operations for diferent methods:
* multifd_prepare_send_none/zlib
* multifd_send_none/zlib
* multifd_recv_none/zlib
- Use the MULTIFD_FLAG_ZLIB (it is unused so far).
Please review and comment.
v1:
This series create compression code on top of multifd. It is still
WIP, but it is already:
- faster that current compression code
- it does the minimum amount of copies possible
- we allow support for other compression codes
- it pass the multifd test sent in my previous series
Test for existing code didn't work because code is too slow, I need to
make downtime 10 times bigger to make it to converge on my test
machine. This code works with same limits that multifd no-
ToDo:
- move printf's to traces
- move code to a struct instead of if (zlib) inside the main threads.
- improve error handling.
Please, review and coment.
Juan Quintela (8):
migration: fix multifd_recv event typo
migration-test: rename parameter to parameter_int
tests: Add migration multifd test
migration-test: introduce functions to handle string parameters
migration: Add multifd-compress parameter
migration: Make none operations into its own structure
multifd: Add zlib compression support
multifd: rest of zlib compression
hmp.c | 17 +++
hw/core/qdev-properties.c | 13 +++
include/hw/qdev-properties.h | 1 +
migration/migration.c | 25 +++++
migration/migration.h | 1 +
migration/ram.c | 203 ++++++++++++++++++++++++++++++++++-
migration/trace-events | 2 +-
qapi/migration.json | 30 +++++-
tests/migration-test.c | 147 ++++++++++++++++++++-----
9 files changed, 406 insertions(+), 33 deletions(-)
--
2.21.0
next reply other threads:[~2019-05-15 12:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 12:15 Juan Quintela [this message]
2019-05-15 12:15 ` [Qemu-devel] [PATCH v3 1/8] migration: fix multifd_recv event typo Juan Quintela
2019-05-17 17:25 ` Dr. David Alan Gilbert
2019-05-20 6:38 ` Wei Yang
2019-05-15 12:15 ` [Qemu-devel] [PATCH v3 2/8] migration-test: rename parameter to parameter_int Juan Quintela
2019-05-20 6:43 ` Wei Yang
2019-05-15 12:15 ` [Qemu-devel] [PATCH v3 3/8] tests: Add migration multifd test Juan Quintela
2019-05-20 2:03 ` Wei Yang
2019-06-10 9:20 ` Juan Quintela
2019-05-20 6:48 ` Wei Yang
2019-06-10 9:23 ` Juan Quintela
2019-05-15 12:15 ` [Qemu-devel] [PATCH v3 4/8] migration-test: introduce functions to handle string parameters Juan Quintela
2019-05-15 12:15 ` [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter Juan Quintela
2019-05-15 15:34 ` Markus Armbruster
2019-06-10 9:38 ` Juan Quintela
2019-05-20 7:11 ` Wei Yang
2019-06-10 9:41 ` Juan Quintela
2019-05-20 12:53 ` Wei Yang
2019-06-10 9:42 ` Juan Quintela
2019-05-20 21:32 ` Wei Yang
2019-06-10 9:45 ` Juan Quintela
2019-05-15 12:15 ` [Qemu-devel] [PATCH v3 6/8] migration: Make none operations into its own structure Juan Quintela
2019-05-21 2:47 ` Wei Yang
2019-06-10 9:54 ` Juan Quintela
2019-05-29 16:34 ` Dr. David Alan Gilbert
2019-06-10 9:54 ` Juan Quintela
2019-06-12 11:54 ` Juan Quintela
2019-05-15 12:15 ` [Qemu-devel] [PATCH v3 7/8] multifd: Add zlib compression support Juan Quintela
2019-05-21 3:07 ` Wei Yang
2019-06-11 16:50 ` Juan Quintela
2019-05-29 16:48 ` Dr. David Alan Gilbert
2019-06-11 16:46 ` Juan Quintela
2019-05-15 12:15 ` [Qemu-devel] [PATCH v3 8/8] multifd: rest of zlib compression Juan Quintela
2019-05-21 3:11 ` Wei Yang
2019-06-11 16:54 ` Juan Quintela
2019-05-29 17:15 ` Dr. David Alan Gilbert
2019-06-12 8:33 ` Juan Quintela
2019-05-20 6:35 ` [Qemu-devel] [PATCH v3 0/8] WIP: Multifd compression support Wei Yang
2019-06-10 14:27 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515121544.4597-1-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).