From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: lvivier@redhat.com, berrange@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH v8 13/25] linux-user: Call qcrypto_init if not using -seed
Date: Thu, 16 May 2019 19:39:12 -0700 [thread overview]
Message-ID: <20190517023924.1686-14-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190517023924.1686-1-richard.henderson@linaro.org>
When not using -seed, we will use the crypto subsystem
for random numbers.
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/main.c | 28 +++++++++++++++++++---------
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index 7e704845c0..66c909a1a6 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -39,6 +39,7 @@
#include "trace/control.h"
#include "target_elf.h"
#include "cpu_loop-common.h"
+#include "crypto/init.h"
char *exec_path;
@@ -688,17 +689,26 @@ int main(int argc, char **argv, char **envp)
if (seed_optarg == NULL) {
seed_optarg = getenv("QEMU_RAND_SEED");
}
- if (seed_optarg != NULL) {
- unsigned long long seed;
+ {
+ Error *err = NULL;
+ if (seed_optarg != NULL) {
+ unsigned long long seed;
- /* This will go away with the last user of rand(). */
- if (parse_uint_full(seed_optarg, &seed, 0) != 0) {
- fprintf(stderr, "Invalid seed number: %s\n", seed_optarg);
- exit(EXIT_FAILURE);
+ /* This will go away with the last user of rand(). */
+ if (parse_uint_full(seed_optarg, &seed, 0) != 0) {
+ fprintf(stderr, "Invalid seed number: %s\n", seed_optarg);
+ exit(EXIT_FAILURE);
+ }
+ srand(seed);
+
+ qemu_guest_random_seed_main(seed_optarg, &err);
+ } else {
+ qcrypto_init(&err);
+ }
+ if (err) {
+ error_reportf_err(err, "cannot initialize crypto: ");
+ exit(1);
}
- srand(seed);
-
- qemu_guest_random_seed_main(seed_optarg, &error_fatal);
}
target_environ = envlist_to_environ(envlist, NULL);
--
2.17.1
next prev parent reply other threads:[~2019-05-17 2:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 2:38 [Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 01/25] configure: Link test before auto-enabling crypto libraries Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 02/25] build: Link user-only with crypto random number objects Richard Henderson
2019-05-21 15:04 ` Daniel P. Berrangé
2019-05-22 10:52 ` Richard Henderson
2019-05-22 10:56 ` Daniel P. Berrangé
2019-05-22 10:58 ` Richard Henderson
2019-05-22 11:36 ` Laurent Vivier
2019-05-22 10:56 ` Daniel P. Berrangé
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 03/25] crypto: Reverse code blocks in random-platform.c Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 04/25] crypto: Do not fail for EINTR during qcrypto_random_bytes Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 05/25] crypto: Use O_CLOEXEC in qcrypto_random_init Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 06/25] crypto: Use getrandom for qcrypto_random_bytes Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 07/25] crypto: Change the qcrypto_random_bytes buffer type to void* Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 08/25] ui/vnc: Split out authentication_failed Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 09/25] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 10/25] util: Add qemu_guest_getrandom and associated routines Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 11/25] cpus: Initialize pseudo-random seeds for all guest cpus Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 12/25] linux-user: " Richard Henderson
2019-05-17 2:39 ` Richard Henderson [this message]
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 14/25] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 15/25] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 16/25] linux-user: Remove srand call Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 17/25] aspeed/scu: Use qemu_guest_getrandom_nofail Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 18/25] hw/misc/nrf51_rng: " Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 19/25] hw/misc/bcm2835_rng: " Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 21/25] target/arm: Put all PAC keys into a structure Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 22/25] target/arm: Implement ARMv8.5-RNG Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 23/25] target/ppc: Use gen_io_start/end around DARN Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 24/25] target/ppc: Use qemu_guest_getrandom for DARN Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 25/25] target/i386: Implement CPUID_EXT_RDRAND Richard Henderson
2019-05-22 10:58 ` [Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc Daniel P. Berrangé
2019-05-22 11:37 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517023924.1686-14-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).