From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 1/4] iotests: Add -display none to the qemu options
Date: Fri, 17 May 2019 11:56:25 +0200 [thread overview]
Message-ID: <20190517095628.10119-2-mreitz@redhat.com> (raw)
In-Reply-To: <20190517095628.10119-1-mreitz@redhat.com>
Without this argument, qemu will print an angry message about not being
able to connect to a display server if $DISPLAY is not set. For me,
that breaks iotests.supported_formats() because it thus only sees
["Could", "not", "connect"] as the supported formats.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/check | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index f9c24b6753..d6fec4bf3c 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -130,7 +130,7 @@ export CACHEMODE="writeback"
export QEMU_IO_OPTIONS=""
export QEMU_IO_OPTIONS_NO_FMT=""
export CACHEMODE_IS_DEFAULT=true
-export QEMU_OPTIONS="-nodefaults -machine accel=qtest"
+export QEMU_OPTIONS="-nodefaults -machine accel=qtest -display none"
export VALGRIND_QEMU=
export IMGKEYSECRET=
export IMGOPTSSYNTAX=false
--
2.21.0
next prev parent reply other threads:[~2019-05-17 10:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 9:56 [Qemu-devel] [PATCH 0/4] iotests: Selfish patches Max Reitz
2019-05-17 9:56 ` Max Reitz [this message]
2019-05-17 10:23 ` [Qemu-devel] [PATCH 1/4] iotests: Add -display none to the qemu options Thomas Huth
2019-05-17 10:30 ` Alex Bennée
2019-05-17 9:56 ` [Qemu-devel] [PATCH 2/4] iotests: Prefer null-co over null-aio Max Reitz
2019-05-17 9:56 ` [Qemu-devel] [PATCH 3/4] iotests: Test driver whitelisting in 093 Max Reitz
2019-05-17 11:00 ` Kevin Wolf
2019-05-17 11:44 ` Max Reitz
2019-05-17 9:56 ` [Qemu-devel] [PATCH 4/4] iotests: Test driver whitelisting in 136 Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517095628.10119-2-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).