From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C30C04AB4 for ; Fri, 17 May 2019 11:24:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16D542087B for ; Fri, 17 May 2019 11:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16D542087B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:46875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRay7-0002YN-1Q for qemu-devel@archiver.kernel.org; Fri, 17 May 2019 07:24:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRalz-0002eq-96 for qemu-devel@nongnu.org; Fri, 17 May 2019 07:11:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRaly-0008TV-A9 for qemu-devel@nongnu.org; Fri, 17 May 2019 07:11:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40808) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRaly-0008PT-4j for qemu-devel@nongnu.org; Fri, 17 May 2019 07:11:34 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9F63830C0DD5; Fri, 17 May 2019 11:11:27 +0000 (UTC) Received: from Igors-MacBook-Pro (unknown [10.40.205.69]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F7185D6A9; Fri, 17 May 2019 11:11:23 +0000 (UTC) Date: Fri, 17 May 2019 13:11:16 +0200 From: Igor Mammedov To: Wei Yang Message-ID: <20190517131116.02b25408@Igors-MacBook-Pro> In-Reply-To: <20190517005114.19456-1-richardw.yang@linux.intel.com> References: <20190517005114.19456-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 17 May 2019 11:11:32 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 17 May 2019 08:51:14 +0800 Wei Yang wrote: > Pointed out by Philippe Mathieu-Daud=C3=A9 . >=20 > Signed-off-by: Wei Yang > --- > hw/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig > index 7265843cc3..7c59cf900b 100644 > --- a/hw/acpi/Kconfig > +++ b/hw/acpi/Kconfig > @@ -25,7 +25,7 @@ config ACPI_NVDIMM > =20 > config ACPI_PCI > bool > - depends on ACPI > + depends on ACPI && PCI > =20 > config ACPI_VMGENID > bool are you sure you didn't miss anything? On Fri, 17 May 2019 10:37:42 +0200 Philippe Mathieu-Daud=C3=A9 wrote: [...] >=20 > config ARM_VIRT > ... > select ACPI_PCI >=20 > config ACPI_PCI > bool > depends on ACPI && PCI >=20